Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(130)

Unified Diff: trunk/src/chrome/browser/extensions/extension_service_unittest.cc

Issue 369863002: Revert 281130 "Replace "external_install" boolean parameter with..." (Closed) Base URL: svn://svn.chromium.org/chrome/
Patch Set: Created 6 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: trunk/src/chrome/browser/extensions/extension_service_unittest.cc
===================================================================
--- trunk/src/chrome/browser/extensions/extension_service_unittest.cc (revision 281226)
+++ trunk/src/chrome/browser/extensions/extension_service_unittest.cc (working copy)
@@ -857,11 +857,9 @@
// Uninstall it.
if (use_helper) {
- EXPECT_TRUE(ExtensionService::UninstallExtensionHelper(
- service(), id, ExtensionService::UNINSTALL_REASON_FOR_TESTING));
+ EXPECT_TRUE(ExtensionService::UninstallExtensionHelper(service(), id));
} else {
- EXPECT_TRUE(service()->UninstallExtension(
- id, ExtensionService::UNINSTALL_REASON_FOR_TESTING, NULL));
+ EXPECT_TRUE(service()->UninstallExtension(id, false, NULL));
}
--expected_extensions_count_;
@@ -3727,8 +3725,7 @@
const Extension* extension =
(registry()->enabled_extensions().begin())->get();
- EXPECT_TRUE(service()->UninstallExtension(
- extension->id(), ExtensionService::UNINSTALL_REASON_FOR_TESTING, NULL));
+ EXPECT_TRUE(service()->UninstallExtension(extension->id(), false, NULL));
EXPECT_EQ(0u, registry()->enabled_extensions().size());
// Ensure we cannot load it if management policy prohibits installation.
@@ -3775,8 +3772,7 @@
GetManagementPolicy()->RegisterProvider(&provider);
// Attempt to uninstall it.
- EXPECT_FALSE(service()->UninstallExtension(
- good_crx, ExtensionService::UNINSTALL_REASON_FOR_TESTING, NULL));
+ EXPECT_FALSE(service()->UninstallExtension(good_crx, false, NULL));
EXPECT_EQ(1u, registry()->enabled_extensions().size());
EXPECT_TRUE(service()->GetExtensionById(good_crx, false));
@@ -4320,8 +4316,7 @@
EXPECT_TRUE(base::DirectoryExists(idb_path));
// Uninstall the extension.
- service()->UninstallExtension(
- good_crx, ExtensionService::UNINSTALL_REASON_FOR_TESTING, NULL);
+ service()->UninstallExtension(good_crx, false, NULL);
base::RunLoop().RunUntilIdle();
// Check that the cookie is gone.
@@ -4513,8 +4508,7 @@
// Test uninstall.
std::string id = loaded_[0]->id();
EXPECT_FALSE(unloaded_id_.length());
- service()->UninstallExtension(
- id, ExtensionService::UNINSTALL_REASON_FOR_TESTING, NULL);
+ service()->UninstallExtension(id, false, NULL);
base::RunLoop().RunUntilIdle();
EXPECT_EQ(id, unloaded_id_);
ASSERT_EQ(0u, loaded_.size());
@@ -4626,8 +4620,7 @@
std::string id = loaded_[0]->id();
bool no_uninstall =
GetManagementPolicy()->MustRemainEnabled(loaded_[0].get(), NULL);
- service()->UninstallExtension(
- id, ExtensionService::UNINSTALL_REASON_FOR_TESTING, NULL);
+ service()->UninstallExtension(id, false, NULL);
base::RunLoop().RunUntilIdle();
base::FilePath install_path = extensions_install_dir().AppendASCII(id);
@@ -4691,8 +4684,7 @@
// User uninstalls.
loaded_.clear();
- service()->UninstallExtension(
- id, ExtensionService::UNINSTALL_REASON_FOR_TESTING, NULL);
+ service()->UninstallExtension(id, false, NULL);
base::RunLoop().RunUntilIdle();
ASSERT_EQ(0u, loaded_.size());

Powered by Google App Engine
This is Rietveld 408576698