trunk/src/chrome/browser/extensions/api/management/management_api.cc - Issue 369863002: Revert 281130 "Replace "external_install" boolean parameter with..."

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: trunk/src/chrome/browser/extensions/api/management/management_api.cc

Issue 369863002: Revert 281130 "Replace "external_install" boolean parameter with..." (Closed) Base URL: svn://svn.chromium.org/chrome/

Patch Set: Created 6 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: trunk/src/chrome/browser/extensions/api/management/management_api.cc

===================================================================

--- trunk/src/chrome/browser/extensions/api/management/management_api.cc (revision 281226)

+++ trunk/src/chrome/browser/extensions/api/management/management_api.cc (working copy)

@@ -647,10 +647,10 @@

extension_id_);

SendResponse(false);

} else {

- bool success = service()->UninstallExtension(

- extension_id_,

- ExtensionService::UNINSTALL_REASON_MANAGEMENT_API,

- NULL);

+ bool success =

+ service()->UninstallExtension(extension_id_,

+ false, /* external uninstall */

+ NULL);

// TODO set error_ if !success

SendResponse(success);