trunk/src/chrome/browser/extensions/extension_message_bubble_controller_unittest.cc - Issue 369863002: Revert 281130 "Replace "external_install" boolean parameter with..."

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: trunk/src/chrome/browser/extensions/extension_message_bubble_controller_unittest.cc

Issue 369863002: Revert 281130 "Replace "external_install" boolean parameter with..." (Closed) Base URL: svn://svn.chromium.org/chrome/

Patch Set: Created 6 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « trunk/src/chrome/browser/extensions/extension_gcm_app_handler_unittest.cc ('k') | trunk/src/chrome/browser/extensions/extension_service.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: trunk/src/chrome/browser/extensions/extension_message_bubble_controller_unittest.cc

===================================================================

--- trunk/src/chrome/browser/extensions/extension_message_bubble_controller_unittest.cc (revision 281226)

+++ trunk/src/chrome/browser/extensions/extension_message_bubble_controller_unittest.cc (working copy)

@@ -720,12 +720,9 @@

EXPECT_FALSE(prefs->HasSettingsApiBubbleBeenAcknowledged(kId3));

// Clean up after ourselves.

- service_->UninstallExtension(

- kId1, ExtensionService::UNINSTALL_REASON_FOR_TESTING, NULL);

- service_->UninstallExtension(

- kId2, ExtensionService::UNINSTALL_REASON_FOR_TESTING, NULL);

- service_->UninstallExtension(

- kId3, ExtensionService::UNINSTALL_REASON_FOR_TESTING, NULL);

+ service_->UninstallExtension(kId1, false, NULL);

+ service_->UninstallExtension(kId2, false, NULL);

+ service_->UninstallExtension(kId3, false, NULL);

}

@@ -822,12 +819,9 @@

EXPECT_FALSE(prefs->HasNtpOverriddenBubbleBeenAcknowledged(kId3));

// Clean up after ourselves.

- service_->UninstallExtension(

- kId1, ExtensionService::UNINSTALL_REASON_FOR_TESTING, NULL);

- service_->UninstallExtension(

- kId2, ExtensionService::UNINSTALL_REASON_FOR_TESTING, NULL);

- service_->UninstallExtension(

- kId3, ExtensionService::UNINSTALL_REASON_FOR_TESTING, NULL);

+ service_->UninstallExtension(kId1, false, NULL);

+ service_->UninstallExtension(kId2, false, NULL);

+ service_->UninstallExtension(kId3, false, NULL);

}

void SetInstallTime(const std::string& extension_id,

@@ -945,12 +939,9 @@

EXPECT_FALSE(prefs->HasProxyOverriddenBubbleBeenAcknowledged(kId3));

// Clean up after ourselves.

- service_->UninstallExtension(

- kId1, ExtensionService::UNINSTALL_REASON_FOR_TESTING, NULL);

- service_->UninstallExtension(

- kId2, ExtensionService::UNINSTALL_REASON_FOR_TESTING, NULL);

- service_->UninstallExtension(

- kId3, ExtensionService::UNINSTALL_REASON_FOR_TESTING, NULL);

+ service_->UninstallExtension(kId1, false, NULL);

+ service_->UninstallExtension(kId2, false, NULL);

+ service_->UninstallExtension(kId3, false, NULL);

}

} // namespace extensions