Issue 351903003: DevTools: Avoid private member access in non-profiler code

Issue 351903003: DevTools: Avoid private member access in non-profiler code (Closed)

Created:
6 years, 6 months ago by apavlov

Modified:
6 years, 6 months ago

Reviewers:
caseq, sergeyv, pfeldman

CC:
blink-reviews, caseq+blink_chromium.org, loislo+blink_chromium.org, eustas+blink_chromium.org, malch+blink_chromium.org, yurys+blink_chromium.org, lushnikov+blink_chromium.org, vsevik+blink_chromium.org, pfeldman+blink_chromium.org, paulirish+reviews_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, sergeyv+blink_chromium.org, aandrey+blink_chromium.org

Base URL:
svn://svn.chromium.org/blink/trunk

Project:
blink

Visibility:
Public.

More Reviews

Description

DevTools: Avoid private member access in non-profiler code R=caseq, pfeldman, sergeyv Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=177029

Patch Set 1 #

Created: 6 years, 6 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+77 lines, -70 lines)			Patch
M	Source/devtools/front_end/components/DOMBreakpointsSidebarPane.js	View	4 chunks	+4 lines, -4 lines	0 comments	Download
M	Source/devtools/front_end/components/FlameChart.js	View	4 chunks	+4 lines, -4 lines	0 comments	Download
M	Source/devtools/front_end/components/NativeBreakpointsSidebarPane.js	View	3 chunks	+12 lines, -5 lines	0 comments	Download
M	Source/devtools/front_end/sdk/BreakpointManager.js	View	1 chunk	+2 lines, -2 lines	0 comments	Download
M	Source/devtools/front_end/sdk/LayerTreeModel.js	View	3 chunks	+3 lines, -3 lines	0 comments	Download
M	Source/devtools/front_end/sources/BreakpointsSidebarPane.js	View	5 chunks	+7 lines, -7 lines	0 comments	Download
M	Source/devtools/front_end/timeline/Layers3DView.js	View	1 chunk	+1 line, -1 line	0 comments	Download
M	Source/devtools/front_end/timeline/TimelineFlameChart.js	View	3 chunks	+4 lines, -4 lines	0 comments	Download
M	Source/devtools/front_end/timeline/TimelineTracingView.js	View	3 chunks	+3 lines, -3 lines	0 comments	Download
M	Source/devtools/front_end/timeline/TimelineUIUtils.js	View	2 chunks	+2 lines, -2 lines	0 comments	Download
M	Source/devtools/front_end/timeline/TimelineUIUtilsImpl.js	View	2 chunks	+4 lines, -4 lines	0 comments	Download
M	Source/devtools/front_end/timeline/TracingTimelineUIUtils.js	View	4 chunks	+6 lines, -6 lines	0 comments	Download
M	Source/devtools/front_end/timeline/TransformController.js	View	2 chunks	+2 lines, -2 lines	0 comments	Download
M	Source/devtools/front_end/ui/SidebarTreeElement.js	View	4 chunks	+13 lines, -13 lines	0 comments	Download
M	Source/devtools/front_end/ui/View.js	View	8 chunks	+10 lines, -10 lines	0 comments	Download

Messages

Total messages: 6 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/apavlov@chromium.org/351903003/1

6 years, 6 months ago (2014-06-26 16:28:08 UTC) #5

Message was sent while issue was closed.

Change committed as 177029

Expand Messages | Collapse Messages