Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2112)

Unified Diff: Source/devtools/front_end/ui/SidebarTreeElement.js

Issue 351903003: DevTools: Avoid private member access in non-profiler code (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Created 6 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « Source/devtools/front_end/timeline/TransformController.js ('k') | Source/devtools/front_end/ui/View.js » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/devtools/front_end/ui/SidebarTreeElement.js
diff --git a/Source/devtools/front_end/ui/SidebarTreeElement.js b/Source/devtools/front_end/ui/SidebarTreeElement.js
index 77d97ae09a1d8e1d7471809a9d783622dcc96108..34a126f9fc74bd79b443cc990e78acfa312bc27e 100644
--- a/Source/devtools/front_end/ui/SidebarTreeElement.js
+++ b/Source/devtools/front_end/ui/SidebarTreeElement.js
@@ -58,7 +58,7 @@ WebInspector.SidebarSectionTreeElement.prototype = {
onattach: function()
{
- this._listItemNode.classList.add("sidebar-tree-section");
+ this.listItemElement.classList.add("sidebar-tree-section");
},
onreveal: function()
@@ -111,8 +111,8 @@ WebInspector.SidebarTreeElement.prototype = {
set small(x)
{
this._small = x;
- if (this._listItemNode)
- this._listItemNode.classList.toggle("small", this._small);
+ if (this.listItemElement)
+ this.listItemElement.classList.toggle("small", this._small);
},
get mainTitle()
@@ -139,7 +139,7 @@ WebInspector.SidebarTreeElement.prototype = {
set wait(x)
{
- this._listItemNode.classList.toggle("wait", x);
+ this.listItemElement.classList.toggle("wait", x);
},
refreshTitles: function()
@@ -169,26 +169,26 @@ WebInspector.SidebarTreeElement.prototype = {
onattach: function()
{
- this._listItemNode.classList.add("sidebar-tree-item");
+ this.listItemElement.classList.add("sidebar-tree-item");
if (this.className)
- this._listItemNode.classList.add(this.className);
+ this.listItemElement.classList.add(this.className);
if (this.small)
- this._listItemNode.classList.add("small");
+ this.listItemElement.classList.add("small");
if (this.hasChildren && this.disclosureButton)
- this._listItemNode.appendChild(this.disclosureButton);
+ this.listItemElement.appendChild(this.disclosureButton);
- this._listItemNode.appendChild(this.iconElement);
- this._listItemNode.appendChild(this.statusElement);
- this._listItemNode.appendChild(this.titlesElement);
+ this.listItemElement.appendChild(this.iconElement);
+ this.listItemElement.appendChild(this.statusElement);
+ this.listItemElement.appendChild(this.titlesElement);
},
onreveal: function()
{
- if (this._listItemNode)
- this._listItemNode.scrollIntoViewIfNeeded(false);
+ if (this.listItemElement)
+ this.listItemElement.scrollIntoViewIfNeeded(false);
},
__proto__: TreeElement.prototype
« no previous file with comments | « Source/devtools/front_end/timeline/TransformController.js ('k') | Source/devtools/front_end/ui/View.js » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698