Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1310)

Unified Diff: Source/devtools/front_end/components/NativeBreakpointsSidebarPane.js

Issue 351903003: DevTools: Avoid private member access in non-profiler code (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Created 6 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: Source/devtools/front_end/components/NativeBreakpointsSidebarPane.js
diff --git a/Source/devtools/front_end/components/NativeBreakpointsSidebarPane.js b/Source/devtools/front_end/components/NativeBreakpointsSidebarPane.js
index 6e723c473216b4a16b43390421db334bc2e27500..3feeaf77c7ff618f6e4f81241f9e3f728252fd5e 100644
--- a/Source/devtools/front_end/components/NativeBreakpointsSidebarPane.js
+++ b/Source/devtools/front_end/components/NativeBreakpointsSidebarPane.js
@@ -48,11 +48,15 @@ WebInspector.NativeBreakpointsSidebarPane = function(title)
}
WebInspector.NativeBreakpointsSidebarPane.prototype = {
- _addListElement: function(element, beforeElement)
+ /**
+ * @param {!Element} element
+ * @param {?Element=} beforeElement
+ */
+ addListElement: function(element, beforeElement)
{
- if (beforeElement)
+ if (beforeElement) {
this.listElement.insertBefore(element, beforeElement);
- else {
+ } else {
if (!this.listElement.firstChild) {
this.bodyElement.removeChild(this.emptyElement);
this.bodyElement.appendChild(this.listElement);
@@ -61,7 +65,10 @@ WebInspector.NativeBreakpointsSidebarPane.prototype = {
}
},
- _removeListElement: function(element)
+ /**
+ * @param {!Element} element
+ */
+ removeListElement: function(element)
{
this.listElement.removeChild(element);
if (!this.listElement.firstChild) {
@@ -70,7 +77,7 @@ WebInspector.NativeBreakpointsSidebarPane.prototype = {
}
},
- _reset: function()
+ reset: function()
{
this.listElement.removeChildren();
if (this.listElement.parentElement) {
« no previous file with comments | « Source/devtools/front_end/components/FlameChart.js ('k') | Source/devtools/front_end/sdk/BreakpointManager.js » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698