Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1440)

Unified Diff: Source/devtools/front_end/timeline/TracingTimelineUIUtils.js

Issue 351903003: DevTools: Avoid private member access in non-profiler code (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Created 6 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: Source/devtools/front_end/timeline/TracingTimelineUIUtils.js
diff --git a/Source/devtools/front_end/timeline/TracingTimelineUIUtils.js b/Source/devtools/front_end/timeline/TracingTimelineUIUtils.js
index aa7baf0f04abae66d0443b898bb20bebc6722371..4d2b82e95ec88a81d871e73f41b60495d5279938 100644
--- a/Source/devtools/front_end/timeline/TracingTimelineUIUtils.js
+++ b/Source/devtools/front_end/timeline/TracingTimelineUIUtils.js
@@ -346,8 +346,8 @@ WebInspector.TracingTimelineUIUtils.buildDetailsNodeForTraceEvent = function(eve
detailsText = eventData ? eventData["type"] : null;
break;
case recordType.Paint:
- var width = WebInspector.TimelineUIUtils._quadWidth(eventData.clip);
- var height = WebInspector.TimelineUIUtils._quadHeight(eventData.clip);
+ var width = WebInspector.TimelineUIUtils.quadWidth(eventData.clip);
+ var height = WebInspector.TimelineUIUtils.quadHeight(eventData.clip);
if (width && height)
detailsText = WebInspector.UIString("%d\u2009\u00d7\u2009%d", width, height);
break;
@@ -478,7 +478,7 @@ WebInspector.TracingTimelineUIUtils.buildTraceEventDetails = function(event, mod
if (event.imageURL)
WebInspector.DOMPresentationUtils.buildImagePreviewContents(target, event.imageURL, false, barrier.createCallback(saveImage));
else if (event.picture)
- WebInspector.TracingTimelineUIUtils._buildPicturePreviewContent(event.picture, barrier.createCallback(saveImage));
+ WebInspector.TracingTimelineUIUtils.buildPicturePreviewContent(event.picture, barrier.createCallback(saveImage));
}
if (event.backendNodeId)
target.domModel.pushNodesByBackendIdsToFrontend([event.backendNodeId], barrier.createCallback(setRelatedNode));
@@ -588,8 +588,8 @@ WebInspector.TracingTimelineUIUtils._buildTraceEventDetailsSynchronously = funct
case recordTypes.Paint:
var clip = eventData["clip"];
contentHelper.appendTextRow(WebInspector.UIString("Location"), WebInspector.UIString("(%d, %d)", clip[0], clip[1]));
- var clipWidth = WebInspector.TimelineUIUtils._quadWidth(clip);
- var clipHeight = WebInspector.TimelineUIUtils._quadHeight(clip);
+ var clipWidth = WebInspector.TimelineUIUtils.quadWidth(clip);
+ var clipHeight = WebInspector.TimelineUIUtils.quadHeight(clip);
contentHelper.appendTextRow(WebInspector.UIString("Dimensions"), WebInspector.UIString("%d × %d", clipWidth, clipHeight));
// Fall-through intended.
@@ -714,7 +714,7 @@ WebInspector.TracingTimelineUIUtils._aggregatedStatsForTraceEvent = function(tot
* @param {string} encodedPicture
* @param {function(!Element=)} callback
*/
-WebInspector.TracingTimelineUIUtils._buildPicturePreviewContent = function(encodedPicture, callback)
+WebInspector.TracingTimelineUIUtils.buildPicturePreviewContent = function(encodedPicture, callback)
{
var snapshotId;
« no previous file with comments | « Source/devtools/front_end/timeline/TimelineUIUtilsImpl.js ('k') | Source/devtools/front_end/timeline/TransformController.js » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698