Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1252)

Unified Diff: Source/devtools/front_end/components/FlameChart.js

Issue 351903003: DevTools: Avoid private member access in non-profiler code (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Created 6 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: Source/devtools/front_end/components/FlameChart.js
diff --git a/Source/devtools/front_end/components/FlameChart.js b/Source/devtools/front_end/components/FlameChart.js
index f818b5b8e1858824a0d782c3ede5ac1344785dac..9f4bd0e328ef37b525e02d5ad0e79ff804bb1447 100644
--- a/Source/devtools/front_end/components/FlameChart.js
+++ b/Source/devtools/front_end/components/FlameChart.js
@@ -65,7 +65,7 @@ WebInspector.FlameChart = function(dataProvider, flameChartDelegate, isTopDown)
this._vScrollElement = this.element.createChild("div", "flame-chart-v-scroll");
this._vScrollContent = this._vScrollElement.createChild("div");
- this._vScrollElement.addEventListener("scroll", this._scheduleUpdate.bind(this), false);
+ this._vScrollElement.addEventListener("scroll", this.scheduleUpdate.bind(this), false);
this._entryInfo = this.element.createChild("div", "profile-entry-info");
this._highlightElement = this.element.createChild("div", "flame-chart-highlight-element");
@@ -399,7 +399,7 @@ WebInspector.FlameChart.prototype = {
{
this._timeWindowLeft = startTime;
this._timeWindowRight = endTime;
- this._scheduleUpdate();
+ this.scheduleUpdate();
},
/**
@@ -926,7 +926,7 @@ WebInspector.FlameChart.prototype = {
onResize: function()
{
this._updateScrollBar();
- this._scheduleUpdate();
+ this.scheduleUpdate();
},
_updateScrollBar: function()
@@ -937,7 +937,7 @@ WebInspector.FlameChart.prototype = {
this._offsetHeight = this.element.offsetHeight;
},
- _scheduleUpdate: function()
+ scheduleUpdate: function()
{
if (this._updateTimerId)
return;

Powered by Google App Engine
This is Rietveld 408576698