Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1420)

Unified Diff: Source/devtools/front_end/ui/View.js

Issue 351903003: DevTools: Avoid private member access in non-profiler code (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Created 6 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « Source/devtools/front_end/ui/SidebarTreeElement.js ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/devtools/front_end/ui/View.js
diff --git a/Source/devtools/front_end/ui/View.js b/Source/devtools/front_end/ui/View.js
index ff280b3515d00d2a9619796771923a25c2c016b6..49d12d2c81cea70e007ed8f2e428d1613260ab66 100644
--- a/Source/devtools/front_end/ui/View.js
+++ b/Source/devtools/front_end/ui/View.js
@@ -67,7 +67,7 @@ WebInspector.View.createStyleElement = function(cssFile)
WebInspector.View.prototype = {
markAsRoot: function()
{
- WebInspector.View._assert(!this.element.parentElement, "Attempt to mark as root attached node");
+ WebInspector.View.__assert(!this.element.parentElement, "Attempt to mark as root attached node");
this._isRoot = true;
},
@@ -205,7 +205,7 @@ WebInspector.View.prototype = {
*/
show: function(parentElement, insertBefore)
{
- WebInspector.View._assert(parentElement, "Attempt to attach view with no parent element");
+ WebInspector.View.__assert(parentElement, "Attempt to attach view with no parent element");
// Update view hierarchy
if (this.element.parentElement !== parentElement) {
@@ -221,7 +221,7 @@ WebInspector.View.prototype = {
this._parentView._children.push(this);
this._isRoot = false;
} else
- WebInspector.View._assert(this._isRoot, "Attempt to attach view to orphan node");
+ WebInspector.View.__assert(this._isRoot, "Attempt to attach view to orphan node");
} else if (this._visible) {
return;
}
@@ -284,14 +284,14 @@ WebInspector.View.prototype = {
// Update view hierarchy
if (this._parentView) {
var childIndex = this._parentView._children.indexOf(this);
- WebInspector.View._assert(childIndex >= 0, "Attempt to remove non-child view");
+ WebInspector.View.__assert(childIndex >= 0, "Attempt to remove non-child view");
this._parentView._children.splice(childIndex, 1);
var parent = this._parentView;
this._parentView = null;
if (this._hasNonZeroConstraints())
parent.invalidateConstraints();
} else
- WebInspector.View._assert(this._isRoot, "Removing non-root view from DOM");
+ WebInspector.View.__assert(this._isRoot, "Removing non-root view from DOM");
},
detachChildViews: function()
@@ -562,7 +562,7 @@ WebInspector.View._decrementViewCounter = function(parentElement, childElement)
}
}
-WebInspector.View._assert = function(condition, message)
+WebInspector.View.__assert = function(condition, message)
{
if (!condition) {
console.trace();
@@ -669,7 +669,7 @@ WebInspector.VBoxWithResizeCallback.prototype = {
*/
Element.prototype.appendChild = function(child)
{
- WebInspector.View._assert(!child.__view || child.parentElement === this, "Attempt to add view via regular DOM operation.");
+ WebInspector.View.__assert(!child.__view || child.parentElement === this, "Attempt to add view via regular DOM operation.");
return WebInspector.View._originalAppendChild.call(this, child);
}
@@ -681,7 +681,7 @@ Element.prototype.appendChild = function(child)
*/
Element.prototype.insertBefore = function(child, anchor)
{
- WebInspector.View._assert(!child.__view || child.parentElement === this, "Attempt to add view via regular DOM operation.");
+ WebInspector.View.__assert(!child.__view || child.parentElement === this, "Attempt to add view via regular DOM operation.");
return WebInspector.View._originalInsertBefore.call(this, child, anchor);
}
@@ -692,12 +692,12 @@ Element.prototype.insertBefore = function(child, anchor)
*/
Element.prototype.removeChild = function(child)
{
- WebInspector.View._assert(!child.__viewCounter && !child.__view, "Attempt to remove element containing view via regular DOM operation");
+ WebInspector.View.__assert(!child.__viewCounter && !child.__view, "Attempt to remove element containing view via regular DOM operation");
return WebInspector.View._originalRemoveChild.call(this, child);
}
Element.prototype.removeChildren = function()
{
- WebInspector.View._assert(!this.__viewCounter, "Attempt to remove element containing view via regular DOM operation");
+ WebInspector.View.__assert(!this.__viewCounter, "Attempt to remove element containing view via regular DOM operation");
WebInspector.View._originalRemoveChildren.call(this);
}
« no previous file with comments | « Source/devtools/front_end/ui/SidebarTreeElement.js ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698