Rename "managed (mode|user)" to "supervised user" (part 5)

Rename "managed (mode|user)" to "supervised user" (part 5)

Followup to https://codereview.chromium.org/345563008/, https://codereview.chromium.org/335273005/, https://codereview.chromium.org/335833003/, and https://codereview.chromium.org/316863002/

This CL renames resource IDs.

Still missing:
- ChromeOS-specific code in c/b/chromeos/login/managed/ and ash/system/
- JavaScript
- The global ENABLE_MANAGED_USERS define

TBR=oshima@chromium.org (c/app/theme and c/b/chromeos)
TBR=msw@chromium.org (c/b/ui/cocoa and c/b/ui/views)
TBR=noms@chromium.org (c/b/profiles)
TBR=thakis@chromium.org (c/b/browser_resources.grd)

All the TBRs are simple renames.

BUG=385113
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=279835

[Marc Treib, 2014-06-24 09:56:26]

No need to look at anything except the .grd files, the rest is just the
corresponding renames.

[Bernhard Bauer, 2014-06-24 10:11:11]

lgtm

[Pam (message me for reviews), 2014-06-24 18:26:05]

Is renaming all these strings going to trigger translation requests for them? We
should alert the l10n team if so.

[Marc Treib, 2014-06-25 08:16:30]

On 2014/06/24 18:26:05, Pam (also PM for reviews) wrote:
> Is renaming all these strings going to trigger translation requests for them?
We
> should alert the l10n team if so.

I don't know, but I would assume so? Who would I contact about that?

[Bernhard Bauer, 2014-06-25 08:25:18]

On 2014/06/24 18:26:05, Pam (also PM for reviews) wrote:
> Is renaming all these strings going to trigger translation requests for them?
We
> should alert the l10n team if so.

I think entries in the translation console are keyed by message, with the
description just serving as an additional explanation for context, so as long as
the message stays the same, I'm not sure if this will really result in
translation requests.

[Marc Treib, 2014-06-25 08:34:12]

On 2014/06/25 08:25:18, Bernhard Bauer wrote:
> On 2014/06/24 18:26:05, Pam (also PM for reviews) wrote:
> > Is renaming all these strings going to trigger translation requests for
them?
> We
> > should alert the l10n team if so.
> 
> I think entries in the translation console are keyed by message, with the
> description just serving as an additional explanation for context, so as long
as
> the message stays the same, I'm not sure if this will really result in
> translation requests.

Presumably by the message ID, not text? Quite a few of the IDs did change.

[Bernhard Bauer, 2014-06-25 08:43:30]

On 2014/06/25 08:34:12, treib wrote:
> On 2014/06/25 08:25:18, Bernhard Bauer wrote:
> > On 2014/06/24 18:26:05, Pam (also PM for reviews) wrote:
> > > Is renaming all these strings going to trigger translation requests for
> them?
> > We
> > > should alert the l10n team if so.
> > 
> > I think entries in the translation console are keyed by message, with the
> > description just serving as an additional explanation for context, so as
long
> as
> > the message stays the same, I'm not sure if this will really result in
> > translation requests.
> 
> Presumably by the message ID, not text? Quite a few of the IDs did change.

No, message. IIRC, the translation console is a big dictionary from English to
any other language, with descriptions for additional context. This allows
translations to be shared across all products. The Message ID is just an
internal detail that a translator doesn't need to see.

[Marc Treib, 2014-06-25 08:52:42]

On 2014/06/25 08:43:30, Bernhard Bauer wrote:
> On 2014/06/25 08:34:12, treib wrote:
> > On 2014/06/25 08:25:18, Bernhard Bauer wrote:
> > > On 2014/06/24 18:26:05, Pam (also PM for reviews) wrote:
> > > > Is renaming all these strings going to trigger translation requests for
> > them?
> > > We
> > > > should alert the l10n team if so.
> > > 
> > > I think entries in the translation console are keyed by message, with the
> > > description just serving as an additional explanation for context, so as
> long
> > as
> > > the message stays the same, I'm not sure if this will really result in
> > > translation requests.
> > 
> > Presumably by the message ID, not text? Quite a few of the IDs did change.
> 
> No, message. IIRC, the translation console is a big dictionary from English to
> any other language, with descriptions for additional context. This allows
> translations to be shared across all products. The Message ID is just an
> internal detail that a translator doesn't need to see.

Nice! In that case, all will be fine :)

[Pam (message me for reviews), 2014-06-25 14:00:05]

I'll check with jamarante@. It's got to be keyed at least partly by both,
since "Group" might need a different translation depending on whether it's
a verb or a noun -- just to pull an example out of the air. :) Removing a
noun usage and adding a verb usage would need re-translation, and is
equivalent to changing an ID and description.

- Pam


On Wed, Jun 25, 2014 at 1:52 AM, <treib@chromium.org> wrote:

> On 2014/06/25 08:43:30, Bernhard Bauer wrote:
>
>> On 2014/06/25 08:34:12, treib wrote:
>> > On 2014/06/25 08:25:18, Bernhard Bauer wrote:
>> > > On 2014/06/24 18:26:05, Pam (also PM for reviews) wrote:
>> > > > Is renaming all these strings going to trigger translation requests
>> for
>> > them?
>> > > We
>> > > > should alert the l10n team if so.
>> > >
>> > > I think entries in the translation console are keyed by message, with
>> the
>> > > description just serving as an additional explanation for context, so
>> as
>> long
>> > as
>> > > the message stays the same, I'm not sure if this will really result in
>> > > translation requests.
>> >
>> > Presumably by the message ID, not text? Quite a few of the IDs did
>> change.
>>
>
>  No, message. IIRC, the translation console is a big dictionary from
>> English to
>> any other language, with descriptions for additional context. This allows
>> translations to be shared across all products. The Message ID is just an
>> internal detail that a translator doesn't need to see.
>>
>
> Nice! In that case, all will be fine :)
>
> https://codereview.chromium.org/350183002/
>

-- 
 Google Germany GmbH
Dienerstr. 12, 80331 München
AG Hamburg, HRB 86891
 Sitz der Gesellschaft: Hamburg Geschäftsführer: Graham Law,
Christine Elizabeth FloresTax ID: 48/725/00206
 VAT ID: DE813741370

To unsubscribe from this group and stop receiving emails from it, send an email
to chromium-reviews+unsubscribe@chromium.org.

[Pam (message me for reviews), 2014-06-25 19:14:08]

All is indeed fine. LGTM, to be formal about it.

Official word from tc:

"
The translation console doesn't get the IDs in the grd files so changes to them
are never seen by the translation console.

Duplicate strings get collapsed by default (e.g., all the strings that are
"Cancel" only get translated once).  If you want the same string translated
differently, then add a "meaning" attribute to the message node.  You can find
some existing examples of this in the grd files.
"

On 2014/06/25 14:00:05, Pam (also PM for reviews) wrote:
> I'll check with jamarante@. It's got to be keyed at least partly by both,
> since "Group" might need a different translation depending on whether it's
> a verb or a noun -- just to pull an example out of the air. :) Removing a
> noun usage and adding a verb usage would need re-translation, and is
> equivalent to changing an ID and description.
> 
> - Pam
> 
> 
> On Wed, Jun 25, 2014 at 1:52 AM, <mailto:treib@chromium.org> wrote:
> 
> > On 2014/06/25 08:43:30, Bernhard Bauer wrote:
> >
> >> On 2014/06/25 08:34:12, treib wrote:
> >> > On 2014/06/25 08:25:18, Bernhard Bauer wrote:
> >> > > On 2014/06/24 18:26:05, Pam (also PM for reviews) wrote:
> >> > > > Is renaming all these strings going to trigger translation requests
> >> for
> >> > them?
> >> > > We
> >> > > > should alert the l10n team if so.
> >> > >
> >> > > I think entries in the translation console are keyed by message, with
> >> the
> >> > > description just serving as an additional explanation for context, so
> >> as
> >> long
> >> > as
> >> > > the message stays the same, I'm not sure if this will really result in
> >> > > translation requests.
> >> >
> >> > Presumably by the message ID, not text? Quite a few of the IDs did
> >> change.
> >>
> >
> >  No, message. IIRC, the translation console is a big dictionary from
> >> English to
> >> any other language, with descriptions for additional context. This allows
> >> translations to be shared across all products. The Message ID is just an
> >> internal detail that a translator doesn't need to see.
> >>
> >
> > Nice! In that case, all will be fine :)
> >
> > https://codereview.chromium.org/350183002/
> >
> 
> -- 
>  Google Germany GmbH
> Dienerstr. 12, 80331 München
> AG Hamburg, HRB 86891
>  Sitz der Gesellschaft: Hamburg Geschäftsführer: Graham Law,
> Christine Elizabeth FloresTax ID: 48/725/00206
>  VAT ID: DE813741370
> 
> To unsubscribe from this group and stop receiving emails from it, send an
email
> to mailto:chromium-reviews+unsubscribe@chromium.org.

[Pam (message me for reviews), 2014-06-25 19:14:21]

The CQ bit was checked by pam@chromium.org

[commit-bot: I haz the power, 2014-06-25 19:15:48]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/treib@chromium.org/350183002/60001

[commit-bot: I haz the power, 2014-06-25 22:09:19]

Change committed as 279835