Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(142)

Issue 347823004: Remove Sk prefix from some bench classes. (Closed)

Created:
6 years, 6 months ago by tfarina
Modified:
6 years, 6 months ago
Reviewers:
mtklein
CC:
reviews_skia.org, reed1
Base URL:
https://skia.googlesource.com/skia.git@master
Visibility:
Public.

Description

Remove Sk prefix from some bench classes. This idea came while commenting on https://codereview.chromium.org/343583005/ Since SkBenchmark, SkBenchLogger and SkGMBench are not part of the Skia library, they should not have the Sk prefix. BUG=None TEST=make all R=mtklein@google.com Committed: https://skia.googlesource.com/skia/+/f168b86d7fafc5c20c87bebc6fd393cb17e120ca

Patch Set 1 : #

Total comments: 4

Patch Set 2 : SkGMBench -> GMBench #

Unified diffs Side-by-side diffs Delta from patch set Stats (+463 lines, -837 lines) Patch
M bench/AAClipBench.cpp View 5 chunks +11 lines, -11 lines 0 comments Download
A + bench/BenchLogger.h View 3 chunks +9 lines, -10 lines 0 comments Download
A + bench/BenchLogger.cpp View 2 chunks +6 lines, -6 lines 0 comments Download
M bench/BenchTool/BenchTool.xcodeproj/project.pbxproj View 4 chunks +4 lines, -4 lines 0 comments Download
A + bench/Benchmark.h View 3 chunks +9 lines, -9 lines 0 comments Download
A + bench/Benchmark.cpp View 4 chunks +8 lines, -8 lines 0 comments Download
M bench/BicubicBench.cpp View 2 chunks +4 lines, -4 lines 0 comments Download
M bench/BitmapBench.cpp View 3 chunks +4 lines, -4 lines 0 comments Download
M bench/BitmapRectBench.cpp View 3 chunks +4 lines, -4 lines 0 comments Download
M bench/BitmapScaleBench.cpp View 2 chunks +4 lines, -4 lines 0 comments Download
M bench/BlurBench.cpp View 3 chunks +4 lines, -4 lines 0 comments Download
M bench/BlurImageFilterBench.cpp View 3 chunks +3 lines, -3 lines 0 comments Download
M bench/BlurRectBench.cpp View 3 chunks +4 lines, -4 lines 0 comments Download
M bench/BlurRoundRectBench.cpp View 3 chunks +4 lines, -4 lines 0 comments Download
M bench/ChartBench.cpp View 3 chunks +3 lines, -3 lines 0 comments Download
M bench/ChecksumBench.cpp View 3 chunks +3 lines, -3 lines 0 comments Download
M bench/ChromeBench.cpp View 3 chunks +3 lines, -3 lines 0 comments Download
M bench/CmapBench.cpp View 3 chunks +3 lines, -3 lines 0 comments Download
M bench/ColorFilterBench.cpp View 3 chunks +3 lines, -3 lines 0 comments Download
M bench/ColorPrivBench.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M bench/CoverageBench.cpp View 3 chunks +3 lines, -3 lines 0 comments Download
M bench/DashBench.cpp View 9 chunks +13 lines, -13 lines 0 comments Download
M bench/DecodeBench.cpp View 3 chunks +3 lines, -3 lines 0 comments Download
M bench/DeferredCanvasBench.cpp View 2 chunks +3 lines, -3 lines 0 comments Download
M bench/DeferredSurfaceCopyBench.cpp View 3 chunks +3 lines, -3 lines 0 comments Download
M bench/DisplacementBench.cpp View 3 chunks +3 lines, -3 lines 0 comments Download
M bench/ETCBitmapBench.cpp View 4 chunks +11 lines, -11 lines 0 comments Download
M bench/FSRectBench.cpp View 3 chunks +3 lines, -3 lines 0 comments Download
M bench/FontCacheBench.cpp View 5 chunks +5 lines, -5 lines 0 comments Download
M bench/FontScalerBench.cpp View 2 chunks +3 lines, -3 lines 0 comments Download
A + bench/GMBench.h View 1 2 chunks +6 lines, -6 lines 0 comments Download
A + bench/GMBench.cpp View 1 3 chunks +7 lines, -7 lines 0 comments Download
M bench/GameBench.cpp View 3 chunks +3 lines, -3 lines 0 comments Download
M bench/GrMemoryPoolBench.cpp View 7 chunks +7 lines, -7 lines 0 comments Download
M bench/GrOrderedSetBench.cpp View 5 chunks +7 lines, -7 lines 0 comments Download
M bench/GrResourceCacheBench.cpp View 4 chunks +6 lines, -6 lines 0 comments Download
M bench/GradientBench.cpp View 5 chunks +5 lines, -5 lines 0 comments Download
M bench/HairlinePathBench.cpp View 4 chunks +4 lines, -4 lines 0 comments Download
M bench/ImageCacheBench.cpp View 2 chunks +3 lines, -3 lines 0 comments Download
M bench/ImageDecodeBench.cpp View 3 chunks +3 lines, -3 lines 0 comments Download
M bench/ImageFilterDAGBench.cpp View 3 chunks +4 lines, -4 lines 0 comments Download
M bench/InterpBench.cpp View 2 chunks +4 lines, -4 lines 0 comments Download
M bench/LightingBench.cpp View 3 chunks +3 lines, -3 lines 0 comments Download
M bench/LineBench.cpp View 3 chunks +3 lines, -3 lines 0 comments Download
M bench/MagnifierBench.cpp View 3 chunks +3 lines, -3 lines 0 comments Download
M bench/MathBench.cpp View 9 chunks +15 lines, -15 lines 0 comments Download
M bench/Matrix44Bench.cpp View 2 chunks +3 lines, -3 lines 0 comments Download
M bench/MatrixBench.cpp View 2 chunks +3 lines, -3 lines 0 comments Download
M bench/MatrixConvolutionBench.cpp View 2 chunks +4 lines, -4 lines 0 comments Download
M bench/MemcpyBench.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M bench/MemoryBench.cpp View 3 chunks +5 lines, -5 lines 0 comments Download
M bench/MemsetBench.cpp View 2 chunks +4 lines, -4 lines 0 comments Download
M bench/MergeBench.cpp View 3 chunks +3 lines, -3 lines 0 comments Download
M bench/MorphologyBench.cpp View 3 chunks +4 lines, -4 lines 0 comments Download
M bench/MutexBench.cpp View 2 chunks +3 lines, -3 lines 0 comments Download
M bench/PathBench.cpp View 14 chunks +17 lines, -17 lines 0 comments Download
M bench/PathIterBench.cpp View 3 chunks +3 lines, -3 lines 0 comments Download
M bench/PathUtilsBench.cpp View 3 chunks +4 lines, -4 lines 0 comments Download
M bench/PerlinNoiseBench.cpp View 2 chunks +3 lines, -3 lines 0 comments Download
M bench/PicturePlaybackBench.cpp View 3 chunks +3 lines, -3 lines 0 comments Download
M bench/PictureRecordBench.cpp View 3 chunks +3 lines, -3 lines 0 comments Download
M bench/PremulAndUnpremulAlphaOpsBench.cpp View 2 chunks +3 lines, -3 lines 0 comments Download
M bench/QuadTreeBench.cpp View 4 chunks +5 lines, -5 lines 0 comments Download
M bench/RTreeBench.cpp View 4 chunks +5 lines, -5 lines 0 comments Download
M bench/ReadPixBench.cpp View 3 chunks +3 lines, -3 lines 0 comments Download
M bench/RectBench.cpp View 5 chunks +5 lines, -5 lines 0 comments Download
M bench/RectanizerBench.cpp View 3 chunks +3 lines, -3 lines 0 comments Download
M bench/RectoriBench.cpp View 2 chunks +5 lines, -5 lines 0 comments Download
M bench/RefCntBench.cpp View 9 chunks +14 lines, -14 lines 0 comments Download
M bench/RegionBench.cpp View 4 chunks +5 lines, -5 lines 0 comments Download
M bench/RegionContainBench.cpp View 3 chunks +3 lines, -3 lines 0 comments Download
M bench/RepeatTileBench.cpp View 3 chunks +3 lines, -3 lines 0 comments Download
M bench/ResultsWriter.h View 3 chunks +4 lines, -4 lines 0 comments Download
M bench/ScalarBench.cpp View 4 chunks +5 lines, -5 lines 0 comments Download
M bench/ShaderMaskBench.cpp View 3 chunks +3 lines, -3 lines 0 comments Download
D bench/SkBenchLogger.h View 1 chunk +0 lines, -77 lines 0 comments Download
D bench/SkBenchLogger.cpp View 1 chunk +0 lines, -30 lines 0 comments Download
D bench/SkBenchmark.h View 1 chunk +0 lines, -128 lines 0 comments Download
D bench/SkBenchmark.cpp View 1 chunk +0 lines, -56 lines 0 comments Download
M bench/SkGMBench.h View 1 1 chunk +0 lines, -31 lines 0 comments Download
D bench/SkGMBench.cpp View 1 1 chunk +0 lines, -51 lines 0 comments Download
M bench/SkipZeroesBench.cpp View 3 chunks +3 lines, -3 lines 0 comments Download
M bench/SortBench.cpp View 3 chunks +7 lines, -7 lines 0 comments Download
M bench/StackBench.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M bench/StrokeBench.cpp View 3 chunks +3 lines, -3 lines 0 comments Download
M bench/TableBench.cpp View 3 chunks +3 lines, -3 lines 0 comments Download
M bench/TextBench.cpp View 3 chunks +3 lines, -3 lines 0 comments Download
M bench/TileBench.cpp View 3 chunks +3 lines, -3 lines 0 comments Download
M bench/VertBench.cpp View 2 chunks +4 lines, -4 lines 0 comments Download
M bench/WritePixelsBench.cpp View 2 chunks +3 lines, -3 lines 0 comments Download
M bench/WriterBench.cpp View 2 chunks +3 lines, -3 lines 0 comments Download
M bench/XfermodeBench.cpp View 4 chunks +5 lines, -5 lines 0 comments Download
M bench/benchmain.cpp View 1 14 chunks +31 lines, -31 lines 0 comments Download
M dm/DM.cpp View 3 chunks +3 lines, -3 lines 0 comments Download
M dm/DMBenchTask.h View 4 chunks +5 lines, -5 lines 0 comments Download
M dm/DMBenchTask.cpp View 1 chunk +4 lines, -4 lines 0 comments Download
M dm/DMUtil.h View 1 chunk +1 line, -1 line 0 comments Download
M gyp/bench.gyp View 1 1 chunk +4 lines, -4 lines 0 comments Download
M gyp/bench.gypi View 1 chunk +2 lines, -2 lines 0 comments Download
M gyp/tools.gyp View 1 chunk +2 lines, -2 lines 0 comments Download
M tools/PictureBenchmark.h View 1 chunk +2 lines, -4 lines 0 comments Download
M tools/PictureResultsWriter.h View 4 chunks +6 lines, -4 lines 0 comments Download
M tools/bbh_shootout.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M tools/bench_pictures_main.cpp View 2 chunks +4 lines, -4 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
tfarina
6 years, 6 months ago (2014-06-19 18:05:37 UTC) #1
mtklein
lgtm https://codereview.chromium.org/347823004/diff/20001/bench/SkGMBench.h File bench/SkGMBench.h (right): https://codereview.chromium.org/347823004/diff/20001/bench/SkGMBench.h#newcode15 bench/SkGMBench.h:15: class SkGMBench : public Benchmark { This too ...
6 years, 6 months ago (2014-06-19 18:45:17 UTC) #2
tfarina
https://codereview.chromium.org/347823004/diff/20001/bench/SkGMBench.h File bench/SkGMBench.h (right): https://codereview.chromium.org/347823004/diff/20001/bench/SkGMBench.h#newcode15 bench/SkGMBench.h:15: class SkGMBench : public Benchmark { On 2014/06/19 18:45:17, ...
6 years, 6 months ago (2014-06-19 19:02:01 UTC) #3
tfarina
The CQ bit was checked by tfarina@chromium.org
6 years, 6 months ago (2014-06-19 19:02:25 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/tfarina@chromium.org/347823004/40001
6 years, 6 months ago (2014-06-19 19:03:07 UTC) #5
commit-bot: I haz the power
6 years, 6 months ago (2014-06-19 19:32:35 UTC) #6
Message was sent while issue was closed.
Change committed as f168b86d7fafc5c20c87bebc6fd393cb17e120ca

Powered by Google App Engine
This is Rietveld 408576698