Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(787)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 337473004: aw: Use comparison DCHECKs where appropriate (Closed)

Created:
6 years, 6 months ago by boliu
Modified:
6 years, 3 months ago
Reviewers:
hush (inactive)
CC:
chromium-reviews, cbentzel+watch_chromium.org, android-webview-reviews_chromium.org
Project:
chromium
Visibility:
Public.

Description

aw: Use comparison DCHECKs where appropriate BUG= Committed: https://crrev.com/2d46b52a7f43b16be4efb3b2128a7046a95fd5d2 Cr-Commit-Position: refs/heads/master@{#292693}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+30 lines, -29 lines) Patch
M android_webview/browser/aw_browser_context.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M android_webview/browser/aw_content_browser_client.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M android_webview/browser/aw_login_delegate.cc View 1 chunk +1 line, -1 line 0 comments Download
M android_webview/browser/browser_view_renderer.cc View 2 chunks +5 lines, -5 lines 0 comments Download
M android_webview/browser/net/input_stream_reader.cc View 1 chunk +1 line, -1 line 0 comments Download
M android_webview/browser/net_disk_cache_remover.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M android_webview/browser/renderer_host/aw_resource_dispatcher_host_delegate.cc View 1 chunk +1 line, -1 line 0 comments Download
M android_webview/lib/main/aw_main_delegate.cc View 1 chunk +1 line, -1 line 0 comments Download
M android_webview/native/aw_contents.cc View 1 chunk +1 line, -1 line 0 comments Download
M android_webview/native/aw_settings.cc View 1 chunk +1 line, -1 line 0 comments Download
M android_webview/native/aw_web_resource_response_impl.cc View 1 chunk +1 line, -1 line 0 comments Download
M android_webview/native/input_stream_impl.cc View 1 chunk +2 lines, -1 line 0 comments Download
M android_webview/native/state_serializer.cc View 1 chunk +3 lines, -3 lines 0 comments Download
M android_webview/renderer/aw_render_view_ext.cc View 1 chunk +1 line, -1 line 0 comments Download
M android_webview/renderer/print_web_view_helper.cc View 2 chunks +6 lines, -6 lines 0 comments Download

Messages

Total messages: 8 (1 generated)
boliu
Hmm, on second thought, maybe I should hold off landing this for a few weeks ...
6 years, 6 months ago (2014-06-26 21:14:30 UTC) #1
boliu
boliu@chromium.org changed reviewers: + hush@chromium.org - sgurun@chromium.org
6 years, 3 months ago (2014-08-29 01:11:13 UTC) #2
boliu
change reviewer to hush since selim is going on vacation
6 years, 3 months ago (2014-08-29 01:11:13 UTC) #3
hush (inactive)
lgtm
6 years, 3 months ago (2014-08-29 18:35:51 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/boliu@chromium.org/337473004/1
6 years, 3 months ago (2014-08-29 18:36:51 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1) as b0b8587221fbe3c19f6bd5afabba9f0264e83060
6 years, 3 months ago (2014-08-29 22:34:34 UTC) #7
commit-bot: I haz the power
6 years, 3 months ago (2014-09-10 03:10:53 UTC) #8
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/2d46b52a7f43b16be4efb3b2128a7046a95fd5d2
Cr-Commit-Position: refs/heads/master@{#292693}

Powered by Google App Engine
This is Rietveld 408576698