android_webview/renderer/aw_render_view_ext.cc - Issue 337473004: aw: Use comparison DCHECKs where appropriate

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: android_webview/renderer/aw_render_view_ext.cc

Issue 337473004: aw: Use comparison DCHECKs where appropriate (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Created 6 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: android_webview/renderer/aw_render_view_ext.cc

diff --git a/android_webview/renderer/aw_render_view_ext.cc b/android_webview/renderer/aw_render_view_ext.cc

index 7dd91e27dcc07ba9a9860ab2e57612da518c80b2..4df3abd88d97dab1b8436fbd6dabc60c778ebec5 100644

--- a/android_webview/renderer/aw_render_view_ext.cc

+++ b/android_webview/renderer/aw_render_view_ext.cc

@@ -133,7 +133,7 @@ void PopulateHitTestData(const GURL& absolute_link_url,

data->extra_data_for_type = data->img_src.possibly_invalid_spec();

} else if (is_editable) {

data->type = AwHitTestData::EDIT_TEXT_TYPE;

- DCHECK(data->extra_data_for_type.length() == 0);

+ DCHECK_EQ(0u, data->extra_data_for_type.length());

}