Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2064)

Unified Diff: android_webview/browser/browser_view_renderer.cc

Issue 337473004: aw: Use comparison DCHECKs where appropriate (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 6 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « android_webview/browser/aw_login_delegate.cc ('k') | android_webview/browser/net/input_stream_reader.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: android_webview/browser/browser_view_renderer.cc
diff --git a/android_webview/browser/browser_view_renderer.cc b/android_webview/browser/browser_view_renderer.cc
index 1107e30783ca427dda775d2a7c56f4f82a4c3dd2..3dbef7d8f1dd62056a4b223ff9b7cd7aac24b52c 100644
--- a/android_webview/browser/browser_view_renderer.cc
+++ b/android_webview/browser/browser_view_renderer.cc
@@ -489,7 +489,7 @@ void BrowserViewRenderer::SetContinuousInvalidate(bool invalidate) {
void BrowserViewRenderer::SetDipScale(float dip_scale) {
dip_scale_ = dip_scale;
- CHECK(dip_scale_ > 0);
+ CHECK_GT(dip_scale_, 0);
}
gfx::Vector2d BrowserViewRenderer::max_scroll_offset() const {
@@ -568,10 +568,10 @@ void BrowserViewRenderer::SetTotalRootLayerScrollOffset(
max_scroll_offset_dip_.y());
}
- DCHECK(0 <= scroll_offset.x());
- DCHECK(0 <= scroll_offset.y());
- DCHECK(scroll_offset.x() <= max_offset.x());
- DCHECK(scroll_offset.y() <= max_offset.y());
+ DCHECK_LE(0, scroll_offset.x());
+ DCHECK_LE(0, scroll_offset.y());
+ DCHECK_LE(scroll_offset.x(), max_offset.x());
+ DCHECK_LE(scroll_offset.y(), max_offset.y());
client_->ScrollContainerViewTo(scroll_offset);
}
« no previous file with comments | « android_webview/browser/aw_login_delegate.cc ('k') | android_webview/browser/net/input_stream_reader.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698