android_webview/native/aw_settings.cc - Issue 337473004: aw: Use comparison DCHECKs where appropriate

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: android_webview/native/aw_settings.cc

Issue 337473004: aw: Use comparison DCHECKs where appropriate (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Created 6 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: android_webview/native/aw_settings.cc

diff --git a/android_webview/native/aw_settings.cc b/android_webview/native/aw_settings.cc

index 3779cd80a2768f85e9a6e0063fc358ddf81bf9ad..ffcdd6cf5b54c410974a9b222d8ec47f7eb011f7 100644

--- a/android_webview/native/aw_settings.cc

+++ b/android_webview/native/aw_settings.cc

@@ -262,7 +262,7 @@ void AwSettings::RenderViewCreated(content::RenderViewHost* render_view_host) {

// we shouldn't have to deal with the multiple RVH per WebContents case. That

// in turn means that the newly created RVH is always the 'current' RVH

// (since we only ever go from 0 to 1 RVH instances) and hence the DCHECK.

- DCHECK(web_contents()->GetRenderViewHost() == render_view_host);

+ DCHECK_EQ(render_view_host, web_contents()->GetRenderViewHost());

UpdateEverything();

}