android_webview/browser/aw_login_delegate.cc - Issue 337473004: aw: Use comparison DCHECKs where appropriate

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: android_webview/browser/aw_login_delegate.cc

Issue 337473004: aw: Use comparison DCHECKs where appropriate (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Created 6 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: android_webview/browser/aw_login_delegate.cc

diff --git a/android_webview/browser/aw_login_delegate.cc b/android_webview/browser/aw_login_delegate.cc

index 08107919cbe58b74607306f93eed5f47acbb4ef8..d388790cbd7c628d32d0e655332e0eecd2d94d5a 100644

--- a/android_webview/browser/aw_login_delegate.cc

+++ b/android_webview/browser/aw_login_delegate.cc

@@ -64,7 +64,7 @@ AwLoginDelegate::AwLoginDelegate(net::AuthChallengeInfo* auth_info,

AwLoginDelegate::~AwLoginDelegate() {

// The Auth handler holds a ref count back on |this| object, so it should be

// impossible to reach here while this object still owns an auth handler.

- DCHECK(aw_http_auth_handler_ == NULL);

+ DCHECK(!aw_http_auth_handler_);

}

void AwLoginDelegate::Proceed(const base::string16& user,