android_webview/native/state_serializer.cc - Issue 337473004: aw: Use comparison DCHECKs where appropriate

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: android_webview/native/state_serializer.cc

Issue 337473004: aw: Use comparison DCHECKs where appropriate (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Created 6 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: android_webview/native/state_serializer.cc

diff --git a/android_webview/native/state_serializer.cc b/android_webview/native/state_serializer.cc

index 9b013a17710e7728edff61f7af7d89a7486dbbbb..b9698835ddd13ef8cbf4feac327f0c44a5782cde 100644

--- a/android_webview/native/state_serializer.cc

+++ b/android_webview/native/state_serializer.cc

@@ -50,9 +50,9 @@ bool WriteToPickle(const content::WebContents& web_contents,

web_contents.GetController();

const int entry_count = controller.GetEntryCount();

const int selected_entry = controller.GetCurrentEntryIndex();

- DCHECK(entry_count >= 0);

- DCHECK(selected_entry >= -1); // -1 is valid

- DCHECK(selected_entry < entry_count);

+ DCHECK_GE(entry_count, 0);

+ DCHECK_GE(selected_entry, -1); // -1 is valid

+ DCHECK_LT(selected_entry, entry_count);

if (!pickle->WriteInt(entry_count))

return false;