Have Frame::script() return a reference

Have Frame::script() return a reference

Have Frame::script() return a reference instead of a pointer as it
can never return null. This makes the calling code look safer and
gets rid of a few unnecessary null-checks.

Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=160271

[haraken, 2013-10-21 22:32:10]

LGTM

[Inactive, 2013-10-22 13:18:24]

tkent@, could you please take a look for Source/web?

[abarth-chromium, 2013-10-22 18:41:20]

rs=me

[abarth-chromium, 2013-10-22 18:41:27]

lgtm

[commit-bot: I haz the power, 2013-10-22 20:31:34]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/ch.dumez@samsung.com/33523002/1

[commit-bot: I haz the power, 2013-10-22 20:31:47]

Failed to apply patch for Source/core/inspector/PageRuntimeAgent.cpp:
While running patch -p1 --forward --force --no-backup-if-mismatch;
  patching file Source/core/inspector/PageRuntimeAgent.cpp
  Hunk #1 FAILED at 162.
  1 out of 1 hunk FAILED -- saving rejects to file
Source/core/inspector/PageRuntimeAgent.cpp.rej

Patch:       Source/core/inspector/PageRuntimeAgent.cpp
Index: Source/core/inspector/PageRuntimeAgent.cpp
diff --git a/Source/core/inspector/PageRuntimeAgent.cpp
b/Source/core/inspector/PageRuntimeAgent.cpp
index
aa8bac6c0eb37d91ce0ebe868d05c06a05b44ef9..23bb98f7bca4fb33605241f2b08451d6fc0ce211
100644
--- a/Source/core/inspector/PageRuntimeAgent.cpp
+++ b/Source/core/inspector/PageRuntimeAgent.cpp
@@ -162,13 +162,13 @@ void PageRuntimeAgent::reportExecutionContextCreation()
 {
     Vector<std::pair<ScriptState*, SecurityOrigin*> > isolatedContexts;
     for (Frame* frame = m_inspectedPage->mainFrame(); frame; frame =
frame->tree()->traverseNext()) {
-        if (!frame->script()->canExecuteScripts(NotAboutToExecuteScript))
+        if (!frame->script().canExecuteScripts(NotAboutToExecuteScript))
             continue;
         String frameId = m_pageAgent->frameId(frame);
 
         ScriptState* scriptState = mainWorldScriptState(frame);
         notifyContextCreated(frameId, scriptState, 0, true);
-        frame->script()->collectIsolatedContexts(isolatedContexts);
+        frame->script().collectIsolatedContexts(isolatedContexts);
         if (isolatedContexts.isEmpty())
             continue;
         for (size_t i = 0; i< isolatedContexts.size(); i++)

[commit-bot: I haz the power, 2013-10-22 21:21:14]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/ch.dumez@samsung.com/33523002/100001

[commit-bot: I haz the power, 2013-10-22 23:24:19]

Commit queue rejected this change because the description was changed
between the time the change entered the commit queue and the time it
was ready to commit. You can safely check the commit box again.

[commit-bot: I haz the power, 2013-10-22 23:28:49]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/ch.dumez@samsung.com/33523002/100001

[commit-bot: I haz the power, 2013-10-22 23:30:12]

Change committed as 160271