Source/bindings/v8/V8WindowShell.cpp - Issue 33523002: Have Frame::script() return a reference

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/bindings/v8/V8WindowShell.cpp

Issue 33523002: Have Frame::script() return a reference (Closed) Base URL: svn://svn.chromium.org/blink/trunk

Patch Set: Rebase on master Created 7 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: Source/bindings/v8/V8WindowShell.cpp

diff --git a/Source/bindings/v8/V8WindowShell.cpp b/Source/bindings/v8/V8WindowShell.cpp

index f2bf45d7c5d29013a2261e66fe520bc6a960335d..4bd753f47e8b5ba2b6ddaf273b9820807a3a1efc 100644

--- a/Source/bindings/v8/V8WindowShell.cpp

+++ b/Source/bindings/v8/V8WindowShell.cpp

@@ -212,9 +212,9 @@ bool V8WindowShell::initializeIfNeeded()

}

if (!isMainWorld) {

- V8WindowShell* mainWindow = m_frame->script()->existingWindowShell(mainThreadNormalWorld());

+ V8WindowShell* mainWindow = m_frame->script().existingWindowShell(mainThreadNormalWorld());

if (mainWindow && !mainWindow->context().IsEmpty())

- setInjectedScriptContextDebugId(context, m_frame->script()->contextDebugId(mainWindow->context()));

+ setInjectedScriptContextDebugId(context, m_frame->script().contextDebugId(mainWindow->context()));

}

m_perContextData = V8PerContextData::create(context);