Source/web/InspectorFrontendClientImpl.cpp - Issue 33523002: Have Frame::script() return a reference

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/web/InspectorFrontendClientImpl.cpp

Issue 33523002: Have Frame::script() return a reference (Closed) Base URL: svn://svn.chromium.org/blink/trunk

Patch Set: Rebase on master Created 7 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: Source/web/InspectorFrontendClientImpl.cpp

diff --git a/Source/web/InspectorFrontendClientImpl.cpp b/Source/web/InspectorFrontendClientImpl.cpp

index e8e15664f44e3bd81ad0b314eb012c23707d2795..636ad95368ee651b0a8d3735b8b77d89af72c13b 100644

--- a/Source/web/InspectorFrontendClientImpl.cpp

+++ b/Source/web/InspectorFrontendClientImpl.cpp

@@ -63,7 +63,7 @@ InspectorFrontendClientImpl::~InspectorFrontendClientImpl()

void InspectorFrontendClientImpl::windowObjectCleared()

{

v8::HandleScope handleScope(v8::Isolate::GetCurrent());

- v8::Handle<v8::Context> frameContext = m_frontendPage->mainFrame() ? m_frontendPage->mainFrame()->script()->currentWorldContext() : v8::Local<v8::Context>();

+ v8::Handle<v8::Context> frameContext = m_frontendPage->mainFrame() ? m_frontendPage->mainFrame()->script().currentWorldContext() : v8::Local<v8::Context>();

v8::Context::Scope contextScope(frameContext);

if (m_frontendHost)

@@ -74,7 +74,7 @@ void InspectorFrontendClientImpl::windowObjectCleared()

global->Set(v8::String::New("InspectorFrontendHost"), frontendHostObj);

- ScriptController* scriptController = m_frontendPage->mainFrame() ? m_frontendPage->mainFrame()->script() : 0;

+ ScriptController* scriptController = m_frontendPage->mainFrame() ? &m_frontendPage->mainFrame()->script() : 0;

if (scriptController) {

String installLegacyOverrides =

"" // Support for legacy front-ends (<M31). Do not add items here.

« no previous file with comments | « Source/web/FrameLoaderClientImpl.cpp ('k') | Source/web/WebBindings.cpp » ('j') | no next file with comments »