Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(392)

Unified Diff: Source/bindings/v8/PageScriptDebugServer.cpp

Issue 33523002: Have Frame::script() return a reference (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Rebase on master Created 7 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « Source/bindings/v8/NPV8Object.cpp ('k') | Source/bindings/v8/ScheduledAction.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/bindings/v8/PageScriptDebugServer.cpp
diff --git a/Source/bindings/v8/PageScriptDebugServer.cpp b/Source/bindings/v8/PageScriptDebugServer.cpp
index db235b45b0ff353fa0dd79a4199b71e03978ec1d..ed4d52261e2ab58f25515aacc5d47639ac453881 100644
--- a/Source/bindings/v8/PageScriptDebugServer.cpp
+++ b/Source/bindings/v8/PageScriptDebugServer.cpp
@@ -90,8 +90,8 @@ PageScriptDebugServer::PageScriptDebugServer()
void PageScriptDebugServer::addListener(ScriptDebugListener* listener, Page* page)
{
- ScriptController* scriptController = page->mainFrame()->script();
- if (!scriptController->canExecuteScripts(NotAboutToExecuteScript))
+ ScriptController& scriptController = page->mainFrame()->script();
+ if (!scriptController.canExecuteScripts(NotAboutToExecuteScript))
return;
v8::HandleScope scope(m_isolate);
@@ -106,7 +106,7 @@ void PageScriptDebugServer::addListener(ScriptDebugListener* listener, Page* pag
}
m_listenersMap.set(page, listener);
- V8WindowShell* shell = scriptController->existingWindowShell(mainThreadNormalWorld());
+ V8WindowShell* shell = scriptController.existingWindowShell(mainThreadNormalWorld());
if (!shell || !shell->isContextInitialized())
return;
v8::Local<v8::Context> context = shell->context();
« no previous file with comments | « Source/bindings/v8/NPV8Object.cpp ('k') | Source/bindings/v8/ScheduledAction.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698