Source/core/inspector/InspectorClient.cpp - Issue 33523002: Have Frame::script() return a reference

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/inspector/InspectorClient.cpp

Issue 33523002: Have Frame::script() return a reference (Closed) Base URL: svn://svn.chromium.org/blink/trunk

Patch Set: Rebase on master Created 7 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: Source/core/inspector/InspectorClient.cpp

diff --git a/Source/core/inspector/InspectorClient.cpp b/Source/core/inspector/InspectorClient.cpp

index 58a2cdb9d691e3867d524412335cc06a9fb22ed6..bc0bcd7ef00a0d96f8dcd5653c4d919110c405be 100644

--- a/Source/core/inspector/InspectorClient.cpp

+++ b/Source/core/inspector/InspectorClient.cpp

@@ -47,10 +47,7 @@ bool InspectorClient::doDispatchMessageOnFrontendPage(Page* frontendPage, const

if (!frame)

return false;

- ScriptController* scriptController = frame->script();

- if (!scriptController)

- return false;

- scriptController->executeScriptInMainWorld("InspectorFrontendAPI.dispatchMessageAsync(" + message + ");", ScriptController::ExecuteScriptWhenScriptsDisabled);

+ frame->script().executeScriptInMainWorld("InspectorFrontendAPI.dispatchMessageAsync(" + message + ");", ScriptController::ExecuteScriptWhenScriptsDisabled);

return true;

}

« no previous file with comments | « Source/core/inspector/InspectorAgent.cpp ('k') | Source/core/inspector/InspectorIndexedDBAgent.cpp » ('j') | no next file with comments »