Source/web/WebBindings.cpp - Issue 33523002: Have Frame::script() return a reference

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/web/WebBindings.cpp

Issue 33523002: Have Frame::script() return a reference (Closed) Base URL: svn://svn.chromium.org/blink/trunk

Patch Set: Rebase on master Created 7 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: Source/web/WebBindings.cpp

diff --git a/Source/web/WebBindings.cpp b/Source/web/WebBindings.cpp

index 3c26df81e50fef688e834b20e7100f33879e13df..e7bd4948c905831bc5c90f9e50331c84799aba8f 100644

--- a/Source/web/WebBindings.cpp

+++ b/Source/web/WebBindings.cpp

@@ -391,7 +391,7 @@ v8::Handle<v8::Value> WebBindings::toV8Value(const NPVariant* variant)

V8NPObject* v8Object = npObjectToV8NPObject(object);

if (!v8Object)

return v8::Undefined(isolate);

- return convertNPVariantToV8Object(variant, v8Object->rootObject->frame()->script()->windowScriptNPObject(), isolate);

+ return convertNPVariantToV8Object(variant, v8Object->rootObject->frame()->script().windowScriptNPObject(), isolate);

}

// Safe to pass 0 since we have checked the script object class to make sure the

// argument is a primitive v8 type.

« no previous file with comments | « Source/web/InspectorFrontendClientImpl.cpp ('k') | Source/web/WebDevToolsAgentImpl.cpp » ('j') | no next file with comments »