Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(311)

Issue 331573004: Add EXPERIMENTAL_beginRecording() for SkRecord-based recording. (Closed)

Created:
6 years, 6 months ago by mtklein_C
Modified:
6 years, 6 months ago
Reviewers:
mtklein, reed1
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Visibility:
Public.

Description

Add EXPERIMENTAL_beginRecording() for SkRecord-based recording. The interesting stuff is in SkPictureRecorder.{h,cpp}. The rest is mostly moving SkRecord from its own directories into core to avoid circular dependencies in GYP. After plumbing SkRecord all the way through in Picture, I'll delete its old entry point include/record/SkRecording.h. For now it and record.gypi need to stay where they are to keep Chrome building. BUG=skia: Committed: https://skia.googlesource.com/skia/+/887f3979f0c717e69a8b7d169169bc27eb46d3b5

Patch Set 1 #

Patch Set 2 : put back #

Unified diffs Side-by-side diffs Delta from patch set Stats (+77 lines, -1658 lines) Patch
M gyp/core.gyp View 1 chunk +2 lines, -1 line 0 comments Download
M gyp/core.gypi View 1 chunk +4 lines, -0 lines 0 comments Download
M gyp/dm.gyp View 1 chunk +0 lines, -1 line 0 comments Download
D gyp/record.gyp View 1 chunk +0 lines, -19 lines 0 comments Download
M gyp/record.gypi View 1 chunk +1 line, -10 lines 0 comments Download
M gyp/tests.gypi View 2 chunks +0 lines, -2 lines 0 comments Download
M gyp/tools.gyp View 3 chunks +0 lines, -5 lines 0 comments Download
M include/core/SkPictureRecorder.h View 4 chunks +16 lines, -2 lines 0 comments Download
M src/core/SkPictureRecorder.cpp View 2 chunks +56 lines, -26 lines 0 comments Download
A + src/core/SkRecord.h View 0 chunks +-1 lines, --1 lines 0 comments Download
A + src/core/SkRecordDraw.h View 0 chunks +-1 lines, --1 lines 0 comments Download
A + src/core/SkRecordDraw.cpp View 0 chunks +-1 lines, --1 lines 0 comments Download
A + src/core/SkRecordOpts.h View 0 chunks +-1 lines, --1 lines 0 comments Download
A + src/core/SkRecordOpts.cpp View 0 chunks +-1 lines, --1 lines 0 comments Download
A + src/core/SkRecordPattern.h View 0 chunks +-1 lines, --1 lines 0 comments Download
A + src/core/SkRecorder.h View 0 chunks +-1 lines, --1 lines 0 comments Download
A + src/core/SkRecorder.cpp View 0 chunks +-1 lines, --1 lines 0 comments Download
A + src/core/SkRecording.cpp View 1 1 chunk +1 line, -1 line 0 comments Download
A + src/core/SkRecords.h View 0 chunks +-1 lines, --1 lines 0 comments Download
D src/record/SkRecord.h View 1 chunk +0 lines, -234 lines 0 comments Download
D src/record/SkRecordDraw.h View 1 chunk +0 lines, -55 lines 0 comments Download
D src/record/SkRecordDraw.cpp View 1 chunk +0 lines, -71 lines 0 comments Download
D src/record/SkRecordOpts.h View 1 chunk +0 lines, -35 lines 0 comments Download
D src/record/SkRecordOpts.cpp View 1 chunk +0 lines, -303 lines 0 comments Download
D src/record/SkRecordPattern.h View 1 chunk +0 lines, -183 lines 0 comments Download
D src/record/SkRecorder.h View 1 chunk +0 lines, -112 lines 0 comments Download
D src/record/SkRecorder.cpp View 1 chunk +0 lines, -263 lines 0 comments Download
D src/record/SkRecording.cpp View 1 chunk +0 lines, -44 lines 0 comments Download
D src/record/SkRecords.h View 1 chunk +0 lines, -291 lines 0 comments Download
M tests/RecordingTest.cpp View 1 1 chunk +1 line, -1 line 0 comments Download
M tools/bench_playback.cpp View 1 1 chunk +2 lines, -1 line 0 comments Download
M tools/bench_record.cpp View 2 chunks +3 lines, -7 lines 0 comments Download

Messages

Total messages: 9 (0 generated)
mtklein_C
This adds one new public method, EXPERIMENTAL_beginRecording() to SkPictureRecorder.
6 years, 6 months ago (2014-06-17 18:24:00 UTC) #1
mtklein
The CQ bit was checked by mtklein@google.com
6 years, 6 months ago (2014-06-17 18:27:06 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/mtklein@chromium.org/331573004/20001
6 years, 6 months ago (2014-06-17 18:27:45 UTC) #3
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 6 months ago (2014-06-17 18:27:46 UTC) #4
commit-bot: I haz the power
No LGTM from a valid reviewer yet. Only full committers are accepted. Even if an ...
6 years, 6 months ago (2014-06-17 18:27:47 UTC) #5
reed1
lgtm
6 years, 6 months ago (2014-06-17 18:40:24 UTC) #6
mtklein
The CQ bit was checked by mtklein@google.com
6 years, 6 months ago (2014-06-17 18:41:19 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/mtklein@chromium.org/331573004/20001
6 years, 6 months ago (2014-06-17 18:41:51 UTC) #8
commit-bot: I haz the power
6 years, 6 months ago (2014-06-17 19:08:20 UTC) #9
Message was sent while issue was closed.
Change committed as 887f3979f0c717e69a8b7d169169bc27eb46d3b5

Powered by Google App Engine
This is Rietveld 408576698