[IndexedDB] Use consistent enums on both sides of IPC.

[IndexedDB] Use consistent enums on both sides of IPC.

Numerous IndexedDB IPC messages sent renderer->browser are defined members that are enums from Blink (public/platform), and on receipt are static_cast to types
defined in Chromium:

blink::WebIDBCursor::Direction => indexed_db::CursorDirection
blink::WebIDBDatabase::TaskType => IndexedDBDatabase::TaskType
blink::WebIDBDatabase::PutMode => IndexedDBDatabase::PutMode
blink::WebIDBDatabase::TransactionMode => uint16 => indexed_db::TransactionMode

Nothing enforces the equality of these enums at compile time.

So the approach adopted here is to move the Blink-side enums into public/platform/WebIDBTypes.h and use it everywhere.

Patch spread across chromium content side as well as on Blink side.
Chromium side: https://codereview.chromium.org/320833002
Blink side: https://codereview.chromium.org/325683002

BUG=381848
R=dglazkov@chromium.org, jsbell@chromium.org

Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=176435

[Pritam Nikam, 2014-06-09 10:43:36]

Hi,

I've adopted 2nd approach i.e. to move the Blink-side enums into
public/platform/WebIDBTypes.h and use it everywhere.

Patch spread across chromium content side as well as on Blink side.
Chromium side: https://codereview.chromium.org/320833002
Blink side: https://codereview.chromium.org/325683002 

Please have a look.

[jsbell, 2014-06-09 16:27:09]

Initial feedback.

Does Chromium compile with only this change (but not the Chromium one?) or will
this need to be split up for landing?

https://codereview.chromium.org/325683002/diff/1/Source/modules/indexeddb/IDB...
File Source/modules/indexeddb/IDBCursor.h (right):

https://codereview.chromium.org/325683002/diff/1/Source/modules/indexeddb/IDB...
Source/modules/indexeddb/IDBCursor.h:34: #include
"public/platform/WebIDBCursor.h"
needs to include public/platform/WebIDBTypes.h

https://codereview.chromium.org/325683002/diff/1/Source/modules/indexeddb/IDB...
File Source/modules/indexeddb/IDBDatabase.cpp (right):

https://codereview.chromium.org/325683002/diff/1/Source/modules/indexeddb/IDB...
Source/modules/indexeddb/IDBDatabase.cpp:46: #include
"public/platform/WebIDBKeyPath.h"
Needs to include public/platform/WebIDBTypes.h

https://codereview.chromium.org/325683002/diff/1/Source/modules/indexeddb/IDB...
File Source/modules/indexeddb/IDBIndex.h (right):

https://codereview.chromium.org/325683002/diff/1/Source/modules/indexeddb/IDB...
Source/modules/indexeddb/IDBIndex.h:36: #include
"public/platform/WebIDBDatabase.h"
Needs to include public/platform/WebIDBTypes.h

https://codereview.chromium.org/325683002/diff/1/Source/modules/indexeddb/IDB...
File Source/modules/indexeddb/IDBObjectStore.h (right):

https://codereview.chromium.org/325683002/diff/1/Source/modules/indexeddb/IDB...
Source/modules/indexeddb/IDBObjectStore.h:40: #include
"public/platform/WebIDBDatabase.h"
Needs to include public/platform/WebIDBTypes.h

https://codereview.chromium.org/325683002/diff/1/Source/modules/indexeddb/Ins...
File Source/modules/indexeddb/InspectorIndexedDBAgent.cpp (right):

https://codereview.chromium.org/325683002/diff/1/Source/modules/indexeddb/Ins...
Source/modules/indexeddb/InspectorIndexedDBAgent.cpp:62: #include
"public/platform/WebIDBCursor.h"
Needs to include public/platform/WebIDBTypes.h

https://codereview.chromium.org/325683002/diff/1/public/platform/WebIDBTypes.h
File public/platform/WebIDBTypes.h (right):

https://codereview.chromium.org/325683002/diff/1/public/platform/WebIDBTypes....
public/platform/WebIDBTypes.h:53: enum Direction {
Since this is only scoped to the blink:: namespace, can you prefix the names and
values, as is done in the other enums?

i.e.:

enum WebIDBCursorDirection { WebIDBCursorDirectioNext, ... }

https://codereview.chromium.org/325683002/diff/1/public/platform/WebIDBTypes....
public/platform/WebIDBTypes.h:61: enum TaskType {
enum WebIDBTaskType { WebIDBTaskTypeNormal, ... }

https://codereview.chromium.org/325683002/diff/1/public/platform/WebIDBTypes....
public/platform/WebIDBTypes.h:67: enum PutMode {
enum WebIDBPutMode { WebIDBPutModeAddOrUpdate, ... }

https://codereview.chromium.org/325683002/diff/1/public/platform/WebIDBTypes....
public/platform/WebIDBTypes.h:74: enum TransactionMode {
enum WebIDBTransactionMode { WebIDBTransactionModeReadOnly, ... }

[Pritam Nikam, 2014-06-11 14:07:47]

Thanks jsbell!
Incorporated review comments and new patch is ready for review. Please have a
look.

https://codereview.chromium.org/325683002/diff/1/Source/modules/indexeddb/IDB...
File Source/modules/indexeddb/IDBCursor.h (right):

https://codereview.chromium.org/325683002/diff/1/Source/modules/indexeddb/IDB...
Source/modules/indexeddb/IDBCursor.h:34: #include
"public/platform/WebIDBCursor.h"
On 2014/06/09 16:27:09, jsbell wrote:
> needs to include public/platform/WebIDBTypes.h

Done.

https://codereview.chromium.org/325683002/diff/1/Source/modules/indexeddb/IDB...
File Source/modules/indexeddb/IDBDatabase.cpp (right):

https://codereview.chromium.org/325683002/diff/1/Source/modules/indexeddb/IDB...
Source/modules/indexeddb/IDBDatabase.cpp:46: #include
"public/platform/WebIDBKeyPath.h"
On 2014/06/09 16:27:09, jsbell wrote:
> Needs to include public/platform/WebIDBTypes.h

Done.

https://codereview.chromium.org/325683002/diff/1/Source/modules/indexeddb/IDB...
File Source/modules/indexeddb/IDBIndex.h (right):

https://codereview.chromium.org/325683002/diff/1/Source/modules/indexeddb/IDB...
Source/modules/indexeddb/IDBIndex.h:36: #include
"public/platform/WebIDBDatabase.h"
On 2014/06/09 16:27:09, jsbell wrote:
> Needs to include public/platform/WebIDBTypes.h

Done.

https://codereview.chromium.org/325683002/diff/1/Source/modules/indexeddb/IDB...
File Source/modules/indexeddb/IDBObjectStore.h (right):

https://codereview.chromium.org/325683002/diff/1/Source/modules/indexeddb/IDB...
Source/modules/indexeddb/IDBObjectStore.h:40: #include
"public/platform/WebIDBDatabase.h"
On 2014/06/09 16:27:09, jsbell wrote:
> Needs to include public/platform/WebIDBTypes.h

Done.

https://codereview.chromium.org/325683002/diff/1/Source/modules/indexeddb/Ins...
File Source/modules/indexeddb/InspectorIndexedDBAgent.cpp (right):

https://codereview.chromium.org/325683002/diff/1/Source/modules/indexeddb/Ins...
Source/modules/indexeddb/InspectorIndexedDBAgent.cpp:62: #include
"public/platform/WebIDBCursor.h"
On 2014/06/09 16:27:09, jsbell wrote:
> Needs to include public/platform/WebIDBTypes.h

Done.

https://codereview.chromium.org/325683002/diff/1/public/platform/WebIDBTypes.h
File public/platform/WebIDBTypes.h (right):

https://codereview.chromium.org/325683002/diff/1/public/platform/WebIDBTypes....
public/platform/WebIDBTypes.h:53: enum Direction {
On 2014/06/09 16:27:09, jsbell wrote:
> Since this is only scoped to the blink:: namespace, can you prefix the names
and
> values, as is done in the other enums?
> 
> i.e.:
> 
> enum WebIDBCursorDirection { WebIDBCursorDirectioNext, ... }

Done.

https://codereview.chromium.org/325683002/diff/1/public/platform/WebIDBTypes....
public/platform/WebIDBTypes.h:61: enum TaskType {
On 2014/06/09 16:27:09, jsbell wrote:
> enum WebIDBTaskType { WebIDBTaskTypeNormal, ... }

Done.

https://codereview.chromium.org/325683002/diff/1/public/platform/WebIDBTypes....
public/platform/WebIDBTypes.h:67: enum PutMode {
On 2014/06/09 16:27:09, jsbell wrote:
> enum WebIDBPutMode { WebIDBPutModeAddOrUpdate, ... }

Done.

https://codereview.chromium.org/325683002/diff/1/public/platform/WebIDBTypes....
public/platform/WebIDBTypes.h:74: enum TransactionMode {
On 2014/06/09 16:27:09, jsbell wrote:
> enum WebIDBTransactionMode { WebIDBTransactionModeReadOnly, ... }

Done.

[Pritam Nikam, 2014-06-11 14:12:03]

On 2014/06/09 16:27:09, jsbell wrote:
> Initial feedback.
> 
> Does Chromium compile with only this change (but not the Chromium one?) or
will
> this need to be split up for landing?
> 

In my opinion both patches are needed as both are part of different repo.
And both patches need to be landed simultaneously.

[jsbell, 2014-06-11 16:21:40]

On 2014/06/11 14:12:03, Pritam Nikam wrote:
> In my opinion both patches are needed as both are part of different repo.
> And both patches need to be landed simultaneously.

Unfortunately, we can't land things simultaneously. Chromium pulls in specific
revisions of Blink, not tip-of-tree, and is updated semi-regularly when a
revision passes the test bots on all platforms. Therefore it is necessary to
engineer patches to land separately.

A typical approach for something like this is to land a Blink patch that
includes the new enums but leaves the old ones intact (with a FIXME to remove
them), wait for that revision of Blink to "roll" into Chromium, then land the
Chromium change that uses the new enums, then land a follow-up patch in Blink
that removes the old enums.

[jsbell, 2014-06-11 16:28:07]

l*g*t*m but will need to be split up for landing

You can probably define the old enums in terms of the new ones, and add a FIXME
to each e.g. 'FIXME: Remove once Chromium is updated to use the new enums'

https://codereview.chromium.org/325683002/diff/20001/public/platform/WebIDBTy...
File public/platform/WebIDBTypes.h (right):

https://codereview.chromium.org/325683002/diff/20001/public/platform/WebIDBTy...
public/platform/WebIDBTypes.h:74: enum WebIDBTransactionMode {
Can you define a Last here as well? It's not currently used in Chromium's
message header, but it should be.

[Pritam Nikam, 2014-06-12 09:36:03]

Thanks jsbell!

I've uploaded a new patch (#3) with only blink side changes incorporating review
comments. Please have a look.

https://codereview.chromium.org/325683002/diff/20001/public/platform/WebIDBTy...
File public/platform/WebIDBTypes.h (right):

https://codereview.chromium.org/325683002/diff/20001/public/platform/WebIDBTy...
public/platform/WebIDBTypes.h:74: enum WebIDBTransactionMode {
On 2014/06/11 16:28:07, jsbell wrote:
> Can you define a Last here as well? It's not currently used in Chromium's
> message header, but it should be.

Done.

[Pritam Nikam, 2014-06-12 09:37:58]

On 2014/06/11 16:21:40, jsbell wrote:
> On 2014/06/11 14:12:03, Pritam Nikam wrote:
> > In my opinion both patches are needed as both are part of different repo.
> > And both patches need to be landed simultaneously.
> 
> Unfortunately, we can't land things simultaneously. Chromium pulls in specific
> revisions of Blink, not tip-of-tree, and is updated semi-regularly when a
> revision passes the test bots on all platforms. Therefore it is necessary to
> engineer patches to land separately.
> 
> A typical approach for something like this is to land a Blink patch that
> includes the new enums but leaves the old ones intact (with a FIXME to remove
> them), wait for that revision of Blink to "roll" into Chromium, then land the
> Chromium change that uses the new enums, then land a follow-up patch in Blink
> that removes the old enums.

Done.
Patch set #3 has these changes. I've tried over local build and contents
unit-tests, seems to be working fine.

[jsbell, 2014-06-12 16:20:46]

lgtm!

I just submitted some try jobs.

dglazkov@ - can you OWNERS stamp the public API changes?

[dglazkov, 2014-06-12 16:22:29]

lgtm

[Pritam Nikam, 2014-06-12 18:07:54]

The CQ bit was checked by pritam.nikam@samsung.com

[commit-bot: I haz the power, 2014-06-12 18:08:29]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/pritam.nikam@samsung.com/325683002/40001

[commit-bot: I haz the power, 2014-06-12 18:08:51]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-06-12 18:08:53]

Failed to apply patch for Source/modules/indexeddb/IDBTransaction.cpp:
While running patch -p1 --forward --force --no-backup-if-mismatch;
  patching file Source/modules/indexeddb/IDBTransaction.cpp
  Hunk #1 succeeded at 43 with fuzz 1.
  Hunk #2 FAILED at 53.
  1 out of 5 hunks FAILED -- saving rejects to file
Source/modules/indexeddb/IDBTransaction.cpp.rej

Patch:       Source/modules/indexeddb/IDBTransaction.cpp
Index: Source/modules/indexeddb/IDBTransaction.cpp
diff --git a/Source/modules/indexeddb/IDBTransaction.cpp
b/Source/modules/indexeddb/IDBTransaction.cpp
index
3291016143dd89e3a70bba9d0c797442e69f25e0..8c28a26c8d540b1824f84ebe26231b410a329473
100644
--- a/Source/modules/indexeddb/IDBTransaction.cpp
+++ b/Source/modules/indexeddb/IDBTransaction.cpp
@@ -43,7 +43,7 @@ using blink::WebIDBDatabase;
 
 namespace WebCore {
 
-IDBTransaction* IDBTransaction::create(ExecutionContext* context, int64_t id,
const Vector<String>& objectStoreNames, WebIDBDatabase::TransactionMode mode,
IDBDatabase* db)
+IDBTransaction* IDBTransaction::create(ExecutionContext* context, int64_t id,
const Vector<String>& objectStoreNames, blink::WebIDBTransactionMode mode,
IDBDatabase* db)
 {
     IDBOpenDBRequest* openDBRequest = 0;
     IDBTransaction* transaction = adoptRefCountedGarbageCollected(new
IDBTransaction(context, id, objectStoreNames, mode, db, openDBRequest,
IDBDatabaseMetadata()));
@@ -53,7 +53,7 @@ IDBTransaction* IDBTransaction::create(ExecutionContext*
context, int64_t id, co
 
 IDBTransaction* IDBTransaction::create(ExecutionContext* context, int64_t id,
IDBDatabase* db, IDBOpenDBRequest* openDBRequest, const IDBDatabaseMetadata&
previousMetadata)
 {
-    IDBTransaction* transaction = adoptRefCountedGarbageCollected(new
IDBTransaction(context, id, Vector<String>(),
WebIDBDatabase::TransactionVersionChange, db, openDBRequest, previousMetadata));
+    IDBTransaction* transaction = adoptRefCountedGarbageCollected(new
IDBTransaction(context, id, Vector<String>(),
blink::WebIDBTransactionModeVersionChange, db, openDBRequest,
previousMetadata));
     transaction->suspendIfNeeded();
     return transaction;
 }
@@ -76,7 +76,7 @@ const AtomicString& IDBTransaction::modeVersionChange()
     return versionchange;
 }
 
-IDBTransaction::IDBTransaction(ExecutionContext* context, int64_t id, const
Vector<String>& objectStoreNames, WebIDBDatabase::TransactionMode mode,
IDBDatabase* db, IDBOpenDBRequest* openDBRequest, const IDBDatabaseMetadata&
previousMetadata)
+IDBTransaction::IDBTransaction(ExecutionContext* context, int64_t id, const
Vector<String>& objectStoreNames, blink::WebIDBTransactionMode mode,
IDBDatabase* db, IDBOpenDBRequest* openDBRequest, const IDBDatabaseMetadata&
previousMetadata)
     : ActiveDOMObject(context)
     , m_id(id)
     , m_database(db)
@@ -89,7 +89,7 @@ IDBTransaction::IDBTransaction(ExecutionContext* context,
int64_t id, const Vect
     , m_previousMetadata(previousMetadata)
 {
     ScriptWrappable::init(this);
-    if (mode == WebIDBDatabase::TransactionVersionChange) {
+    if (mode == blink::WebIDBTransactionModeVersionChange) {
         // Not active until the callback.
         m_state = Inactive;
     }
@@ -299,30 +299,30 @@ bool IDBTransaction::hasPendingActivity() const
     return m_hasPendingActivity && !m_contextStopped;
 }
 
-WebIDBDatabase::TransactionMode IDBTransaction::stringToMode(const String&
modeString, ExceptionState& exceptionState)
+blink::WebIDBTransactionMode IDBTransaction::stringToMode(const String&
modeString, ExceptionState& exceptionState)
 {
     if (modeString.isNull()
         || modeString == IDBTransaction::modeReadOnly())
-        return WebIDBDatabase::TransactionReadOnly;
+        return blink::WebIDBTransactionModeReadOnly;
     if (modeString == IDBTransaction::modeReadWrite())
-        return WebIDBDatabase::TransactionReadWrite;
+        return blink::WebIDBTransactionModeReadWrite;
 
     exceptionState.throwTypeError("The mode provided ('" + modeString + "') is
not one of 'readonly' or 'readwrite'.");
-    return WebIDBDatabase::TransactionReadOnly;
+    return blink::WebIDBTransactionModeReadOnly;
 }
 
-const AtomicString&
IDBTransaction::modeToString(WebIDBDatabase::TransactionMode mode)
+const AtomicString& IDBTransaction::modeToString(blink::WebIDBTransactionMode
mode)
 {
     switch (mode) {
-    case WebIDBDatabase::TransactionReadOnly:
+    case blink::WebIDBTransactionModeReadOnly:
         return IDBTransaction::modeReadOnly();
         break;
 
-    case WebIDBDatabase::TransactionReadWrite:
+    case blink::WebIDBTransactionModeReadWrite:
         return IDBTransaction::modeReadWrite();
         break;
 
-    case WebIDBDatabase::TransactionVersionChange:
+    case blink::WebIDBTransactionModeVersionChange:
         return IDBTransaction::modeVersionChange();
         break;
     }

[Pritam Nikam, 2014-06-12 18:18:22]

The CQ bit was checked by pritam.nikam@samsung.com

[commit-bot: I haz the power, 2014-06-12 18:19:52]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/pritam.nikam@samsung.com/325683002/40001

[jsbell, 2014-06-12 18:20:30]

Just needs a rebase due to r176011

[commit-bot: I haz the power, 2014-06-12 18:21:13]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-06-12 18:21:15]

Failed to apply patch for Source/modules/indexeddb/IDBTransaction.cpp:
While running patch -p1 --forward --force --no-backup-if-mismatch;
  patching file Source/modules/indexeddb/IDBTransaction.cpp
  Hunk #1 succeeded at 43 with fuzz 1.
  Hunk #2 FAILED at 53.
  1 out of 5 hunks FAILED -- saving rejects to file
Source/modules/indexeddb/IDBTransaction.cpp.rej

Patch:       Source/modules/indexeddb/IDBTransaction.cpp
Index: Source/modules/indexeddb/IDBTransaction.cpp
diff --git a/Source/modules/indexeddb/IDBTransaction.cpp
b/Source/modules/indexeddb/IDBTransaction.cpp
index
3291016143dd89e3a70bba9d0c797442e69f25e0..8c28a26c8d540b1824f84ebe26231b410a329473
100644
--- a/Source/modules/indexeddb/IDBTransaction.cpp
+++ b/Source/modules/indexeddb/IDBTransaction.cpp
@@ -43,7 +43,7 @@ using blink::WebIDBDatabase;
 
 namespace WebCore {
 
-IDBTransaction* IDBTransaction::create(ExecutionContext* context, int64_t id,
const Vector<String>& objectStoreNames, WebIDBDatabase::TransactionMode mode,
IDBDatabase* db)
+IDBTransaction* IDBTransaction::create(ExecutionContext* context, int64_t id,
const Vector<String>& objectStoreNames, blink::WebIDBTransactionMode mode,
IDBDatabase* db)
 {
     IDBOpenDBRequest* openDBRequest = 0;
     IDBTransaction* transaction = adoptRefCountedGarbageCollected(new
IDBTransaction(context, id, objectStoreNames, mode, db, openDBRequest,
IDBDatabaseMetadata()));
@@ -53,7 +53,7 @@ IDBTransaction* IDBTransaction::create(ExecutionContext*
context, int64_t id, co
 
 IDBTransaction* IDBTransaction::create(ExecutionContext* context, int64_t id,
IDBDatabase* db, IDBOpenDBRequest* openDBRequest, const IDBDatabaseMetadata&
previousMetadata)
 {
-    IDBTransaction* transaction = adoptRefCountedGarbageCollected(new
IDBTransaction(context, id, Vector<String>(),
WebIDBDatabase::TransactionVersionChange, db, openDBRequest, previousMetadata));
+    IDBTransaction* transaction = adoptRefCountedGarbageCollected(new
IDBTransaction(context, id, Vector<String>(),
blink::WebIDBTransactionModeVersionChange, db, openDBRequest,
previousMetadata));
     transaction->suspendIfNeeded();
     return transaction;
 }
@@ -76,7 +76,7 @@ const AtomicString& IDBTransaction::modeVersionChange()
     return versionchange;
 }
 
-IDBTransaction::IDBTransaction(ExecutionContext* context, int64_t id, const
Vector<String>& objectStoreNames, WebIDBDatabase::TransactionMode mode,
IDBDatabase* db, IDBOpenDBRequest* openDBRequest, const IDBDatabaseMetadata&
previousMetadata)
+IDBTransaction::IDBTransaction(ExecutionContext* context, int64_t id, const
Vector<String>& objectStoreNames, blink::WebIDBTransactionMode mode,
IDBDatabase* db, IDBOpenDBRequest* openDBRequest, const IDBDatabaseMetadata&
previousMetadata)
     : ActiveDOMObject(context)
     , m_id(id)
     , m_database(db)
@@ -89,7 +89,7 @@ IDBTransaction::IDBTransaction(ExecutionContext* context,
int64_t id, const Vect
     , m_previousMetadata(previousMetadata)
 {
     ScriptWrappable::init(this);
-    if (mode == WebIDBDatabase::TransactionVersionChange) {
+    if (mode == blink::WebIDBTransactionModeVersionChange) {
         // Not active until the callback.
         m_state = Inactive;
     }
@@ -299,30 +299,30 @@ bool IDBTransaction::hasPendingActivity() const
     return m_hasPendingActivity && !m_contextStopped;
 }
 
-WebIDBDatabase::TransactionMode IDBTransaction::stringToMode(const String&
modeString, ExceptionState& exceptionState)
+blink::WebIDBTransactionMode IDBTransaction::stringToMode(const String&
modeString, ExceptionState& exceptionState)
 {
     if (modeString.isNull()
         || modeString == IDBTransaction::modeReadOnly())
-        return WebIDBDatabase::TransactionReadOnly;
+        return blink::WebIDBTransactionModeReadOnly;
     if (modeString == IDBTransaction::modeReadWrite())
-        return WebIDBDatabase::TransactionReadWrite;
+        return blink::WebIDBTransactionModeReadWrite;
 
     exceptionState.throwTypeError("The mode provided ('" + modeString + "') is
not one of 'readonly' or 'readwrite'.");
-    return WebIDBDatabase::TransactionReadOnly;
+    return blink::WebIDBTransactionModeReadOnly;
 }
 
-const AtomicString&
IDBTransaction::modeToString(WebIDBDatabase::TransactionMode mode)
+const AtomicString& IDBTransaction::modeToString(blink::WebIDBTransactionMode
mode)
 {
     switch (mode) {
-    case WebIDBDatabase::TransactionReadOnly:
+    case blink::WebIDBTransactionModeReadOnly:
         return IDBTransaction::modeReadOnly();
         break;
 
-    case WebIDBDatabase::TransactionReadWrite:
+    case blink::WebIDBTransactionModeReadWrite:
         return IDBTransaction::modeReadWrite();
         break;
 
-    case WebIDBDatabase::TransactionVersionChange:
+    case blink::WebIDBTransactionModeVersionChange:
         return IDBTransaction::modeVersionChange();
         break;
     }

[Pritam Nikam, 2014-06-12 18:21:26]

The CQ bit was unchecked by pritam.nikam@samsung.com

[Pritam Nikam, 2014-06-13 04:35:32]

The CQ bit was checked by pritam.nikam@samsung.com

[commit-bot: I haz the power, 2014-06-13 04:35:59]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/pritam.nikam@samsung.com/325683002/60001

[commit-bot: I haz the power, 2014-06-13 06:12:21]

FYI, CQ is re-trying this CL (attempt #1).
The failing builders are:
  android_blink_compile_dbg on tryserver.blink
(http://build.chromium.org/p/tryserver.blink/builders/android_blink_compile_db...)
  android_blink_compile_rel on tryserver.blink
(http://build.chromium.org/p/tryserver.blink/builders/android_blink_compile_re...)
  linux_blink_dbg on tryserver.blink
(http://build.chromium.org/p/tryserver.blink/builders/linux_blink_dbg/builds/1...)
  linux_blink_rel on tryserver.blink
(http://build.chromium.org/p/tryserver.blink/builders/linux_blink_rel/builds/1...)
  mac_blink_compile_dbg on tryserver.blink
(http://build.chromium.org/p/tryserver.blink/builders/mac_blink_compile_dbg/bu...)
  mac_blink_rel on tryserver.blink
(http://build.chromium.org/p/tryserver.blink/builders/mac_blink_rel/builds/11308)
  win_blink_compile_dbg on tryserver.blink
(http://build.chromium.org/p/tryserver.blink/builders/win_blink_compile_dbg/bu...)
  win_blink_rel on tryserver.blink
(http://build.chromium.org/p/tryserver.blink/builders/win_blink_rel/builds/11863)
  linux_gpu on tryserver.chromium.gpu
(http://build.chromium.org/p/tryserver.chromium.gpu/builders/linux_gpu/builds/...)
  mac_gpu on tryserver.chromium.gpu
(http://build.chromium.org/p/tryserver.chromium.gpu/builders/mac_gpu/builds/16437)
  win_gpu on tryserver.chromium.gpu
(http://build.chromium.org/p/tryserver.chromium.gpu/builders/win_gpu/builds/19658)

[commit-bot: I haz the power, 2014-06-13 06:29:49]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-06-13 06:29:50]

Try jobs failed on following builders:
  linux_gpu on tryserver.chromium.gpu
(http://build.chromium.org/p/tryserver.chromium.gpu/builders/linux_gpu/builds/...)

[Pritam Nikam, 2014-06-13 07:21:28]

The CQ bit was checked by pritam.nikam@samsung.com

[commit-bot: I haz the power, 2014-06-13 07:22:28]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/pritam.nikam@samsung.com/325683002/80001

[commit-bot: I haz the power, 2014-06-13 08:41:28]

FYI, CQ is re-trying this CL (attempt #1).
The failing builders are:
  linux_blink_dbg on tryserver.blink
(http://build.chromium.org/p/tryserver.blink/builders/linux_blink_dbg/builds/1...)
  linux_blink_rel on tryserver.blink
(http://build.chromium.org/p/tryserver.blink/builders/linux_blink_rel/builds/1...)
  mac_blink_compile_dbg on tryserver.blink
(http://build.chromium.org/p/tryserver.blink/builders/mac_blink_compile_dbg/bu...)
  mac_blink_rel on tryserver.blink
(http://build.chromium.org/p/tryserver.blink/builders/mac_blink_rel/builds/11323)
  win_blink_rel on tryserver.blink
(http://build.chromium.org/p/tryserver.blink/builders/win_blink_rel/builds/11883)
  mac_gpu on tryserver.chromium.gpu
(http://build.chromium.org/p/tryserver.chromium.gpu/builders/mac_gpu/builds/16489)

[commit-bot: I haz the power, 2014-06-13 09:07:01]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-06-13 09:07:02]

Try jobs failed on following builders:
  mac_blink_rel on tryserver.blink
(http://build.chromium.org/p/tryserver.blink/builders/mac_blink_rel/builds/11330)

[jsbell, 2014-06-17 19:30:23]

I dunno why the bots were showing timeouts for the tests. Maybe a slight enum
mismatch?

I couldn't build with this patch locally - the compiler gripes that the argument
types are different on the Chromium side in overloads of the public/platform
classes. This built locally for me (and all tests passed):

diff --git a/public/platform/WebIDBCursor.h b/public/platform/WebIDBCursor.h
index b419e03..6bc161d 100644
--- a/public/platform/WebIDBCursor.h
+++ b/public/platform/WebIDBCursor.h
@@ -29,6 +29,7 @@
 #include "WebCommon.h"
 #include "WebIDBCallbacks.h"
 #include "WebIDBKey.h"
+#include "WebIDBTypes.h"
 #include "WebString.h"
 
 namespace blink {
@@ -39,13 +40,12 @@ public:
     virtual ~WebIDBCursor() { }
 
     // FIXME: Remove once Chromium is updated to use the new enums.
-    enum Direction {
-        Next = 0,
-        NextNoDuplicate = 1,
-        Prev = 2,
-        PrevNoDuplicate = 3,
-        DirectionLast = PrevNoDuplicate
-    };
+    typedef WebIDBCursorDirection Direction;
+    static const WebIDBCursorDirection Next = WebIDBCursorDirectionNext;
+    static const WebIDBCursorDirection NextNoDuplicate =
WebIDBCursorDirectionNextNoDuplicate;
+    static const WebIDBCursorDirection Prev = WebIDBCursorDirectionPrev;
+    static const WebIDBCursorDirection PrevNoDuplicate =
WebIDBCursorDirectionPrevNoDuplicate;
+    static const WebIDBCursorDirection DirectionLast =
WebIDBCursorDirectionLast;
 
     virtual void advance(unsigned long, WebIDBCallbacks*) {
BLINK_ASSERT_NOT_REACHED(); }
     virtual void continueFunction(const WebIDBKey&, const WebIDBKey&
primaryKey, WebIDBCallbacks*) { BLINK_ASSERT_NOT_REACHED(); }
diff --git a/public/platform/WebIDBDatabase.h b/public/platform/WebIDBDatabase.h
index b9cc178..61f3ae1 100644
--- a/public/platform/WebIDBDatabase.h
+++ b/public/platform/WebIDBDatabase.h
@@ -48,11 +48,10 @@ public:
     virtual ~WebIDBDatabase() { }
 
     // FIXME: Remove once Chromium is updated to use the new enums.
-    enum TransactionMode {
-        TransactionReadOnly = 0,
-        TransactionReadWrite,
-        TransactionVersionChange,
-    };
+    typedef WebIDBTransactionMode TransactionMode;
+    static const WebIDBTransactionMode TransactionReadOnly =
WebIDBTransactionModeReadOnly;
+    static const WebIDBTransactionMode TransactionReadWrite =
WebIDBTransactionModeReadWrite;
+    static const WebIDBTransactionMode TransactionVersionChange =
WebIDBTransactionModeVersionChange;
 
     virtual void createObjectStore(long long transactionId, long long
objectStoreId, const WebString& name, const WebIDBKeyPath&, bool autoIncrement)
{ BLINK_ASSERT_NOT_REACHED(); }
     virtual void deleteObjectStore(long long transactionId, long long
objectStoreId) { BLINK_ASSERT_NOT_REACHED(); }
@@ -67,19 +66,17 @@ public:
     virtual void deleteIndex(long long transactionId, long long objectStoreId,
long long indexId) { BLINK_ASSERT_NOT_REACHED(); }
 
     // FIXME: Remove once Chromium is updated to use the new enums.
-    enum TaskType {
-        NormalTask = 0,
-        PreemptiveTask,
-        TaskTypeLast = PreemptiveTask
-    };
+    typedef WebIDBTaskType TaskType;
+    static const WebIDBTaskType NormalTask = WebIDBTaskTypeNormal;
+    static const WebIDBTaskType PreemptiveTask = WebIDBTaskTypePreemptive;
+    static const WebIDBTaskType TaskTypeLast = WebIDBTaskTypeLast;
 
     // FIXME: Remove once Chromium is updated to use the new enums.
-    enum PutMode {
-        AddOrUpdate,
-        AddOnly,
-        CursorUpdate,
-        PutModeLast = CursorUpdate
-    };
+    typedef WebIDBPutMode PutMode;
+    static const WebIDBPutMode AddOrUpdate = WebIDBPutModeAddOrUpdate;
+    static const WebIDBPutMode AddOnly = WebIDBPutModeAddOnly;
+    static const WebIDBPutMode CursorUpdate = WebIDBPutModeCursorUpdate;
+    static const WebIDBPutMode PutModeLast = WebIDBPutModeLast;
 
     static const long long minimumIndexId = 30;

[Pritam Nikam, 2014-06-18 12:15:43]

The CQ bit was checked by pritam.nikam@samsung.com

[commit-bot: I haz the power, 2014-06-18 12:16:11]

CQ is trying da patch. Follow status at

https://chromium-status.appspot.com/cq/pritam.nikam@samsung.com/325683002/100001

[Pritam Nikam, 2014-06-18 12:29:54]

Thanks jsbell!

All cases failing due to this mismatch.Patch you have suggested will solve this
problem. I've incorporated these modifications in patch #5. Please have a look.

[commit-bot: I haz the power, 2014-06-18 14:00:15]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-06-18 14:00:16]

Try jobs failed on following builders:
  mac_blink_rel on tryserver.blink
(http://build.chromium.org/p/tryserver.blink/builders/mac_blink_rel/builds/11859)

[Pritam Nikam, 2014-06-18 14:02:37]

Hi jsbell!

Are these failures related to IndexedDB changes made with this patch?

MAC Rel:
failures:
screen_orientation/orientationchange-event.html
screen_orientation/page-visibility.html


Win Rel:
+http/tests/navigation/error404-subframeload.html
+http/tests/navigation/anchor-subframeload.html

[jsbell, 2014-06-18 16:21:13]

On 2014/06/18 14:02:37, Pritam Nikam wrote:
> Hi jsbell!
> 
> Are these failures related to IndexedDB changes made with this patch?
> 
> MAC Rel:
> failures:
> screen_orientation/orientationchange-event.html
> screen_orientation/page-visibility.html
> 
> 
> Win Rel:
> +http/tests/navigation/error404-subframeload.html
> +http/tests/navigation/anchor-subframeload.html

Yeah, failures are unrelated. I'll manually land this for you.

[Pritam Nikam, 2014-06-18 16:54:58]

On 2014/06/18 16:21:13, jsbell wrote:
> On 2014/06/18 14:02:37, Pritam Nikam wrote:
> > Hi jsbell!
> > 
> > Are these failures related to IndexedDB changes made with this patch?
> > 
> > MAC Rel:
> > failures:
> > screen_orientation/orientationchange-event.html
> > screen_orientation/page-visibility.html
> > 
> > 
> > Win Rel:
> > +http/tests/navigation/error404-subframeload.html
> > +http/tests/navigation/anchor-subframeload.html
> 
> Yeah, failures are unrelated. I'll manually land this for you.

Thanks!

[jsbell, 2014-06-18 17:12:31]

Committed patchset #5 manually as r176435 (presubmit successful).

[Pritam Nikam, 2014-06-19 05:36:33]

On 2014/06/18 17:12:31, jsbell wrote:
> Committed patchset #5 manually as r176435 (presubmit successful).

Thanks jsbell! 
I'll wait till it rolled out and then submit one in chromium side.