Source/modules/indexeddb/IDBTransactionTest.cpp - Issue 325683002: [IndexedDB] Use consistent enums on both sides of IPC.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/modules/indexeddb/IDBTransactionTest.cpp

Issue 325683002: [IndexedDB] Use consistent enums on both sides of IPC. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Incorporated review comments as build bot was failing with previous patch. Created 6 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: Source/modules/indexeddb/IDBTransactionTest.cpp

diff --git a/Source/modules/indexeddb/IDBTransactionTest.cpp b/Source/modules/indexeddb/IDBTransactionTest.cpp

index 6252c27749f50a0f635ed8a9a8e6e7d77884008b..bb992f51e09460666b9e747bae1ab82964293e19 100644

--- a/Source/modules/indexeddb/IDBTransactionTest.cpp

+++ b/Source/modules/indexeddb/IDBTransactionTest.cpp

@@ -100,7 +100,7 @@ TEST_F(IDBTransactionTest, EnsureLifetime)

const int64_t transactionId = 1234;

const Vector<String> transactionScope;

- Persistent<IDBTransaction> transaction = IDBTransaction::create(executionContext(), transactionId, transactionScope, blink::WebIDBDatabase::TransactionReadOnly, db.get());

+ Persistent<IDBTransaction> transaction = IDBTransaction::create(executionContext(), transactionId, transactionScope, blink::WebIDBTransactionModeReadOnly, db.get());

PersistentHeapHashSet<WeakMember<IDBTransaction> > set;

set.add(transaction);

@@ -130,7 +130,7 @@ TEST_F(IDBTransactionTest, TransactionFinish)