Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(112)

Side by Side Diff: Source/modules/indexeddb/IDBCursorWithValue.h

Issue 325683002: [IndexedDB] Use consistent enums on both sides of IPC. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Incorporated review comments as build bot was failing with previous patch. Created 6 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « Source/modules/indexeddb/IDBCursor.cpp ('k') | Source/modules/indexeddb/IDBCursorWithValue.cpp » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2011 Google Inc. All rights reserved. 2 * Copyright (C) 2011 Google Inc. All rights reserved.
3 * 3 *
4 * Redistribution and use in source and binary forms, with or without 4 * Redistribution and use in source and binary forms, with or without
5 * modification, are permitted provided that the following conditions 5 * modification, are permitted provided that the following conditions
6 * are met: 6 * are met:
7 * 7 *
8 * 1. Redistributions of source code must retain the above copyright 8 * 1. Redistributions of source code must retain the above copyright
9 * notice, this list of conditions and the following disclaimer. 9 * notice, this list of conditions and the following disclaimer.
10 * 2. Redistributions in binary form must reproduce the above copyright 10 * 2. Redistributions in binary form must reproduce the above copyright
(...skipping 11 matching lines...) Expand all
22 * (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE OF 22 * (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE OF
23 * THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE. 23 * THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
24 */ 24 */
25 25
26 #ifndef IDBCursorWithValue_h 26 #ifndef IDBCursorWithValue_h
27 #define IDBCursorWithValue_h 27 #define IDBCursorWithValue_h
28 28
29 #include "modules/indexeddb/IDBCursor.h" 29 #include "modules/indexeddb/IDBCursor.h"
30 #include "modules/indexeddb/IndexedDB.h" 30 #include "modules/indexeddb/IndexedDB.h"
31 #include "public/platform/WebIDBCursor.h" 31 #include "public/platform/WebIDBCursor.h"
32 #include "public/platform/WebIDBTypes.h"
32 #include "wtf/PassOwnPtr.h" 33 #include "wtf/PassOwnPtr.h"
33 34
34 namespace WebCore { 35 namespace WebCore {
35 36
36 class IDBAny; 37 class IDBAny;
37 class IDBRequest; 38 class IDBRequest;
38 class IDBTransaction; 39 class IDBTransaction;
39 40
40 class IDBCursorWithValue FINAL : public IDBCursor { 41 class IDBCursorWithValue FINAL : public IDBCursor {
41 public: 42 public:
42 static IDBCursorWithValue* create(PassOwnPtr<blink::WebIDBCursor>, blink::We bIDBCursor::Direction, IDBRequest*, IDBAny* source, IDBTransaction*); 43 static IDBCursorWithValue* create(PassOwnPtr<blink::WebIDBCursor>, blink::We bIDBCursorDirection, IDBRequest*, IDBAny* source, IDBTransaction*);
43 virtual ~IDBCursorWithValue(); 44 virtual ~IDBCursorWithValue();
44 45
45 // The value attribute defined in the IDL is simply implemented in IDBCursor (but not exposed via 46 // The value attribute defined in the IDL is simply implemented in IDBCursor (but not exposed via
46 // its IDL). This is to make the implementation more simple while matching w hat the spec says. 47 // its IDL). This is to make the implementation more simple while matching w hat the spec says.
47 48
48 virtual bool isKeyCursor() const OVERRIDE { return false; } 49 virtual bool isKeyCursor() const OVERRIDE { return false; }
49 virtual bool isCursorWithValue() const OVERRIDE { return true; } 50 virtual bool isCursorWithValue() const OVERRIDE { return true; }
50 51
51 private: 52 private:
52 IDBCursorWithValue(PassOwnPtr<blink::WebIDBCursor>, blink::WebIDBCursor::Dir ection, IDBRequest*, IDBAny* source, IDBTransaction*); 53 IDBCursorWithValue(PassOwnPtr<blink::WebIDBCursor>, blink::WebIDBCursorDirec tion, IDBRequest*, IDBAny* source, IDBTransaction*);
53 }; 54 };
54 55
55 DEFINE_TYPE_CASTS(IDBCursorWithValue, IDBCursor, cursor, cursor->isCursorWithVal ue(), cursor.isCursorWithValue()); 56 DEFINE_TYPE_CASTS(IDBCursorWithValue, IDBCursor, cursor, cursor->isCursorWithVal ue(), cursor.isCursorWithValue());
56 57
57 } // namespace WebCore 58 } // namespace WebCore
58 59
59 #endif // IDBCursorWithValue_h 60 #endif // IDBCursorWithValue_h
OLDNEW
« no previous file with comments | « Source/modules/indexeddb/IDBCursor.cpp ('k') | Source/modules/indexeddb/IDBCursorWithValue.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698