Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(215)

Side by Side Diff: public/platform/WebIDBCursor.h

Issue 325683002: [IndexedDB] Use consistent enums on both sides of IPC. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Incorporated review comments as build bot was failing with previous patch. Created 6 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « Source/modules/indexeddb/InspectorIndexedDBAgent.cpp ('k') | public/platform/WebIDBDatabase.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2010 Google Inc. All rights reserved. 2 * Copyright (C) 2010 Google Inc. All rights reserved.
3 * 3 *
4 * Redistribution and use in source and binary forms, with or without 4 * Redistribution and use in source and binary forms, with or without
5 * modification, are permitted provided that the following conditions 5 * modification, are permitted provided that the following conditions
6 * are met: 6 * are met:
7 * 7 *
8 * 1. Redistributions of source code must retain the above copyright 8 * 1. Redistributions of source code must retain the above copyright
9 * notice, this list of conditions and the following disclaimer. 9 * notice, this list of conditions and the following disclaimer.
10 * 2. Redistributions in binary form must reproduce the above copyright 10 * 2. Redistributions in binary form must reproduce the above copyright
(...skipping 11 matching lines...) Expand all
22 * (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE OF 22 * (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE OF
23 * THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE. 23 * THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
24 */ 24 */
25 25
26 #ifndef WebIDBCursor_h 26 #ifndef WebIDBCursor_h
27 #define WebIDBCursor_h 27 #define WebIDBCursor_h
28 28
29 #include "WebCommon.h" 29 #include "WebCommon.h"
30 #include "WebIDBCallbacks.h" 30 #include "WebIDBCallbacks.h"
31 #include "WebIDBKey.h" 31 #include "WebIDBKey.h"
32 #include "WebIDBTypes.h"
32 #include "WebString.h" 33 #include "WebString.h"
33 34
34 namespace blink { 35 namespace blink {
35 36
36 // See comment in WebIDBFactory for a high level overview these classes. 37 // See comment in WebIDBFactory for a high level overview these classes.
37 class WebIDBCursor { 38 class WebIDBCursor {
38 public: 39 public:
39 virtual ~WebIDBCursor() { } 40 virtual ~WebIDBCursor() { }
40 41
41 enum Direction { 42 // FIXME: Remove once Chromium is updated to use the new enums.
42 Next = 0, 43 typedef WebIDBCursorDirection Direction;
43 NextNoDuplicate = 1, 44 static const WebIDBCursorDirection Next = WebIDBCursorDirectionNext;
44 Prev = 2, 45 static const WebIDBCursorDirection NextNoDuplicate =WebIDBCursorDirectionNex tNoDuplicate;
45 PrevNoDuplicate = 3, 46 static const WebIDBCursorDirection Prev = WebIDBCursorDirectionPrev;
46 DirectionLast = PrevNoDuplicate 47 static const WebIDBCursorDirection PrevNoDuplicate =WebIDBCursorDirectionPre vNoDuplicate;
47 }; 48 static const WebIDBCursorDirection DirectionLast =WebIDBCursorDirectionLast;
48 49
49 virtual void advance(unsigned long, WebIDBCallbacks*) { BLINK_ASSERT_NOT_REA CHED(); } 50 virtual void advance(unsigned long, WebIDBCallbacks*) { BLINK_ASSERT_NOT_REA CHED(); }
50 virtual void continueFunction(const WebIDBKey&, const WebIDBKey& primaryKey, WebIDBCallbacks*) { BLINK_ASSERT_NOT_REACHED(); } 51 virtual void continueFunction(const WebIDBKey&, const WebIDBKey& primaryKey, WebIDBCallbacks*) { BLINK_ASSERT_NOT_REACHED(); }
51 virtual void postSuccessHandlerCallback() { } // Only used in frontend. 52 virtual void postSuccessHandlerCallback() { } // Only used in frontend.
52 53
53 protected: 54 protected:
54 WebIDBCursor() { } 55 WebIDBCursor() { }
55 }; 56 };
56 57
57 } // namespace blink 58 } // namespace blink
58 59
59 #endif // WebIDBCursor_h 60 #endif // WebIDBCursor_h
OLDNEW
« no previous file with comments | « Source/modules/indexeddb/InspectorIndexedDBAgent.cpp ('k') | public/platform/WebIDBDatabase.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698