Source/modules/indexeddb/IDBDatabase.cpp - Issue 325683002: [IndexedDB] Use consistent enums on both sides of IPC.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/modules/indexeddb/IDBDatabase.cpp

Issue 325683002: [IndexedDB] Use consistent enums on both sides of IPC. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Incorporated review comments as build bot was failing with previous patch. Created 6 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: Source/modules/indexeddb/IDBDatabase.cpp

diff --git a/Source/modules/indexeddb/IDBDatabase.cpp b/Source/modules/indexeddb/IDBDatabase.cpp

index f79dba6d62f1912a48c2f79b024f60cb4bef2900..5d72e759300cb634ceea5c3249a555ba413ea286 100644

--- a/Source/modules/indexeddb/IDBDatabase.cpp

+++ b/Source/modules/indexeddb/IDBDatabase.cpp

@@ -44,6 +44,7 @@

#include "modules/indexeddb/WebIDBDatabaseCallbacksImpl.h"

#include "public/platform/Platform.h"

#include "public/platform/WebIDBKeyPath.h"

+#include "public/platform/WebIDBTypes.h"

#include "wtf/Atomics.h"

#include <limits>

@@ -304,7 +305,7 @@ IDBTransaction* IDBDatabase::transaction(ExecutionContext* context, const Vector

return 0;

}

- blink::WebIDBDatabase::TransactionMode mode = IDBTransaction::stringToMode(modeString, exceptionState);

+ blink::WebIDBTransactionMode mode = IDBTransaction::stringToMode(modeString, exceptionState);

if (exceptionState.hadException())

return 0;

« no previous file with comments | « Source/modules/indexeddb/IDBCursorWithValue.cpp ('k') | Source/modules/indexeddb/IDBIndex.h » ('j') | no next file with comments »