sync: only use RecordUnrecoverableError for legacy types.

sync: only use RecordUnrecoverableError for legacy types.

Invoke the error_callback directly from OnSingleDatatypeUnrecoverableError.  We'll still double-upload certain stacks, see referenced bug.

BUG=383480
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=276843

[tim (not reviewing), 2014-06-05 00:46:36]

A swing at fixing the double-upload problem. Basically, "do what the comments
say" in DataTypeErrorHandler; CreateAndUpload builds a SyncError and sends to
crash/, while OnSingleDataTypeUnrecoverableError is for disabling a datatype.

I could have made the legacy DTC code cleaner, but not without a bit of extra
work, and I really want to avoid sinking time on that code vs the current API
(especially for componentization purposes since we're leaving the legacy stuff
behind).

[tim (not reviewing), 2014-06-05 21:34:08]

On 2014/06/05 00:46:36, timsteele wrote:
> A swing at fixing the double-upload problem. Basically, "do what the comments
> say" in DataTypeErrorHandler; CreateAndUpload builds a SyncError and sends to
> crash/, while OnSingleDataTypeUnrecoverableError is for disabling a datatype.
> 
> I could have made the legacy DTC code cleaner, but not without a bit of extra
> work, and I really want to avoid sinking time on that code vs the current API
> (especially for componentization purposes since we're leaving the legacy stuff
> behind).

Ah, try will fail as this relies on https://codereview.chromium.org/317453002/

[Nicolas Zea, 2014-06-05 21:37:44]

lgtm

[tim (not reviewing), 2014-06-11 21:43:12]

I've re-worked this patch to not go as far as originally hoped.  The bug
explains why my original approach isn't easily doable right now.

Even though it creates more churn (in terms of constructor parameters for DTCs),
my plan is to first replace the DisableBrokenDatatype call with a callback
similar to what blundell did in revision 248274, to unblock componentization. 
From there we can figure out what to do with the bug and work towards merging
the two callbacks into one.

[Nicolas Zea, 2014-06-11 22:08:17]

lgtm

[tim (not reviewing), 2014-06-11 22:36:44]

The CQ bit was checked by tim@chromium.org

[commit-bot: I haz the power, 2014-06-11 22:37:19]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/tim@chromium.org/319553004/80001

[commit-bot: I haz the power, 2014-06-11 23:58:07]

FYI, CQ is re-trying this CL (attempt #1).
The failing builders are:
  ios_dbg_simulator on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/ios_dbg_simulator/bui...)
  ios_rel_device on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/ios_rel_device/builds...)
  ios_rel_device_ninja on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/ios_rel_device_ninja/...)
  mac_chromium_compile_dbg on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/mac_chromium_compile_...)
  mac_chromium_rel on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/mac_chromium_rel/buil...)
  win_chromium_compile_dbg on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/win_chromium_compile_...)
  win_chromium_rel on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/win_chromium_rel/buil...)
  win_chromium_x64_rel on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/win_chromium_x64_rel/...)
  mac_gpu on tryserver.chromium.gpu
(http://build.chromium.org/p/tryserver.chromium.gpu/builders/mac_gpu/builds/15730)
  win_gpu on tryserver.chromium.gpu
(http://build.chromium.org/p/tryserver.chromium.gpu/builders/win_gpu/builds/18862)

[commit-bot: I haz the power, 2014-06-12 00:10:29]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-06-12 00:10:30]

Try jobs failed on following builders:
  ios_rel_device on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/ios_rel_device/builds...)
  win_chromium_rel on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/win_chromium_rel/buil...)

[tim (not reviewing), 2014-06-12 18:22:56]

The CQ bit was checked by tim@chromium.org

[commit-bot: I haz the power, 2014-06-12 18:24:26]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/tim@chromium.org/319553004/80001

[commit-bot: I haz the power, 2014-06-12 23:08:46]

Change committed as 276843