Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2602)

Unified Diff: chrome/browser/sync/glue/ui_data_type_controller.cc

Issue 319553004: sync: only use RecordUnrecoverableError for legacy types. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: style fix Created 6 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/sync/glue/ui_data_type_controller.cc
diff --git a/chrome/browser/sync/glue/ui_data_type_controller.cc b/chrome/browser/sync/glue/ui_data_type_controller.cc
index d07bee45321d44762db66c935e07364c94917c45..611613707643890ff2b5a61facafe4ab3e64bfca 100644
--- a/chrome/browser/sync/glue/ui_data_type_controller.cc
+++ b/chrome/browser/sync/glue/ui_data_type_controller.cc
@@ -247,9 +247,6 @@ void UIDataTypeController::StartDone(
DCHECK(BrowserThread::CurrentlyOn(BrowserThread::UI));
if (!IsSuccessfulResult(start_result)) {
- if (IsUnrecoverableResult(start_result))
- RecordUnrecoverableError(FROM_HERE, "StartFailed");
-
StopModels();
if (start_result == ASSOCIATION_FAILED) {
state_ = DISABLED;
@@ -328,7 +325,12 @@ DataTypeController::State UIDataTypeController::state() const {
void UIDataTypeController::OnSingleDatatypeUnrecoverableError(
const tracked_objects::Location& from_here, const std::string& message) {
- RecordUnrecoverableError(from_here, message);
+ UMA_HISTOGRAM_ENUMERATION("Sync.DataTypeRunFailures",
+ ModelTypeToHistogramInt(type()),
+ syncer::MODEL_TYPE_COUNT);
+ // TODO(tim): We double-upload some errors. See bug 383480.
+ if (!error_callback_.is_null())
+ error_callback_.Run();
sync_service_->DisableBrokenDatatype(type(), from_here, message);
}
« no previous file with comments | « chrome/browser/sync/glue/non_ui_data_type_controller_unittest.cc ('k') | components/sync_driver/data_type_controller.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698