Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(80)

Unified Diff: chrome/browser/sync/glue/frontend_data_type_controller.cc

Issue 319553004: sync: only use RecordUnrecoverableError for legacy types. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: style fix Created 6 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/sync/glue/frontend_data_type_controller.cc
diff --git a/chrome/browser/sync/glue/frontend_data_type_controller.cc b/chrome/browser/sync/glue/frontend_data_type_controller.cc
index b7f31ac6476b1f4a825082f9f4eba1368a470cff..89ae6ad0f581e63ca921edefc11d325a848a0b72 100644
--- a/chrome/browser/sync/glue/frontend_data_type_controller.cc
+++ b/chrome/browser/sync/glue/frontend_data_type_controller.cc
@@ -165,6 +165,21 @@ bool FrontendDataTypeController::StartModels() {
return true;
}
+void FrontendDataTypeController::RecordUnrecoverableError(
+ const tracked_objects::Location& from_here,
+ const std::string& message) {
+ DVLOG(1) << "Datatype Controller failed for type "
+ << ModelTypeToString(type()) << " "
+ << message << " at location "
+ << from_here.ToString();
+ UMA_HISTOGRAM_ENUMERATION("Sync.DataTypeRunFailures",
+ ModelTypeToHistogramInt(type()),
+ syncer::MODEL_TYPE_COUNT);
+
+ if (!error_callback_.is_null())
+ error_callback_.Run();
+}
+
bool FrontendDataTypeController::Associate() {
DCHECK_EQ(state_, ASSOCIATING);
syncer::SyncMergeResult local_merge_result(type());
« no previous file with comments | « chrome/browser/sync/glue/frontend_data_type_controller.h ('k') | chrome/browser/sync/glue/non_frontend_data_type_controller.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698