Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(11)

Unified Diff: components/sync_driver/data_type_controller.h

Issue 319553004: sync: only use RecordUnrecoverableError for legacy types. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: style fix Created 6 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/sync/glue/ui_data_type_controller.cc ('k') | components/sync_driver/data_type_controller.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: components/sync_driver/data_type_controller.h
diff --git a/components/sync_driver/data_type_controller.h b/components/sync_driver/data_type_controller.h
index 37fefc6bb330cf4f617b67919119871d593067c5..84faf9aaa49cae270a4f8c808d87655e4a9ed0ef 100644
--- a/components/sync_driver/data_type_controller.h
+++ b/components/sync_driver/data_type_controller.h
@@ -147,20 +147,14 @@ class DataTypeController
virtual ~DataTypeController();
- // Handles the reporting of unrecoverable error. It records stuff in
- // UMA and reports to breakpad.
- // Virtual for testing purpose.
- virtual void RecordUnrecoverableError(
- const tracked_objects::Location& from_here,
- const std::string& message);
-
syncer::UserShare* user_share() const;
- private:
- syncer::UserShare* user_share_;
-
// The callback that will be invoked when an unrecoverable error occurs.
+ // TODO(sync): protected for use by legacy controllers.
base::Closure error_callback_;
+
+ private:
+ syncer::UserShare* user_share_;
};
} // namespace browser_sync
« no previous file with comments | « chrome/browser/sync/glue/ui_data_type_controller.cc ('k') | components/sync_driver/data_type_controller.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698