Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(696)

Unified Diff: components/sync_driver/data_type_controller.cc

Issue 319553004: sync: only use RecordUnrecoverableError for legacy types. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: style fix Created 6 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « components/sync_driver/data_type_controller.h ('k') | components/sync_driver/fake_data_type_controller.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: components/sync_driver/data_type_controller.cc
diff --git a/components/sync_driver/data_type_controller.cc b/components/sync_driver/data_type_controller.cc
index 24f463cd30a4532a4225145f8948a682cdc5ac29..d55639ccf532dbd610354ec1447d3015288d7382 100644
--- a/components/sync_driver/data_type_controller.cc
+++ b/components/sync_driver/data_type_controller.cc
@@ -14,7 +14,7 @@ DataTypeController::DataTypeController(
scoped_refptr<base::MessageLoopProxy> ui_thread,
const base::Closure& error_callback)
: base::RefCountedDeleteOnMessageLoop<DataTypeController>(ui_thread),
- user_share_(NULL), error_callback_(error_callback) {
+ error_callback_(error_callback), user_share_(NULL) {
}
DataTypeController::~DataTypeController() {
@@ -48,21 +48,4 @@ syncer::UserShare* DataTypeController::user_share() const {
return user_share_;
}
-void DataTypeController::RecordUnrecoverableError(
- const tracked_objects::Location& from_here,
- const std::string& message) {
- DVLOG(1) << "Datatype Controller failed for type "
- << ModelTypeToString(type()) << " "
- << message << " at location "
- << from_here.ToString();
- UMA_HISTOGRAM_ENUMERATION("Sync.DataTypeRunFailures",
- ModelTypeToHistogramInt(type()),
- syncer::MODEL_TYPE_COUNT);
-
- // TODO(sync): remove this once search engines triggers less errors, such as
- // due to crbug.com/130448.
- if ((type() != syncer::SEARCH_ENGINES) && (!error_callback_.is_null()))
- error_callback_.Run();
-}
-
} // namespace browser_sync
« no previous file with comments | « components/sync_driver/data_type_controller.h ('k') | components/sync_driver/fake_data_type_controller.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698