Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2712)

Unified Diff: chrome/browser/sync/glue/non_ui_data_type_controller_unittest.cc

Issue 319553004: sync: only use RecordUnrecoverableError for legacy types. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: style fix Created 6 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/sync/glue/non_ui_data_type_controller_unittest.cc
diff --git a/chrome/browser/sync/glue/non_ui_data_type_controller_unittest.cc b/chrome/browser/sync/glue/non_ui_data_type_controller_unittest.cc
index e819fb6f10914d1a76f57200df6034cc46fe990a..c9b66308b0136a62fc324ba7360a4a86bb6ebdf6 100644
--- a/chrome/browser/sync/glue/non_ui_data_type_controller_unittest.cc
+++ b/chrome/browser/sync/glue/non_ui_data_type_controller_unittest.cc
@@ -156,11 +156,6 @@ class NonUIDataTypeControllerFake
virtual void StopModels() OVERRIDE {
mock_->StopModels();
}
- virtual void RecordUnrecoverableError(
- const tracked_objects::Location& from_here,
- const std::string& message) OVERRIDE {
- mock_->RecordUnrecoverableError(from_here, message);
- }
virtual void RecordAssociationTime(base::TimeDelta time) OVERRIDE {
mock_->RecordAssociationTime(time);
}
@@ -258,8 +253,6 @@ class SyncNonUIDataTypeControllerTest : public testing::Test {
void SetStartFailExpectations(DataTypeController::StartResult result) {
EXPECT_CALL(*dtc_mock_.get(), StopModels()).Times(AtLeast(1));
- if (DataTypeController::IsUnrecoverableResult(result))
- EXPECT_CALL(*dtc_mock_.get(), RecordUnrecoverableError(_, _));
EXPECT_CALL(*dtc_mock_.get(), RecordStartFailure(result));
EXPECT_CALL(start_callback_, Run(result, _, _));
}
@@ -506,7 +499,6 @@ TEST_F(SyncNonUIDataTypeControllerTest,
SetStartExpectations();
SetAssociateExpectations();
SetActivateExpectations(DataTypeController::OK);
- EXPECT_CALL(*dtc_mock_.get(), RecordUnrecoverableError(_, "Test"));
EXPECT_CALL(service_, DisableBrokenDatatype(_, _, _)).WillOnce(
InvokeWithoutArgs(non_ui_dtc_.get(), &NonUIDataTypeController::Stop));
SetStopExpectations();
« no previous file with comments | « chrome/browser/sync/glue/non_ui_data_type_controller_mock.h ('k') | chrome/browser/sync/glue/ui_data_type_controller.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698