Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(57)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 318803002: Rename Repaint to Paint Invalidation part 3 (Closed)

Created:
6 years, 6 months ago by dsinclair
Modified:
6 years, 6 months ago
CC:
blink-reviews, eae+blinkwatch, fs, eric.carlson_apple.com, kouhei+svg_chromium.org, rune+blink, krit, chromiumbugtracker_adobe.com, blink-reviews-html_chromium.org, blink-reviews-dom_chromium.org, dglazkov+blink, jchaffraix+rendering, pdr., rwlbuis, nessy, zoltan1, sof, feature-media-reviews_chromium.org, gyuyoung.kim_webkit.org, vcarbune.chromium, philipj_slow, blink-reviews-rendering, gasubic, leviw+renderwatch, blink-layers+watch_chromium.org, ed+blinkwatch_opera.com, f(malita), Stephen Chennney
Visibility:
Public.

Description

Rename Repaint to Paint Invalidation part 3 This CL starts the renaming of RenderObject methods from repaint to paint invalidation. In this CL I've converted the following: repaint repaintRectangle repaintUsingContainer repaintAfterLayoutIfNeeded repaintOverflow repaintOverflowIfNeed BUG=338691 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=175969

Patch Set 1 #

Patch Set 2 : Rebase to master #

Total comments: 4

Patch Set 3 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+172 lines, -170 lines) Patch
M Source/core/dom/DocumentMarkerController.cpp View 1 2 7 chunks +7 lines, -7 lines 0 comments Download
M Source/core/editing/Caret.cpp View 1 1 chunk +1 line, -1 line 0 comments Download
M Source/core/editing/InputMethodController.cpp View 1 2 2 chunks +2 lines, -2 lines 0 comments Download
M Source/core/frame/FrameView.cpp View 1 2 4 chunks +4 lines, -4 lines 0 comments Download
M Source/core/frame/RemoteFrameView.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/html/HTMLCanvasElement.cpp View 1 2 2 chunks +2 lines, -2 lines 0 comments Download
M Source/core/html/HTMLFormControlElement.cpp View 1 2 1 chunk +1 line, -1 line 0 comments Download
M Source/core/html/HTMLMediaElement.cpp View 1 2 1 chunk +1 line, -1 line 0 comments Download
M Source/core/html/HTMLOptionElement.cpp View 1 2 1 chunk +1 line, -1 line 0 comments Download
M Source/core/html/forms/FileInputType.cpp View 1 2 1 chunk +1 line, -1 line 0 comments Download
M Source/core/html/shadow/MediaControlElementTypes.cpp View 1 2 1 chunk +1 line, -1 line 0 comments Download
M Source/core/html/shadow/MediaControls.cpp View 1 2 1 chunk +1 line, -1 line 0 comments Download
M Source/core/html/shadow/SliderThumbElement.cpp View 1 2 1 chunk +1 line, -1 line 0 comments Download
M Source/core/html/shadow/SpinButtonElement.cpp View 1 2 1 chunk +1 line, -1 line 0 comments Download
M Source/core/rendering/ImageQualityController.cpp View 1 2 1 chunk +1 line, -1 line 0 comments Download
M Source/core/rendering/LayoutRepainter.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/rendering/RenderBlock.cpp View 1 2 1 chunk +1 line, -1 line 0 comments Download
M Source/core/rendering/RenderBlockFlow.h View 1 2 1 chunk +1 line, -1 line 0 comments Download
M Source/core/rendering/RenderBlockFlow.cpp View 1 2 4 chunks +6 lines, -6 lines 0 comments Download
M Source/core/rendering/RenderBlockLineLayout.cpp View 1 2 1 chunk +1 line, -1 line 0 comments Download
M Source/core/rendering/RenderBox.cpp View 1 2 8 chunks +15 lines, -14 lines 0 comments Download
M Source/core/rendering/RenderFileUploadControl.cpp View 1 2 1 chunk +1 line, -1 line 0 comments Download
M Source/core/rendering/RenderFrameSet.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/core/rendering/RenderImage.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M Source/core/rendering/RenderImageResource.cpp View 1 2 1 chunk +1 line, -1 line 0 comments Download
M Source/core/rendering/RenderInline.cpp View 1 2 1 chunk +1 line, -1 line 0 comments Download
M Source/core/rendering/RenderLayer.cpp View 1 2 2 chunks +2 lines, -2 lines 0 comments Download
M Source/core/rendering/RenderLayerFilterInfo.cpp View 1 2 1 chunk +1 line, -1 line 0 comments Download
M Source/core/rendering/RenderLayerModelObject.cpp View 1 2 1 chunk +1 line, -1 line 0 comments Download
M Source/core/rendering/RenderLayerRepainter.cpp View 1 2 chunks +4 lines, -4 lines 0 comments Download
M Source/core/rendering/RenderLayerScrollableArea.cpp View 1 2 4 chunks +6 lines, -6 lines 0 comments Download
M Source/core/rendering/RenderListBox.cpp View 1 2 4 chunks +4 lines, -4 lines 0 comments Download
M Source/core/rendering/RenderListMarker.cpp View 1 2 1 chunk +1 line, -1 line 0 comments Download
M Source/core/rendering/RenderMeter.cpp View 1 2 1 chunk +1 line, -1 line 0 comments Download
M Source/core/rendering/RenderObject.h View 1 2 1 chunk +13 lines, -12 lines 0 comments Download
M Source/core/rendering/RenderObject.cpp View 1 2 12 chunks +55 lines, -55 lines 0 comments Download
M Source/core/rendering/RenderObjectChildList.cpp View 1 2 1 chunk +2 lines, -2 lines 0 comments Download
M Source/core/rendering/RenderProgress.cpp View 1 2 2 chunks +2 lines, -2 lines 0 comments Download
M Source/core/rendering/RenderRegion.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/rendering/RenderSelectionInfo.h View 2 chunks +2 lines, -2 lines 0 comments Download
M Source/core/rendering/RenderTable.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/core/rendering/RenderTableCell.cpp View 1 2 1 chunk +1 line, -1 line 0 comments Download
M Source/core/rendering/RenderTableCol.cpp View 1 2 1 chunk +1 line, -1 line 0 comments Download
M Source/core/rendering/RenderTableRow.cpp View 1 2 2 chunks +2 lines, -2 lines 0 comments Download
M Source/core/rendering/RenderTableSection.cpp View 1 2 1 chunk +1 line, -1 line 0 comments Download
M Source/core/rendering/RenderTextControlSingleLine.cpp View 1 2 2 chunks +2 lines, -2 lines 0 comments Download
M Source/core/rendering/RenderTheme.cpp View 1 2 2 chunks +2 lines, -2 lines 0 comments Download
M Source/core/rendering/RenderView.cpp View 1 2 1 chunk +2 lines, -2 lines 0 comments Download
M Source/core/rendering/RenderWidget.cpp View 1 2 1 chunk +1 line, -1 line 0 comments Download
M Source/core/rendering/svg/RenderSVGImage.cpp View 1 2 1 chunk +1 line, -1 line 0 comments Download
M Source/core/rendering/svg/RenderSVGModelObject.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/rendering/svg/RenderSVGResourceContainer.cpp View 1 2 1 chunk +1 line, -1 line 0 comments Download
M Source/core/rendering/svg/SVGRenderSupport.cpp View 1 2 1 chunk +1 line, -1 line 0 comments Download
M Source/web/WebPluginContainerImpl.cpp View 1 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 7 (0 generated)
dsinclair
PTAL. This is the first of several parts to move RenderObject from repaint to paint ...
6 years, 6 months ago (2014-06-04 20:21:30 UTC) #1
esprehn
rslgtm
6 years, 6 months ago (2014-06-06 01:36:00 UTC) #2
Julien - ping for review
lgtm https://codereview.chromium.org/318803002/diff/10001/Source/core/rendering/RenderObject.h File Source/core/rendering/RenderObject.h (right): https://codereview.chromium.org/318803002/diff/10001/Source/core/rendering/RenderObject.h#newcode842 Source/core/rendering/RenderObject.h:842: virtual void invalidateOverflowPaint(); Not a huge fan of ...
6 years, 6 months ago (2014-06-11 16:27:22 UTC) #3
dsinclair
https://codereview.chromium.org/318803002/diff/10001/Source/core/rendering/RenderObject.h File Source/core/rendering/RenderObject.h (right): https://codereview.chromium.org/318803002/diff/10001/Source/core/rendering/RenderObject.h#newcode842 Source/core/rendering/RenderObject.h:842: virtual void invalidateOverflowPaint(); On 2014/06/11 16:27:21, Julien Chaffraix - ...
6 years, 6 months ago (2014-06-11 17:04:06 UTC) #4
dsinclair
The CQ bit was checked by dsinclair@chromium.org
6 years, 6 months ago (2014-06-11 17:04:17 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dsinclair@chromium.org/318803002/30001
6 years, 6 months ago (2014-06-11 17:04:48 UTC) #6
commit-bot: I haz the power
6 years, 6 months ago (2014-06-11 18:11:07 UTC) #7
Message was sent while issue was closed. 
Change committed as 175969

Powered by Google App Engine
This is Rietveld 408576698