Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(104)

Side by Side Diff: Source/core/rendering/svg/SVGRenderSupport.cpp

Issue 318803002: Rename Repaint to Paint Invalidation part 3 (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Rebase to master Created 6 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2007, 2008 Rob Buis <buis@kde.org> 2 * Copyright (C) 2007, 2008 Rob Buis <buis@kde.org>
3 * Copyright (C) 2007 Nikolas Zimmermann <zimmermann@kde.org> 3 * Copyright (C) 2007 Nikolas Zimmermann <zimmermann@kde.org>
4 * Copyright (C) 2007 Eric Seidel <eric@webkit.org> 4 * Copyright (C) 2007 Eric Seidel <eric@webkit.org>
5 * Copyright (C) 2009 Google, Inc. All rights reserved. 5 * Copyright (C) 2009 Google, Inc. All rights reserved.
6 * Copyright (C) 2009 Dirk Schulze <krit@webkit.org> 6 * Copyright (C) 2009 Dirk Schulze <krit@webkit.org>
7 * Copyright (C) Research In Motion Limited 2009-2010. All rights reserved. 7 * Copyright (C) Research In Motion Limited 2009-2010. All rights reserved.
8 * 8 *
9 * This library is free software; you can redistribute it and/or 9 * This library is free software; you can redistribute it and/or
10 * modify it under the terms of the GNU Library General Public 10 * modify it under the terms of the GNU Library General Public
(...skipping 232 matching lines...) Expand 10 before | Expand all | Expand 10 after
243 243
244 layoutResourcesIfNeeded(child); 244 layoutResourcesIfNeeded(child);
245 245
246 if (child->needsLayout()) { 246 if (child->needsLayout()) {
247 child->layout(); 247 child->layout();
248 // Renderers are responsible for repainting themselves when changing , except 248 // Renderers are responsible for repainting themselves when changing , except
249 // for the initial paint to avoid potential double-painting caused b y non-sensical "old" bounds. 249 // for the initial paint to avoid potential double-painting caused b y non-sensical "old" bounds.
250 // We could handle this in the individual objects, but for now it's easier to have 250 // We could handle this in the individual objects, but for now it's easier to have
251 // parent containers call repaint(). (RenderBlock::layout* has simi lar logic.) 251 // parent containers call repaint(). (RenderBlock::layout* has simi lar logic.)
252 if (!childEverHadLayout && !RuntimeEnabledFeatures::repaintAfterLayo utEnabled()) 252 if (!childEverHadLayout && !RuntimeEnabledFeatures::repaintAfterLayo utEnabled())
253 child->repaint(); 253 child->invalidatePaint();
Julien - ping for review 2014/06/11 16:27:21 Maybe we could have a less tense name here like pa
dsinclair 2014/06/11 17:04:06 Done.
254 } else if (layoutSizeChanged) { 254 } else if (layoutSizeChanged) {
255 notlayoutedObjects.add(child); 255 notlayoutedObjects.add(child);
256 } 256 }
257 } 257 }
258 258
259 if (!layoutSizeChanged) { 259 if (!layoutSizeChanged) {
260 ASSERT(notlayoutedObjects.isEmpty()); 260 ASSERT(notlayoutedObjects.isEmpty());
261 return; 261 return;
262 } 262 }
263 263
(...skipping 128 matching lines...) Expand 10 before | Expand all | Expand 10 after
392 } 392 }
393 393
394 bool SVGRenderSupport::isRenderableTextNode(const RenderObject* object) 394 bool SVGRenderSupport::isRenderableTextNode(const RenderObject* object)
395 { 395 {
396 ASSERT(object->isText()); 396 ASSERT(object->isText());
397 // <br> is marked as text, but is not handled by the SVG rendering code-path . 397 // <br> is marked as text, but is not handled by the SVG rendering code-path .
398 return object->isSVGInlineText() && !toRenderSVGInlineText(object)->hasEmpty Text(); 398 return object->isSVGInlineText() && !toRenderSVGInlineText(object)->hasEmpty Text();
399 } 399 }
400 400
401 } 401 }
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698