Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(856)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 314253003: Remove memory_watcher tool as well as --memory-profile command line flag. (Closed)

Created:
6 years, 6 months ago by cbentzel
Modified:
6 years, 6 months ago
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Visibility:
Public.

Description

Remove memory_watcher tool as well as --memory-profile command line flag. This tool has not been maintained or used in a while, and tools such as UMDH work well as a replacement. BUG=383024 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=278607

Patch Set 1 #

Patch Set 2 : Remove memory_watcher reference from all.gyp #

Patch Set 3 : rebase #

Patch Set 4 : Fix compile issue on non-ChromeOS platforms #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -5119 lines) Patch
M build/all.gyp View 1 2 1 chunk +0 lines, -7 lines 0 comments Download
M chrome/app/chrome_main_delegate.cc View 1 2 4 chunks +0 lines, -23 lines 0 comments Download
M chrome/browser/chrome_content_browser_client.cc View 1 2 3 2 chunks +2 lines, -4 lines 0 comments Download
M chrome/common/chrome_switches.h View 1 2 1 chunk +0 lines, -1 line 0 comments Download
M chrome/common/chrome_switches.cc View 1 2 1 chunk +0 lines, -4 lines 0 comments Download
D tools/memory_watcher/DEPS View 1 chunk +0 lines, -3 lines 0 comments Download
D tools/memory_watcher/README View 1 chunk +0 lines, -17 lines 0 comments Download
D tools/memory_watcher/call_stack.h View 1 chunk +0 lines, -168 lines 0 comments Download
D tools/memory_watcher/call_stack.cc View 1 chunk +0 lines, -399 lines 0 comments Download
D tools/memory_watcher/dllmain.cc View 1 chunk +0 lines, -154 lines 0 comments Download
D tools/memory_watcher/hotkey.h View 1 chunk +0 lines, -50 lines 0 comments Download
D tools/memory_watcher/ia32_modrm_map.cc View 1 chunk +0 lines, -94 lines 0 comments Download
D tools/memory_watcher/ia32_opcode_map.cc View 1 chunk +0 lines, -1161 lines 0 comments Download
D tools/memory_watcher/memory_hook.h View 1 chunk +0 lines, -153 lines 0 comments Download
D tools/memory_watcher/memory_hook.cc View 1 chunk +0 lines, -562 lines 0 comments Download
D tools/memory_watcher/memory_watcher.h View 1 chunk +0 lines, -95 lines 0 comments Download
D tools/memory_watcher/memory_watcher.cc View 1 chunk +0 lines, -255 lines 0 comments Download
D tools/memory_watcher/memory_watcher.gyp View 1 chunk +0 lines, -48 lines 0 comments Download
D tools/memory_watcher/mini_disassembler.h View 1 chunk +0 lines, -163 lines 0 comments Download
D tools/memory_watcher/mini_disassembler.cc View 1 chunk +0 lines, -392 lines 0 comments Download
D tools/memory_watcher/mini_disassembler_types.h View 1 chunk +0 lines, -199 lines 0 comments Download
D tools/memory_watcher/preamble_patcher.h View 1 chunk +0 lines, -293 lines 0 comments Download
D tools/memory_watcher/preamble_patcher.cc View 1 chunk +0 lines, -228 lines 0 comments Download
D tools/memory_watcher/preamble_patcher_with_stub.cc View 1 chunk +0 lines, -174 lines 0 comments Download
D tools/memory_watcher/scripts/finditem.pl View 1 chunk +0 lines, -56 lines 0 comments Download
D tools/memory_watcher/scripts/memprof.pl View 1 chunk +0 lines, -116 lines 0 comments Download
D tools/memory_watcher/scripts/memtrace.pl View 1 chunk +0 lines, -146 lines 0 comments Download
D tools/memory_watcher/scripts/summary.pl View 1 chunk +0 lines, -154 lines 0 comments Download

Messages

Total messages: 14 (0 generated)
cbentzel
jar: overall change cpu: chrome/app/chrome_main_delegate.cc
6 years, 6 months ago (2014-06-10 20:05:41 UTC) #1
cpu_(ooo_6.6-7.5)
chrome_main_delegate.cc lgtm
6 years, 6 months ago (2014-06-10 23:47:25 UTC) #2
cbentzel
jar: ping
6 years, 6 months ago (2014-06-13 10:01:20 UTC) #3
jar (doing other things)
lgtm
6 years, 6 months ago (2014-06-13 19:46:29 UTC) #4
cbentzel
The CQ bit was checked by cbentzel@chromium.org
6 years, 6 months ago (2014-06-13 23:58:56 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/cbentzel@chromium.org/314253003/1
6 years, 6 months ago (2014-06-14 00:00:12 UTC) #6
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 6 months ago (2014-06-14 05:49:54 UTC) #7
commit-bot: I haz the power
Try jobs failed on following builders: win_gpu on tryserver.chromium.gpu (http://build.chromium.org/p/tryserver.chromium.gpu/builders/win_gpu/builds/20140)
6 years, 6 months ago (2014-06-14 05:49:54 UTC) #8
cbentzel
The CQ bit was checked by cbentzel@chromium.org
6 years, 6 months ago (2014-06-19 20:01:08 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/cbentzel@chromium.org/314253003/60001
6 years, 6 months ago (2014-06-19 20:04:14 UTC) #10
cbentzel
The CQ bit was checked by cbentzel@chromium.org
6 years, 6 months ago (2014-06-20 00:52:46 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/cbentzel@chromium.org/314253003/60001
6 years, 6 months ago (2014-06-20 00:56:00 UTC) #12
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: android_aosp on tryserver.chromium ...
6 years, 6 months ago (2014-06-20 02:48:38 UTC) #13
commit-bot: I haz the power
6 years, 6 months ago (2014-06-20 05:13:18 UTC) #14
Message was sent while issue was closed. 
Change committed as 278607

Powered by Google App Engine
This is Rietveld 408576698