[telemetry] Cleanups for benchmarks importing page sets.

[telemetry] Cleanups for benchmarks importing page sets.

Some of the code from a previous prototype [1] pulled out into a smaller patch that can be committed.

[1] https://chromiumcodereview.appspot.com/274773002/


BUG=362293
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=275633

[tonyg, 2014-06-04 21:05:07]

lgtm

So much cleaner

https://codereview.chromium.org/311193003/diff/20001/tools/telemetry/telemetr...
File tools/telemetry/telemetry/test.py (right):

https://codereview.chromium.org/311193003/diff/20001/tools/telemetry/telemetr...
tools/telemetry/telemetry/test.py:196: return cls.PageSetClass()()
Really like initializing lazily :)

[commit-bot: I haz the power, 2014-06-04 21:07:53]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/dtu@chromium.org/311193003/20001

[nednguyen, 2014-06-04 21:22:23]

The CQ bit was unchecked by nednguyen@google.com

[nednguyen, 2014-06-04 21:22:48]

lgtm


Maybe rebase after https://codereview.chromium.org/315083002/ is landed?

[nednguyen, 2014-06-04 21:22:50]

lgtm


Maybe rebase after https://codereview.chromium.org/315083002/ is landed?

[nednguyen, 2014-06-04 22:15:44]

https://codereview.chromium.org/311193003/diff/20001/tools/telemetry/telemetr...
File tools/telemetry/telemetry/page/page_set.py (right):

https://codereview.chromium.org/311193003/diff/20001/tools/telemetry/telemetr...
tools/telemetry/telemetry/page/page_set.py:54: def Description(cls):
Can you add a TODO to remove the member description from page_set?

[dtu, 2014-06-05 00:07:41]

+kbr OWNERS

On 2014/06/04 21:22:50, nednguyen wrote:
> lgtm
> 
> 
> Maybe rebase after https://codereview.chromium.org/315083002/ is landed?

Done.

https://codereview.chromium.org/311193003/diff/20001/tools/telemetry/telemetr...
File tools/telemetry/telemetry/page/page_set.py (right):

https://codereview.chromium.org/311193003/diff/20001/tools/telemetry/telemetr...
tools/telemetry/telemetry/page/page_set.py:54: def Description(cls):
On 2014/06/04 22:15:45, nednguyen wrote:
> Can you add a TODO to remove the member description from page_set?

I'm going to make Name/Description a MixIn because it's used by a lot of
classes.
It'll be useful for page sets in the future when listing them from the command
line.

[nednguyen, 2014-06-05 00:10:01]

On 2014/06/05 00:07:41, dtu wrote:
> +kbr OWNERS
> 
> On 2014/06/04 21:22:50, nednguyen wrote:
> > lgtm
> > 
> > 
> > Maybe rebase after https://codereview.chromium.org/315083002/ is landed?
> 
> Done.
> 
>
https://codereview.chromium.org/311193003/diff/20001/tools/telemetry/telemetr...
> File tools/telemetry/telemetry/page/page_set.py (right):
> 
>
https://codereview.chromium.org/311193003/diff/20001/tools/telemetry/telemetr...
> tools/telemetry/telemetry/page/page_set.py:54: def Description(cls):
> On 2014/06/04 22:15:45, nednguyen wrote:
> > Can you add a TODO to remove the member description from page_set?
> 
> I'm going to make Name/Description a MixIn because it's used by a lot of
> classes.
> It'll be useful for page sets in the future when listing them from the command
> line.

Sorry, I meant to remove the existing field called 'description' from
page_set.py 

...
class PageSet(object):
  def __init__(self, file_path=None, description='', archive_data_file='',
               credentials_path=None, user_agent_type=None,
               make_javascript_deterministic=True, startup_url='',
               serving_dirs=None):

[Ken Russell (switch to Gerrit), 2014-06-05 00:25:04]

content/test/gpu LGTM

[dtu, 2014-06-05 01:36:18]

On 2014/06/05 00:10:01, nednguyen wrote:
> On 2014/06/05 00:07:41, dtu wrote:
> > +kbr OWNERS
> > 
> > On 2014/06/04 21:22:50, nednguyen wrote:
> > > lgtm
> > > 
> > > 
> > > Maybe rebase after https://codereview.chromium.org/315083002/ is landed?
> > 
> > Done.
> > 
> >
>
https://codereview.chromium.org/311193003/diff/20001/tools/telemetry/telemetr...
> > File tools/telemetry/telemetry/page/page_set.py (right):
> > 
> >
>
https://codereview.chromium.org/311193003/diff/20001/tools/telemetry/telemetr...
> > tools/telemetry/telemetry/page/page_set.py:54: def Description(cls):
> > On 2014/06/04 22:15:45, nednguyen wrote:
> > > Can you add a TODO to remove the member description from page_set?
> > 
> > I'm going to make Name/Description a MixIn because it's used by a lot of
> > classes.
> > It'll be useful for page sets in the future when listing them from the
command
> > line.
> 
> Sorry, I meant to remove the existing field called 'description' from
> page_set.py 
> 
> ...
> class PageSet(object):
>   def __init__(self, file_path=None, description='', archive_data_file='',
>                credentials_path=None, user_agent_type=None,
>                make_javascript_deterministic=True, startup_url='',
>                serving_dirs=None):

Removed!

[dtu, 2014-06-05 20:59:47]

The CQ bit was checked by dtu@chromium.org

[commit-bot: I haz the power, 2014-06-05 21:01:45]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/dtu@chromium.org/311193003/100001

[commit-bot: I haz the power, 2014-06-06 01:41:18]

FYI, CQ is re-trying this CL (attempt #1).
The failing builders are:
  linux_chromium_clang_dbg on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/linux_chromium_clang_...)
  linux_gpu_triggered_tests on tryserver.chromium.gpu
(http://build.chromium.org/p/tryserver.chromium.gpu/builders/linux_gpu_trigger...)
  mac_gpu_retina_triggered_tests on tryserver.chromium.gpu
(http://build.chromium.org/p/tryserver.chromium.gpu/builders/mac_gpu_retina_tr...)
  mac_gpu_triggered_tests on tryserver.chromium.gpu
(http://build.chromium.org/p/tryserver.chromium.gpu/builders/mac_gpu_triggered...)
  win_gpu_triggered_tests on tryserver.chromium.gpu
(http://build.chromium.org/p/tryserver.chromium.gpu/builders/win_gpu_triggered...)

[commit-bot: I haz the power, 2014-06-06 01:44:31]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-06-06 01:44:32]

Try jobs failed on following builders:
  linux_gpu_triggered_tests on tryserver.chromium.gpu
(http://build.chromium.org/p/tryserver.chromium.gpu/builders/linux_gpu_trigger...)
  mac_gpu_triggered_tests on tryserver.chromium.gpu
(http://build.chromium.org/p/tryserver.chromium.gpu/builders/mac_gpu_triggered...)
  win_gpu_triggered_tests on tryserver.chromium.gpu
(http://build.chromium.org/p/tryserver.chromium.gpu/builders/win_gpu_triggered...)

[dtu, 2014-06-06 23:32:39]

The CQ bit was checked by dtu@chromium.org

[commit-bot: I haz the power, 2014-06-06 23:34:08]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/dtu@chromium.org/311193003/120001

[commit-bot: I haz the power, 2014-06-07 04:23:20]

FYI, CQ is re-trying this CL (attempt #1).
The failing builders are:
  linux_chromium_rel on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/linux_chromium_rel/bu...)
  mac_chromium_rel on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/mac_chromium_rel/buil...)
  win_chromium_rel on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/win_chromium_rel/buil...)

[commit-bot: I haz the power, 2014-06-07 06:19:57]

Change committed as 275633