Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(501)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 315083002: Convert page_set in chrome_proxy benchmarks to use the actual page_set objects. (Closed)

Created:
6 years, 6 months ago by nednguyen
Modified:
6 years, 6 months ago
Reviewers:
dtu, tonyg
CC:
chromium-reviews, telemetry+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Visibility:
Public.

Description

Convert page_set in chrome_proxy benchmarks to use the actual page_set objects. BUG=362293 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=274924

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+20 lines, -15 lines) Patch
M tools/perf/benchmarks/chrome_proxy.py View 3 chunks +20 lines, -15 lines 0 comments Download

Messages

Total messages: 9 (0 generated)
nednguyen
6 years, 6 months ago (2014-06-04 18:22:49 UTC) #1
tonyg
lgtm
6 years, 6 months ago (2014-06-04 18:25:49 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/nednguyen@google.com/315083002/1
6 years, 6 months ago (2014-06-04 18:28:09 UTC) #3
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: linux_chromium_gn_rel on tryserver.chromium ...
6 years, 6 months ago (2014-06-04 21:47:53 UTC) #4
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 6 months ago (2014-06-04 21:57:11 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_gn_rel on tryserver.chromium (http://build.chromium.org/p/tryserver.chromium/builders/linux_chromium_gn_rel/builds/13408)
6 years, 6 months ago (2014-06-04 21:57:11 UTC) #6
nednguyen
The CQ bit was checked by nednguyen@google.com
6 years, 6 months ago (2014-06-04 21:57:41 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/nednguyen@google.com/315083002/1
6 years, 6 months ago (2014-06-04 21:59:32 UTC) #8
commit-bot: I haz the power
6 years, 6 months ago (2014-06-04 22:11:23 UTC) #9
Message was sent while issue was closed. 
Change committed as 274924

Powered by Google App Engine
This is Rietveld 408576698