Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(461)

Side by Side Diff: tools/telemetry/telemetry/page/page_set.py

Issue 311193003: [telemetry] Cleanups for benchmarks importing page sets. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 6 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 # Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 # Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 # Use of this source code is governed by a BSD-style license that can be 2 # Use of this source code is governed by a BSD-style license that can be
3 # found in the LICENSE file. 3 # found in the LICENSE file.
4 4
5 import csv 5 import csv
6 import inspect 6 import inspect
7 import os 7 import os
8 8
9 from telemetry.core import util 9 from telemetry.core import util
10 from telemetry.page import page as page_module 10 from telemetry.page import page as page_module
(...skipping 28 matching lines...) Expand all
39 self.pages = [] 39 self.pages = []
40 self.serving_dirs = set() 40 self.serving_dirs = set()
41 serving_dirs = [] if serving_dirs is None else serving_dirs 41 serving_dirs = [] if serving_dirs is None else serving_dirs
42 # Makes sure that page_set's serving_dirs are absolute paths 42 # Makes sure that page_set's serving_dirs are absolute paths
43 for sd in serving_dirs: 43 for sd in serving_dirs:
44 if os.path.isabs(sd): 44 if os.path.isabs(sd):
45 self.serving_dirs.add(os.path.realpath(sd)) 45 self.serving_dirs.add(os.path.realpath(sd))
46 else: 46 else:
47 self.serving_dirs.add(os.path.realpath(os.path.join(self.base_dir, sd))) 47 self.serving_dirs.add(os.path.realpath(os.path.join(self.base_dir, sd)))
48 48
49 @classmethod
50 def Name(cls):
51 return cls.__module__.split('.')[-1]
52
53 @classmethod
54 def Description(cls):
nednguyen 2014/06/04 22:15:45 Can you add a TODO to remove the member descriptio
dtu 2014/06/05 00:07:42 I'm going to make Name/Description a MixIn because
55 if cls.__doc__:
56 return cls.__doc__.splitlines()[0]
57 else:
58 return ''
59
49 def AddPage(self, page): 60 def AddPage(self, page):
50 assert page.page_set is self 61 assert page.page_set is self
51 self.pages.append(page) 62 self.pages.append(page)
52 63
53 def AddPageWithDefaultRunNavigate(self, page_url): 64 def AddPageWithDefaultRunNavigate(self, page_url):
54 """ Add a simple page with url equals to page_url that contains only default 65 """ Add a simple page with url equals to page_url that contains only default
55 RunNavigateSteps. 66 RunNavigateSteps.
56 """ 67 """
57 self.AddPage(page_module.Page( 68 self.AddPage(page_module.Page(
58 page_url, self, self.base_dir)) 69 page_url, self, self.base_dir))
(...skipping 89 matching lines...) Expand 10 before | Expand all | Expand 10 after
148 return self.pages.__iter__() 159 return self.pages.__iter__()
149 160
150 def __len__(self): 161 def __len__(self):
151 return len(self.pages) 162 return len(self.pages)
152 163
153 def __getitem__(self, key): 164 def __getitem__(self, key):
154 return self.pages[key] 165 return self.pages[key]
155 166
156 def __setitem__(self, key, value): 167 def __setitem__(self, key, value):
157 self.pages[key] = value 168 self.pages[key] = value
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698