tools/telemetry/telemetry/core/discover.py - Issue 311193003: [telemetry] Cleanups for benchmarks importing page sets.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tools/telemetry/telemetry/core/discover.py

Issue 311193003: [telemetry] Cleanups for benchmarks importing page sets. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Remove description fo' realz. (from gpu tests) Created 6 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « tools/perf/profile_creators/theme_profile_creator.py ('k') | tools/telemetry/telemetry/page/extensions_profile_creator.py » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: tools/telemetry/telemetry/core/discover.py

diff --git a/tools/telemetry/telemetry/core/discover.py b/tools/telemetry/telemetry/core/discover.py

index d815bdf99c83173c52b15900f03843338ab269dd..9e8118a731fd59e29f834043096b5438750eb694 100644

--- a/tools/telemetry/telemetry/core/discover.py

+++ b/tools/telemetry/telemetry/core/discover.py

@@ -133,15 +133,3 @@ def IsPageSetFile(file_path):

return False

module = util.GetPythonPageSetModule(file_path)

return bool(DiscoverClassesInModule(module, page_set.PageSet))

-def GetAllPageSetFilenames(dir_path):

- results = []

- for sub_path, _, filenames in os.walk(dir_path):

- for f in filenames:

- if f.startswith('.'):

- continue

- filename = os.path.join(sub_path, f)

- if IsPageSetFile(filename):

- results.append(filename)

- return results