Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(201)

Unified Diff: tools/telemetry/telemetry/page/page_set.py

Issue 311193003: [telemetry] Cleanups for benchmarks importing page sets. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Remove description fo' realz. (from gpu tests) Created 6 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: tools/telemetry/telemetry/page/page_set.py
diff --git a/tools/telemetry/telemetry/page/page_set.py b/tools/telemetry/telemetry/page/page_set.py
index 2285b2958c9ace64a01a01d4097cc7a1b21a1969..234e7b1a8e29655934c755707c93162c7c1aaed9 100644
--- a/tools/telemetry/telemetry/page/page_set.py
+++ b/tools/telemetry/telemetry/page/page_set.py
@@ -15,7 +15,7 @@ class PageSetError(Exception):
class PageSet(object):
- def __init__(self, file_path=None, description='', archive_data_file='',
+ def __init__(self, file_path=None, archive_data_file='',
credentials_path=None, user_agent_type=None,
make_javascript_deterministic=True, startup_url='',
serving_dirs=None):
@@ -29,7 +29,6 @@ class PageSet(object):
self.file_path = file_path
# These attributes can be set dynamically by the page set.
- self.description = description
self.archive_data_file = archive_data_file
self.credentials_path = credentials_path
self.user_agent_type = user_agent_type
@@ -46,6 +45,17 @@ class PageSet(object):
else:
self.serving_dirs.add(os.path.realpath(os.path.join(self.base_dir, sd)))
+ @classmethod
+ def Name(cls):
+ return cls.__module__.split('.')[-1]
+
+ @classmethod
+ def Description(cls):
+ if cls.__doc__:
+ return cls.__doc__.splitlines()[0]
+ else:
+ return ''
+
def AddPage(self, page):
assert page.page_set is self
self.pages.append(page)
« no previous file with comments | « tools/telemetry/telemetry/page/extensions_profile_creator.py ('k') | tools/telemetry/telemetry/page/page_set_unittest.py » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698