IDL build: Split global constructors into core and modules

IDL build: Split global constructors into core and modules

No substantive changes to generated bindings:
just reorders the constructors on global objects b/c split
between core and modules.

This almost completes splitting the build!
(Only remaining step is to split global objects, at which
point I can eliminate the bindings/generated.gyp)

Global constructors from modules are in bindings_core b/c
they affect core bindings (due to partial interfaces), with
FIXMEs to move them to bindings_modules.

R=haraken
BUG=358074
Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=175462

[Nils Barth (inactive), 2014-06-02 10:06:25]

Almost done!

https://codereview.chromium.org/310563004/diff/120001/Source/bindings/binding...
File Source/bindings/bindings.gypi (left):

https://codereview.chromium.org/310563004/diff/120001/Source/bindings/binding...
Source/bindings/bindings.gypi:11: 'blink_output_dir':
'<(SHARED_INTERMEDIATE_DIR)/blink',
No more files are generated in base gen/blink!
(All are in bindings, and all but one are in bindings/core or bindings/modules.)

[haraken, 2014-06-02 15:45:14]

OK... I got lost!

I'd be happy if you could draw an illustration about GYP dependencies offline
tomorrow :)

https://codereview.chromium.org/310563004/diff/120001/Source/bindings/core/co...
File Source/bindings/core/core.gypi (right):

https://codereview.chromium.org/310563004/diff/120001/Source/bindings/core/co...
Source/bindings/core/core.gypi:7: '../modules/v8/generated.gypi',  # FIXME:
remove once core script generate qualified includes correctly:
http://crbug.com/358074

generate => generates

https://codereview.chromium.org/310563004/diff/120001/Source/bindings/core/v8...
File Source/bindings/core/v8/generated.gyp (right):

https://codereview.chromium.org/310563004/diff/120001/Source/bindings/core/v8...
Source/bindings/core/v8/generated.gyp:33: 'dependencies': [

Just a question about GYP: What is "dependencies"? What's a relationship between
"dependencies" and "includes"?

https://codereview.chromium.org/310563004/diff/120001/Source/bindings/modules...
File Source/bindings/modules/generated.gyp (right):

https://codereview.chromium.org/310563004/diff/120001/Source/bindings/modules...
Source/bindings/modules/generated.gyp:17: 'modules.gypi',

Why doesn't this depend on 'generated.gypi' ?

https://codereview.chromium.org/310563004/diff/120001/Source/bindings/modules...
File Source/bindings/modules/generated.gypi (right):

https://codereview.chromium.org/310563004/diff/120001/Source/bindings/modules...
Source/bindings/modules/generated.gypi:7:
'../../modules/modules_generated.gypi',

I wonder why you need to distinguish modules/modules_generated.gypi from
modules/generated.gypi.

[Nils Barth (inactive), 2014-06-03 01:47:49]

(Replies to inline comments.)

https://codereview.chromium.org/310563004/diff/120001/Source/bindings/core/co...
File Source/bindings/core/core.gypi (right):

https://codereview.chromium.org/310563004/diff/120001/Source/bindings/core/co...
Source/bindings/core/core.gypi:7: '../modules/v8/generated.gypi',  # FIXME:
remove once core script generate qualified includes correctly:
http://crbug.com/358074
On 2014/06/02 15:45:14, haraken wrote:
> generate => generates

actually should be 'core script' => 'core script*s*';
fixed, thanks!

https://codereview.chromium.org/310563004/diff/120001/Source/bindings/core/v8...
File Source/bindings/core/v8/generated.gyp (right):

https://codereview.chromium.org/310563004/diff/120001/Source/bindings/core/v8...
Source/bindings/core/v8/generated.gyp:33: 'dependencies': [
On 2014/06/02 15:45:14, haraken wrote:
> Just a question about GYP: What is "dependencies"? What's a relationship
between
> "dependencies" and "includes"?

Short answer:
'dependencies': This lists other targets that this target depends on.
'includes': A list of of other files that will be included in this file.

Dependencies create the edges of the build dependency graph;
includes are just about factoring the .gyp/.gypi files to avoid
duplication.

Long answer (quoting docs):
'dependencies': This lists other targets that this target depends on. The
gyp-generated files will guarantee that the other targets are built before this
target. Any library targets in the dependencies list will be linked with this
target. The various settings (defines, include_dirs, etc.) listed in the
direct_dependent_settings sections of the targets in this list will be applied
to how this target is built and linked. See the more complete discussion of
direct_dependent_settings, below.

'includes': A list of of other files that will be included in this file. By
convention, included files have the suffix .gypi (gyp include).

References:
https://code.google.com/p/gyp/wiki/GypUserDocumentation

https://codereview.chromium.org/310563004/diff/120001/Source/bindings/modules...
File Source/bindings/modules/generated.gyp (right):

https://codereview.chromium.org/310563004/diff/120001/Source/bindings/modules...
Source/bindings/modules/generated.gyp:17: 'modules.gypi',
On 2014/06/02 15:45:14, haraken wrote:
> Why doesn't this depend on 'generated.gypi' ?

Good catch!
Because the modules generated files are generated in bindings_core
(since they are used by core bindings).
I've added a FIXME.

https://codereview.chromium.org/310563004/diff/120001/Source/bindings/modules...
File Source/bindings/modules/generated.gypi (right):

https://codereview.chromium.org/310563004/diff/120001/Source/bindings/modules...
Source/bindings/modules/generated.gypi:7:
'../../modules/modules_generated.gypi',
On 2014/06/02 15:45:14, haraken wrote:
> 
> I wonder why you need to distinguish modules/modules_generated.gypi from
> modules/generated.gypi.

This is modules vs. bindings_modules:
include is:
modules/modules_generated.gypi
this file is:
bindings/modules/generated.gypi

(It's a bit confusing with the relative paths.)

[Nils Barth (inactive), 2014-06-03 02:12:40]

On 2014/06/02 15:45:14, haraken wrote:
> OK... I got lost!
> 
> I'd be happy if you could draw an illustration about GYP dependencies offline
> tomorrow :)

Will do!
(Once discussed, I might rearrange, and anyway I'll write clear comments.)

For reference, here's a quick sketch here.

I've written this up in some detail at:
http://www.chromium.org/developers/design-documents/idl-build#TOC-GYP

The only really ugly part is the long lists of .gypi includes in the .gyp files,
and that's primarily because of layering violations (bindings_core ->
bindings_modules):
these make the (bad) dependencies explicit.

The only outside dependencies on bindings (in core/core.gyp and
modules/modules.gyp) are:
'../bindings/core/core.gypi',  # core can depend on bindings/core, but not on
bindings
'../bindings/modules/modules.gypi',  # modules can depend on bindings/modules,
but not on bindings
'../bindings/core/v8/generated.gyp:bindings_core_v8_generated',
'../bindings/modules/v8/generated.gyp:bindings_modules_v8_generated',

In other words, complexity here is only internal organization, and is used to
*encapsulate*
bindings (hide internal details from core and modules).

The actual .gyp files (build targets) are quite simple:
core/generated.gyp
core/v8/generated.gyp
modules/generated.gyp
modules/v8/generated.gyp
scripts/scripts.gyp

I.e., there's generated.gyp in:
core/
core/v8/
modules/
modules/v8/
...corresponding to global info (core/ and modules/) and actual bindings
(core/v8/ and modules/v8/).

The scripts/scripts.gyp file is just for precaching in scripts.

There's also a root level
generated.gyp
...which I'll eliminate in the followup.

There are various .gypi files, of the format:
foo/foo.gypi  # main, public
foo/generated.gypi  # list of generated files

The one bindings-specific complexity are the idl.gypi files (core/idl.gypi and
modules/idl.gypi),
due to having to categorize all the IDL files.

We'll chat about this offline to make sure this makes sense;
hope this clarifies the organization!

[haraken, 2014-06-03 04:14:33]

On 2014/06/03 02:12:40, Nils Barth wrote:
> On 2014/06/02 15:45:14, haraken wrote:
> > OK... I got lost!
> > 
> > I'd be happy if you could draw an illustration about GYP dependencies
offline
> > tomorrow :)
> 
> Will do!
> (Once discussed, I might rearrange, and anyway I'll write clear comments.)
> 
> For reference, here's a quick sketch here.
> 
> I've written this up in some detail at:
> http://www.chromium.org/developers/design-documents/idl-build#TOC-GYP
> 
> The only really ugly part is the long lists of .gypi includes in the .gyp
files,
> and that's primarily because of layering violations (bindings_core ->
> bindings_modules):
> these make the (bad) dependencies explicit.
> 
> The only outside dependencies on bindings (in core/core.gyp and
> modules/modules.gyp) are:
> '../bindings/core/core.gypi',  # core can depend on bindings/core, but not on
> bindings
> '../bindings/modules/modules.gypi',  # modules can depend on bindings/modules,
> but not on bindings
> '../bindings/core/v8/generated.gyp:bindings_core_v8_generated',
> '../bindings/modules/v8/generated.gyp:bindings_modules_v8_generated',
> 
> In other words, complexity here is only internal organization, and is used to
> *encapsulate*
> bindings (hide internal details from core and modules).
> 
> The actual .gyp files (build targets) are quite simple:
> core/generated.gyp
> core/v8/generated.gyp
> modules/generated.gyp
> modules/v8/generated.gyp
> scripts/scripts.gyp
> 
> I.e., there's generated.gyp in:
> core/
> core/v8/
> modules/
> modules/v8/
> ...corresponding to global info (core/ and modules/) and actual bindings
> (core/v8/ and modules/v8/).
> 
> The scripts/scripts.gyp file is just for precaching in scripts.
> 
> There's also a root level
> generated.gyp
> ...which I'll eliminate in the followup.
> 
> There are various .gypi files, of the format:
> foo/foo.gypi  # main, public
> foo/generated.gypi  # list of generated files
> 
> The one bindings-specific complexity are the idl.gypi files (core/idl.gypi and
> modules/idl.gypi),
> due to having to categorize all the IDL files.
> 
> We'll chat about this offline to make sure this makes sense;
> hope this clarifies the organization!

Thanks for the detailed explanation!

The overall design makes a lot of sense to me. However, I feel that the naming
is a bit confusing. Let's discuss how to improve it.

[Nils Barth (inactive), 2014-06-03 05:44:59]

Revised per discussion; notable changes:
* qualify .gypi paths (so relative to Source)
A bit ugly b/c can't use variables in includes, but at least uniform.
* document interfaces_info generation better
* simplify a bit!
(move modules global generators into modules, where it makes more sense)

Followups:
* Last split (global objects)
* Write up next steps (partly done locally), namely:
1. core and modules generation (qualified paths)
2. checkdeps on gen
3. bindings for partial interfaces

[Nils Barth (inactive), 2014-06-03 07:25:31]

One last tweak:
updated the FIXME in core.gyp to newly opened and more specific bug:
https://code.google.com/p/chromium/issues/detail?id=380054
...and removed a useless include search path:
had both WebKit/Source (good) and WebKit (?? bad)

[haraken, 2014-06-03 15:31:09]

Thanks for the detailed explanation. Most of the below comments are just
clarifying questions to help me understand.

https://codereview.chromium.org/310563004/diff/220001/Source/bindings/core/co...
File Source/bindings/core/core.gypi (right):

https://codereview.chromium.org/310563004/diff/220001/Source/bindings/core/co...
Source/bindings/core/core.gypi:7: '../bindings.gypi',

FIXME: remove this?

https://codereview.chromium.org/310563004/diff/220001/Source/bindings/core/ge...
File Source/bindings/core/generated.gyp (right):

https://codereview.chromium.org/310563004/diff/220001/Source/bindings/core/ge...
Source/bindings/core/generated.gyp:12: '../../bindings/bindings.gypi',

FIXME: remove this?

https://codereview.chromium.org/310563004/diff/220001/Source/bindings/core/ge...
Source/bindings/core/generated.gyp:17: 'idl.gypi',

To avoid confusion, it might be better to always write paths relative to the
Source directory.

<(source_dir)/bindings/bindings.gypi
...
<(source_dir)/bindings/core/core.gypi (instead of core.gypi)

The same comment for other parts in this CL.

https://codereview.chromium.org/310563004/diff/220001/Source/bindings/core/id...
File Source/bindings/core/idl.gypi (right):

https://codereview.chromium.org/310563004/diff/220001/Source/bindings/core/id...
Source/bindings/core/idl.gypi:10: 'generated.gypi',

- Why does idl.gypi need to include Source/core/core.gypi and
Source/bindings/core/generated.gypi? I wonder IDL files don't depend on
anything.

- If idl.gypi needs to include Source/core/core.gypi and
Source/bindings/core/generated.gypi, why does idl.gypi not need to include
Source/core/generated.gypi?

https://codereview.chromium.org/310563004/diff/220001/Source/bindings/core/v8...
File Source/bindings/core/v8/generated.gyp (right):

https://codereview.chromium.org/310563004/diff/220001/Source/bindings/core/v8...
Source/bindings/core/v8/generated.gyp:12: '../../../bindings/bindings.gypi',

FIXME: remove this?

https://codereview.chromium.org/310563004/diff/220001/Source/bindings/core/v8...
Source/bindings/core/v8/generated.gyp:18:
'../../../bindings/modules/modules.gypi',

Doesn't this GYP also (potentially) depend on
../../../bindings/modules/generated.gypi?

https://codereview.chromium.org/310563004/diff/220001/Source/bindings/idl.gypi
File Source/bindings/idl.gypi (right):

https://codereview.chromium.org/310563004/diff/220001/Source/bindings/idl.gyp...
Source/bindings/idl.gypi:23: 'main_interface_idl_files_list':
'<|(main_interface_idl_files_list.tmp <@(main_interface_idl_files))',

Do we still need bindings/idl.gypi, or are you going to remove it?

If you're planning to remove bindings/bindings.gypi but not remove
bindings/idl.gypi, that sounds mysterious to me.

https://codereview.chromium.org/310563004/diff/220001/Source/bindings/modules...
File Source/bindings/modules/generated.gyp (right):

https://codereview.chromium.org/310563004/diff/220001/Source/bindings/modules...
Source/bindings/modules/generated.gyp:12: '../../bindings/bindings.gypi',

FIXME: remove this?

https://codereview.chromium.org/310563004/diff/220001/Source/bindings/modules...
Source/bindings/modules/generated.gyp:16: '../../modules/modules.gypi',

Doesn't this GYP also depend on:

- ../../modules/generated.gypi
- ../../bindings/core/generated.gypi
- ../../bindings/core/idl.gypi
- ../../core/core.gypi
- ../../core/generated.gypi

?

In particular, I don't understand why this GYP doesn't depend on
../../bindings/core/generated.gypi and ../../core/core.gypi. Probably is the
"includes" working transitively via ../../bindings/core/core.gypi?

Even if the "includes" works transitively, we don't want to rely on the
transitiveness to make the dependency clearer, given the complexity of the build
dependency around the IDL compiler.

https://codereview.chromium.org/310563004/diff/220001/Source/bindings/modules...
File Source/bindings/modules/idl.gypi (right):

https://codereview.chromium.org/310563004/diff/220001/Source/bindings/modules...
Source/bindings/modules/idl.gypi:11: 'generated.gypi',

The same question as before. I want to understand why idl.gypi needs to depend
on someone else.

https://codereview.chromium.org/310563004/diff/220001/Source/bindings/modules...
File Source/bindings/modules/modules.gypi (right):

https://codereview.chromium.org/310563004/diff/220001/Source/bindings/modules...
Source/bindings/modules/modules.gypi:7: '../bindings.gypi',

FIXME: remove this?

https://codereview.chromium.org/310563004/diff/220001/Source/bindings/modules...
Source/bindings/modules/modules.gypi:8: 'v8/generated.gypi',

Doesn't this GYP also depend on:

../v8/v8.gypi # FIXME: this should be v8/v8.gypi
../../core/generated.gypi

?

https://codereview.chromium.org/310563004/diff/220001/Source/bindings/modules...
File Source/bindings/modules/v8/generated.gyp (right):

https://codereview.chromium.org/310563004/diff/220001/Source/bindings/modules...
Source/bindings/modules/v8/generated.gyp:12: '../../../bindings/bindings.gypi',

FIXME: remove this?

https://codereview.chromium.org/310563004/diff/220001/Source/bindings/modules...
Source/bindings/modules/v8/generated.gyp:14:
'../../../bindings/modules/modules.gypi',

Doesn't this GYP depend on ../../../bindings/modules/generated.gypi?

https://codereview.chromium.org/310563004/diff/220001/Source/bindings/modules...
Source/bindings/modules/v8/generated.gyp:17: 'generated.gypi',

I wonder why this GYP doesn't depend on anything in ../../../core/*.

https://codereview.chromium.org/310563004/diff/220001/Source/core/core_genera...
File Source/core/core_generated.gypi (right):

https://codereview.chromium.org/310563004/diff/220001/Source/core/core_genera...
Source/core/core_generated.gypi:5: {

I got confused by this GYP. I understand why we need core/core.gyp,
core/generated.gyp and core/v8/generated.gyp, but why do we need
core/core_generated.gyp?

https://codereview.chromium.org/310563004/diff/220001/Source/modules/modules_...
File Source/modules/modules_generated.gypi (right):

https://codereview.chromium.org/310563004/diff/220001/Source/modules/modules_...
Source/modules/modules_generated.gypi:5: {

Ditto. I don't fully understand why we need modules/modules_generated.gypi.

[Nils Barth (inactive), 2014-06-04 03:36:32]

Replies:
questions were essentially all about how .gypi (GYP includes) work
and why they were factored as such.

https://codereview.chromium.org/310563004/diff/220001/Source/bindings/core/co...
File Source/bindings/core/core.gypi (right):

https://codereview.chromium.org/310563004/diff/220001/Source/bindings/core/co...
Source/bindings/core/core.gypi:7: '../bindings.gypi',
On 2014/06/03 15:31:10, haraken wrote:
> FIXME: remove this?

It's about to be removed (in immediate followup), so don't need FIXMEs at the
use sites.
(No risk of missing these.)

https://codereview.chromium.org/310563004/diff/220001/Source/bindings/core/ge...
File Source/bindings/core/generated.gyp (right):

https://codereview.chromium.org/310563004/diff/220001/Source/bindings/core/ge...
Source/bindings/core/generated.gyp:12: '../../bindings/bindings.gypi',
On 2014/06/03 15:31:10, haraken wrote:
> FIXME: remove this?

ditto.

https://codereview.chromium.org/310563004/diff/220001/Source/bindings/core/ge...
Source/bindings/core/generated.gyp:17: 'idl.gypi',
On 2014/06/03 15:31:10, haraken wrote:
> To avoid confusion, it might be better to always write paths relative to the
> Source directory.

I'd prefer to *not* qualify paths if it's the same directory:
this makes it clear that it's part of the same group.

(OTOH, avoiding confusing multi-level .. vs. ../.. is good.)

https://codereview.chromium.org/310563004/diff/220001/Source/bindings/core/id...
File Source/bindings/core/idl.gypi (right):

https://codereview.chromium.org/310563004/diff/220001/Source/bindings/core/id...
Source/bindings/core/idl.gypi:10: 'generated.gypi',
On 2014/06/03 15:31:10, haraken wrote:
> - Why does idl.gypi need to include Source/core/core.gypi and
> Source/bindings/core/generated.gypi?

Because that's where the IDL files are listed.

> - If idl.gypi needs to include Source/core/core.gypi and
> Source/bindings/core/generated.gypi,
> why does idl.gypi not need to include Source/core/generated.gypi?

(You mean Source/core/*core_*generated.gypi)
Because there are no IDL files defined there:
core does not generate any IDL files.

https://codereview.chromium.org/310563004/diff/220001/Source/bindings/core/v8...
File Source/bindings/core/v8/generated.gyp (right):

https://codereview.chromium.org/310563004/diff/220001/Source/bindings/core/v8...
Source/bindings/core/v8/generated.gyp:12: '../../../bindings/bindings.gypi',
On 2014/06/03 15:31:10, haraken wrote:
> FIXME: remove this?

ditto.

https://codereview.chromium.org/310563004/diff/220001/Source/bindings/core/v8...
Source/bindings/core/v8/generated.gyp:18:
'../../../bindings/modules/modules.gypi',
On 2014/06/03 15:31:10, haraken wrote:
> Doesn't this GYP also (potentially) depend on
> ../../../bindings/modules/generated.gypi?

No.
The variables defined in
bindings/modules/generated.gypi
...namely:
modules_global_constructors_generated_idl_files
modules_global_constructors_generated_header_files

are only used in:
bindings/modules/generated.gyp
bindings/modules/idl.gypi
There is no direct use of them elsewhere.

The confusion is because these IDL files *are* needed by core,
but that's handled by the list in:
bindings/modules/idl.gypi
...which *is* included here.

https://codereview.chromium.org/310563004/diff/220001/Source/bindings/idl.gypi
File Source/bindings/idl.gypi (right):

https://codereview.chromium.org/310563004/diff/220001/Source/bindings/idl.gyp...
Source/bindings/idl.gypi:23: 'main_interface_idl_files_list':
'<|(main_interface_idl_files_list.tmp <@(main_interface_idl_files))',
On 2014/06/03 15:31:10, haraken wrote:
> Do we still need bindings/idl.gypi, or are you going to remove it?

I'm also going to remove it.

https://codereview.chromium.org/310563004/diff/220001/Source/bindings/modules...
File Source/bindings/modules/generated.gyp (right):

https://codereview.chromium.org/310563004/diff/220001/Source/bindings/modules...
Source/bindings/modules/generated.gyp:16: '../../modules/modules.gypi',
On 2014/06/03 15:31:10, haraken wrote:
> Doesn't this GYP also depend on:
> 
> - ../../modules/generated.gypi
> - ../../bindings/core/generated.gypi
> - ../../bindings/core/idl.gypi
> - ../../core/core.gypi
> - ../../core/generated.gypi
> 
> ?

No.

Variables are *expanded* on use;
includes are only needed if you use a variable.

Consider:
a.gypi:
'variables': {'a': 'A'},

b.gypi:
'includes': ['a.gypi'],
'variables': {'b': '<(a)'},

c.gypi:
'includes': ['b.gypi'],
'variables': {'c': '<(b)'},


c.gypi does not need to include a.gypi,
because it never uses the name 'a'.


Transitive includes *are* possible in GYP;
we avoid them for exactly the reason you mention (they're fragile).
They're possible, and would look like this:

a.gypi:
'variables': {'a': 'A'},

b.gypi:
'includes': ['a.gypi'],

c.gypi:
'includes': ['b.gypi'],
'variables': {'c': '<(a)'},  # ERROR: transitive include

https://codereview.chromium.org/310563004/diff/220001/Source/bindings/modules...
File Source/bindings/modules/idl.gypi (right):

https://codereview.chromium.org/310563004/diff/220001/Source/bindings/modules...
Source/bindings/modules/idl.gypi:11: 'generated.gypi',
On 2014/06/03 15:31:10, haraken wrote:
> The same question as before. I want to understand why idl.gypi needs to depend
> on someone else.

As before: there's no *dependency* of targets,
but we need to *include* the .gypi files that *list* the IDL files.

https://codereview.chromium.org/310563004/diff/220001/Source/bindings/modules...
File Source/bindings/modules/modules.gypi (right):

https://codereview.chromium.org/310563004/diff/220001/Source/bindings/modules...
Source/bindings/modules/modules.gypi:7: '../bindings.gypi',
On 2014/06/03 15:31:10, haraken wrote:
> FIXME: remove this?

ditto (going away immediately)

https://codereview.chromium.org/310563004/diff/220001/Source/bindings/modules...
Source/bindings/modules/modules.gypi:8: 'v8/generated.gypi',
On 2014/06/03 15:31:10, haraken wrote:
> Doesn't this GYP also depend on:
> 
> ../v8/v8.gypi # FIXME: this should be v8/v8.gypi
> ../../core/generated.gypi
> 
> ?

No: Source/modules doesn't use these.
(They're only in bindings/core/core.gypi b/c Source/core uses them directly.)

https://codereview.chromium.org/310563004/diff/220001/Source/bindings/modules...
File Source/bindings/modules/v8/generated.gyp (right):

https://codereview.chromium.org/310563004/diff/220001/Source/bindings/modules...
Source/bindings/modules/v8/generated.gyp:14:
'../../../bindings/modules/modules.gypi',
On 2014/06/03 15:31:10, haraken wrote:
> Doesn't this GYP depend on ../../../bindings/modules/generated.gypi?

Handled in idl.gypi.

https://codereview.chromium.org/310563004/diff/220001/Source/bindings/modules...
Source/bindings/modules/v8/generated.gyp:17: 'generated.gypi',
On 2014/06/03 15:31:10, haraken wrote:
> I wonder why this GYP doesn't depend on anything in ../../../core/*.

B/c core and bindings/core are handled in bindings/modules,
because bindings/modules/v8 is well-factored/componentized.

https://codereview.chromium.org/310563004/diff/220001/Source/core/core_genera...
File Source/core/core_generated.gypi (right):

https://codereview.chromium.org/310563004/diff/220001/Source/core/core_genera...
Source/core/core_generated.gypi:5: {
On 2014/06/03 15:31:10, haraken wrote:
> I got confused by this GYP. I understand why we need core/core.gyp,
> core/generated.gyp and core/v8/generated.gyp, but why do we need
> core/core_generated.gyp?

This is just GYP cleanup:

bindings/core/core.gyp
bindings/core/generated.gyp
bindings/core/v8/generated.gyp
are in bindings

this file,
Source/core/core_generated.gypi
...is to match with (existing and very large):
Source/core/core_generated.gyp
...so we can output to gen/blink/core cleanly.

(It's to be used by Chang in followup, and avoids duplicate definition in
bindings)

https://codereview.chromium.org/310563004/diff/220001/Source/modules/modules_...
File Source/modules/modules_generated.gypi (right):

https://codereview.chromium.org/310563004/diff/220001/Source/modules/modules_...
Source/modules/modules_generated.gypi:5: {
On 2014/06/03 15:31:10, haraken wrote:
> 
> Ditto. I don't fully understand why we need modules/modules_generated.gypi.

Ditto: this is *Source*/modules/modules_generated.gypi

[haraken, 2014-06-04 07:59:45]

Double-checked; LGTM!

[Nils Barth (inactive), 2014-06-04 08:00:59]

The CQ bit was checked by nbarth@chromium.org

[Nils Barth (inactive), 2014-06-04 08:01:17]

On 2014/06/04 07:59:45, haraken wrote:
> Double-checked; LGTM!

Thanks, and appreciate your stamina and attention to detail!

[commit-bot: I haz the power, 2014-06-04 08:01:49]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/nbarth@chromium.org/310563004/220001

[commit-bot: I haz the power, 2014-06-04 09:38:16]

Change committed as 175462