Source/bindings/core/core.gypi - Issue 310563004: IDL build: Split global constructors into core and modules

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: Source/bindings/core/core.gypi

Issue 310563004: IDL build: Split global constructors into core and modules (Closed) Base URL: svn://svn.chromium.org/blink/trunk

Patch Set: Better includes and FIXMEs in core.gyp Created 6 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

OLD	NEW
1 # Copyright 2014 The Chromium Authors. All rights reserved.	1 # Copyright 2014 The Chromium Authors. All rights reserved.

2 # Use of this source code is governed by a BSD-style license that can be	2 # Use of this source code is governed by a BSD-style license that can be

3 # found in the LICENSE file.	3 # found in the LICENSE file.

4	4

5 {	5 {

6 'includes': [	6 'includes': [

7 '../bindings.gypi', # FIXME: factor out bindings_core http://crbug.com/3580 74	7 '../bindings.gypi',
	haraken 2014/06/03 15:31:10 FIXME: remove this? FIXME: remove this? Nils Barth (inactive) 2014/06/04 03:36:31 It's about to be removed (in immediate followup), Show quoted text On 2014/06/03 15:31:10, haraken wrote: > FIXME: remove this? It's about to be removed (in immediate followup), so don't need FIXMEs at the use sites. (No risk of missing these.)
8 '../modules/v8/generated.gypi', # FIXME: remove once bindings CG generates qualified includes http://crbug.com/377364	8 '../modules/v8/generated.gypi', # FIXME: remove once core scripts generate qualified includes correctly: http://crbug.com/358074

	9 '../v8/v8.gypi', # FIXME: should be v8/v8.gypi: http://crbug.com/358074

9 'v8/generated.gypi',	10 'v8/generated.gypi',

10 ],	11 ],

11	12

12 'variables': {	13 'variables': {

13 'bindings_core_output_dir': '<(bindings_output_dir)/core',	14 'bindings_core_output_dir': '<(bindings_output_dir)/core',

14 },	15 },

15 }	16 }

OLD	NEW