IDL build: Split global constructors into core and modules

Source/bindings/core/generated.gyp

 # Copyright 2014 The Chromium Authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 
 # Generate IDL interfaces info for core, used to generate bindings
 #
 # Design doc: http://www.chromium.org/developers/design-documents/idl-build
 
 {
   'includes': [
-    '../bindings.gypi',
-    '../scripts/scripts.gypi',
+    # ../.. == Source
+    '../../bindings/bindings.gypi',

[haraken, 2014/06/03 15:31:10]

FIXME: remove this?

[Nils Barth (inactive), 2014/06/04 03:36:31]

ditto.

+    '../../bindings/scripts/scripts.gypi',
+    '../../core/core.gypi',
     'core.gypi',
+    'generated.gypi',
     'idl.gypi',

[haraken, 2014/06/03 15:31:10]

To avoid confusion, it might be better to always write paths relative to the
Source directory.

<(source_dir)/bindings/bindings.gypi
...
<(source_dir)/bindings/core/core.gypi (instead of core.gypi)

The same comment for other parts in this CL.

[Nils Barth (inactive), 2014/06/04 03:36:31]

I'd prefer to *not* qualify paths if it's the same directory:
this makes it clear that it's part of the same group.

(OTOH, avoiding confusing multi-level .. vs. ../.. is good.)

   ],
 
   'targets': [
 ################################################################################
   {
+    'target_name': 'core_global_constructors_idls',
+    'type': 'none',
+    'dependencies': [
+        # FIXME: should be core_global_objects http://crbug.com/358074
+        '../generated.gyp:global_objects',
+    ],
+    'actions': [{
+      'action_name': 'generate_core_global_constructors_idls',
+      'inputs': [
+        '<(bindings_scripts_dir)/generate_global_constructors.py',
+        '<(bindings_scripts_dir)/utilities.py',
+        # Only includes main IDL files (exclude dependencies and testing,
+        # which should not appear on global objects).
+        '<(core_idl_files_list)',
+        '<@(core_idl_files)',
+        '<(bindings_output_dir)/GlobalObjects.pickle',
+      ],
+      'outputs': [
+        '<@(core_global_constructors_generated_idl_files)',
+        '<@(core_global_constructors_generated_header_files)',
+      ],
+      'action': [
+        'python',
+        '<(bindings_scripts_dir)/generate_global_constructors.py',
+        '--idl-files-list',
+        '<(core_idl_files_list)',
+        '--global-objects-file',
+        '<(bindings_output_dir)/GlobalObjects.pickle',
+        '--write-file-only-if-changed',
+        '<(write_file_only_if_changed)',
+        '--',
+        'Window',
+        '<(blink_core_output_dir)/WindowCoreConstructors.idl',
+        'SharedWorkerGlobalScope',
+        '<(blink_core_output_dir)/SharedWorkerGlobalScopeCoreConstructors.idl',
+        'DedicatedWorkerGlobalScope',
+        '<(blink_core_output_dir)/DedicatedWorkerGlobalScopeCoreConstructors.idl',
+        'ServiceWorkerGlobalScope',
+        '<(blink_core_output_dir)/ServiceWorkerGlobalScopeCoreConstructors.idl',
+       ],
+       'message':
+         'Generating IDL files for constructors on global objects from core',
+      }]
+  },
+################################################################################
+  {
     'target_name': 'interfaces_info_individual_core',
     'type': 'none',
     'dependencies': [
-      # FIXME: should be core_generated_idls
-      # http://crbug.com/358074
-      '../generated.gyp:generated_idls',
+      '../../core/core_generated.gyp:generated_testing_idls',
+      'core_global_constructors_idls',
     ],
     'actions': [{
       'action_name': 'compute_interfaces_info_individual_core',
       'inputs': [
         '<(bindings_scripts_dir)/compute_interfaces_info_individual.py',
         '<(bindings_scripts_dir)/utilities.py',
         '<(core_static_idl_files_list)',
         '<@(core_static_idl_files)',
         '<@(core_generated_idl_files)',
       ],
@@ skipping 14 matching lines @@
         '--',
         # Generated files must be passed at command line
         '<@(core_generated_idl_files)',
       ],
       'message': 'Computing global information about individual IDL files',
       }]
   },
 ################################################################################
   ],  # targets
 }