Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(100)

Unified Diff: Source/bindings/core/core.gypi

Issue 310563004: IDL build: Split global constructors into core and modules (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Better includes and FIXMEs in core.gyp Created 6 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: Source/bindings/core/core.gypi
diff --git a/Source/bindings/core/core.gypi b/Source/bindings/core/core.gypi
index f98bc08d6a0299a5f1562c3aef255bec330b26cf..4e8dff36b2a12d6bd87349d140cb83182745aeee 100644
--- a/Source/bindings/core/core.gypi
+++ b/Source/bindings/core/core.gypi
@@ -4,8 +4,9 @@
{
'includes': [
- '../bindings.gypi', # FIXME: factor out bindings_core http://crbug.com/358074
- '../modules/v8/generated.gypi', # FIXME: remove once bindings CG generates qualified includes http://crbug.com/377364
+ '../bindings.gypi',
haraken 2014/06/03 15:31:10 FIXME: remove this?
Nils Barth (inactive) 2014/06/04 03:36:31 It's about to be removed (in immediate followup),
+ '../modules/v8/generated.gypi', # FIXME: remove once core scripts generate qualified includes correctly: http://crbug.com/358074
+ '../v8/v8.gypi', # FIXME: should be v8/v8.gypi: http://crbug.com/358074
'v8/generated.gypi',
],

Powered by Google App Engine
This is Rietveld 408576698