Source/core/core_generated.gypi - Issue 310563004: IDL build: Split global constructors into core and modules

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: Source/core/core_generated.gypi

Issue 310563004: IDL build: Split global constructors into core and modules (Closed) Base URL: svn://svn.chromium.org/blink/trunk

Patch Set: Better includes and FIXMEs in core.gyp Created 6 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

OLD	NEW
(Empty)
	1 # Copyright 2014 The Chromium Authors. All rights reserved.

	2 # Use of this source code is governed by a BSD-style license that can be

	3 # found in the LICENSE file.

	4

	5 {
	haraken 2014/06/03 15:31:10 I got confused by this GYP. I understand why we ne I got confused by this GYP. I understand why we need core/core.gyp, core/generated.gyp and core/v8/generated.gyp, but why do we need core/core_generated.gyp? Nils Barth (inactive) 2014/06/04 03:36:32 This is just GYP cleanup: bindings/core/core.gyp Show quoted text On 2014/06/03 15:31:10, haraken wrote: > I got confused by this GYP. I understand why we need core/core.gyp, > core/generated.gyp and core/v8/generated.gyp, but why do we need > core/core_generated.gyp? This is just GYP cleanup: bindings/core/core.gyp bindings/core/generated.gyp bindings/core/v8/generated.gyp are in bindings this file, Source/core/core_generated.gypi ...is to match with (existing and very large): Source/core/core_generated.gyp ...so we can output to gen/blink/core cleanly. (It's to be used by Chang in followup, and avoids duplicate definition in bindings)
	6 'variables': {

	7 # FIXME: core_generated should output to here http://crbug.com/358074

	8 'blink_core_output_dir': '<(SHARED_INTERMEDIATE_DIR)/blink/core',

	9 },

	10 }

OLD	NEW