Source/bindings/modules/modules.gypi - Issue 310563004: IDL build: Split global constructors into core and modules

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/bindings/modules/modules.gypi

Issue 310563004: IDL build: Split global constructors into core and modules (Closed) Base URL: svn://svn.chromium.org/blink/trunk

Patch Set: Better includes and FIXMEs in core.gyp Created 6 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: Source/bindings/modules/modules.gypi

diff --git a/Source/bindings/modules/modules.gypi b/Source/bindings/modules/modules.gypi

index ff05a1bd1e67fd3fb4e13e2981503673f0dee62f..9ef222425587bcf119555320fe220825aad205a4 100644

--- a/Source/bindings/modules/modules.gypi

+++ b/Source/bindings/modules/modules.gypi

@@ -4,7 +4,7 @@

{

'includes': [

- '../bindings.gypi', # FIXME: factor out bindings_modules http://crbug.com/358074

+ '../bindings.gypi',

haraken 2014/06/03 15:31:10 FIXME: remove this?

Nils Barth (inactive) 2014/06/04 03:36:31 ditto (going away immediately)

'v8/generated.gypi',

haraken 2014/06/03 15:31:10 Doesn't this GYP also depend on: ../v8/v8.gypi #

Nils Barth (inactive) 2014/06/04 03:36:31 No: Source/modules doesn't use these. (They're onl