[pinpoint] Gerrit patch support.

[pinpoint] Gerrit patch support.

GerritPatch.FromDict() is designed to take two formats:
* A patch URL, that a user might enter into a dialog when kicking off a try job.
* A dict of fields containing info that:
  * A builder will have available when building with a Gerrit patch.
  * Can be used to look up the patch in the Gerrit API.
  * Uniquely identifies a patch revision.

BUG=catapult:#3884

Review-Url: https://chromiumcodereview.appspot.com/3019553002
Committed: https://chromium.googlesource.com/external/github.com/catapult-project/catapult/+/f68ffdaec72c9175bf45a70b5db4c8ea6d56f48f

[dtu, 2017-09-22 21:16:45]

dtu@chromium.org changed reviewers:
+ perezju@chromium.org, simonhatch@chromium.org, sullivan@chromium.org

[dtu, 2017-09-22 21:17:12]

Description was changed from

==========
[pinpoint] Gerrit patch support.

GerritPatch.FromDict() is designed to take two formats:
* A patch URL, that a user might enter into a dialog when kicking off a try job.
* A dict of fields containing info that:
  * A builder will have available when building with a Gerrit patch.
  * Can be used to look up the patch in the Gerrit API.
  * Uniquely identifies the patch.

BUG=catapult:#3884
==========

to

==========
[pinpoint] Gerrit patch support.

GerritPatch.FromDict() is designed to take two formats:
* A patch URL, that a user might enter into a dialog when kicking off a try job.
* A dict of fields containing info that:
  * A builder will have available when building with a Gerrit patch.
  * Can be used to look up the patch in the Gerrit API.
  * Uniquely identifies a patch revision.

BUG=catapult:#3884
==========

[perezju, 2017-09-25 09:22:21]

lgtm

https://codereview.chromium.org/3019553002/diff/1/dashboard/dashboard/pinpoin...
File dashboard/dashboard/pinpoint/models/change/patch.py (right):

https://codereview.chromium.org/3019553002/diff/1/dashboard/dashboard/pinpoin...
dashboard/dashboard/pinpoint/models/change/patch.py:70: url_parts =
urlparse.urlparse(data)
nit: Add a small comment with an example of how such an URL looks like.

[shatch, 2017-09-25 14:13:34]

lgtm

[dtu, 2017-09-25 20:29:55]

https://codereview.chromium.org/3019553002/diff/1/dashboard/dashboard/pinpoin...
File dashboard/dashboard/pinpoint/models/change/patch.py (right):

https://codereview.chromium.org/3019553002/diff/1/dashboard/dashboard/pinpoin...
dashboard/dashboard/pinpoint/models/change/patch.py:70: url_parts =
urlparse.urlparse(data)
On 2017/09/25 09:22:21, perezju wrote:
> nit: Add a small comment with an example of how such an URL looks like.

Done.

[dtu, 2017-09-25 20:29:58]

The CQ bit was checked by dtu@chromium.org

[dtu, 2017-09-25 20:30:01]

The patchset sent to the CQ was uploaded after l-g-t-m from
perezju@chromium.org, simonhatch@chromium.org
Link to the patchset: https://codereview.chromium.org/3019553002/#ps20001
(title: "Example URL")

[commit-bot: I haz the power, 2017-09-25 20:30:18]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-09-25 21:24:46]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-09-25 21:24:48]

Try jobs failed on following builders:
  Catapult Windows Tryserver on master.tryserver.client.catapult (JOB_FAILED,
https://build.chromium.org/p/tryserver.client.catapult/builders/Catapult%20Wi...)

[perezju, 2017-09-26 09:15:47]

https://codereview.chromium.org/3019553002/diff/20001/dashboard/dashboard/pin...
File dashboard/dashboard/pinpoint/models/change/patch.py (right):

https://codereview.chromium.org/3019553002/diff/20001/dashboard/dashboard/pin...
dashboard/dashboard/pinpoint/models/change/patch.py:75: revision = None
how do we know to which repository should the patch be applied (i.e. the
"tools/build" part)?

[dtu, 2017-09-26 19:54:58]

The CQ bit was checked by dtu@chromium.org

[dtu, 2017-09-26 19:55:02]

The CQ bit was unchecked by dtu@chromium.org

[dtu, 2017-09-26 20:00:23]

https://codereview.chromium.org/3019553002/diff/20001/dashboard/dashboard/pin...
File dashboard/dashboard/pinpoint/models/change/patch.py (right):

https://codereview.chromium.org/3019553002/diff/20001/dashboard/dashboard/pin...
dashboard/dashboard/pinpoint/models/change/patch.py:75: revision = None
On 2017/09/26 09:15:47, perezju wrote:
> how do we know to which repository should the patch be applied (i.e. the
> "tools/build" part)?

As far as I can tell from the Gerrit doc, the numeric Change-Id is unique across
all repos.
On line 84, we convert the Change-Id to a canonical {change-id}.
In BuildParameters() on line 44, we look up the repository from the {change-id}
using the Gerrit API.

[dtu, 2017-09-26 20:00:55]

The Windows tryserver failure I think will be fixed in
https://codereview.chromium.org/3017633002/

[dtu, 2017-09-26 21:29:07]

The CQ bit was checked by dtu@chromium.org

[commit-bot: I haz the power, 2017-09-26 21:29:19]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-09-26 22:01:36]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1506461347175660,
"parent_rev": "2ad505e663aa05638ba89f4323c7e8099f216c84", "commit_rev":
"f68ffdaec72c9175bf45a70b5db4c8ea6d56f48f"}

[commit-bot: I haz the power, 2017-09-26 22:01:42]

Description was changed from

==========
[pinpoint] Gerrit patch support.

GerritPatch.FromDict() is designed to take two formats:
* A patch URL, that a user might enter into a dialog when kicking off a try job.
* A dict of fields containing info that:
  * A builder will have available when building with a Gerrit patch.
  * Can be used to look up the patch in the Gerrit API.
  * Uniquely identifies a patch revision.

BUG=catapult:#3884
==========

to

==========
[pinpoint] Gerrit patch support.

GerritPatch.FromDict() is designed to take two formats:
* A patch URL, that a user might enter into a dialog when kicking off a try job.
* A dict of fields containing info that:
  * A builder will have available when building with a Gerrit patch.
  * Can be used to look up the patch in the Gerrit API.
  * Uniquely identifies a patch revision.

BUG=catapult:#3884

Review-Url: https://chromiumcodereview.appspot.com/3019553002
Committed:
https://chromium.googlesource.com/external/github.com/catapult-project/catapu...
==========

[commit-bot: I haz the power, 2017-09-26 22:01:43]

Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/external/github.com/catapult-project/catapu...

[perezju, 2017-09-27 08:21:47]

https://codereview.chromium.org/3019553002/diff/20001/dashboard/dashboard/pin...
File dashboard/dashboard/pinpoint/models/change/patch.py (right):

https://codereview.chromium.org/3019553002/diff/20001/dashboard/dashboard/pin...
dashboard/dashboard/pinpoint/models/change/patch.py:75: revision = None
On 2017/09/26 20:00:23, dtu wrote:
> the numeric Change-Id is unique across all repos.

Wow, had no idea. Ok, thanks for the explanation!